Re: [PATCH v4 2/2] rust: add dma coherent allocator abstraction.

[Abdiel Janulgue <abdiel.janulgue@gmail.com>]

On 10/11/2024 01:42, Daniel Almeida wrote:
>> You mean the read/write helpers could be removed and we expose the cpu_buf() helper instead that takes a valid range, returns a checked slice and let the user have the flexibility in implementing read/writes themselves. Is this what you had in mind?
> 
> Yes, that’s what I have in mind.
> 
> 
> Alice pointed out to me later that the FromBytes/AsBytes traits can be implemented
> by driver-defined types. I had missed that.
> 
> Given this, the FromBytes/AsBytes bound seems fine. Drivers would just need to
> implement the (unsafe) traits for their types and it would be up to them to make
> sure that the safety requirements hold.
> 
> Given the above, I am fine with FromBytes/AsBytes, you don’t need to change
> that IMHO.
> 
> With read() and write() gone, so is the bound on Copy, which also satisfies
> my other comment.
> 

Thanks! Will incorporate this feedback on the next re-spin.

/abdiel