From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-40131.protonmail.ch (mail-40131.protonmail.ch [185.70.40.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61CC81170F for ; Sun, 7 Apr 2024 08:59:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.40.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712480343; cv=none; b=sw/5a8wdmKF0ShfgnqhfQGjjUrqWCx9KasdwdlC6suPuM0dCuHXgx68cHjgeLbqYczc1BwxYZZwTIWG629wi7//tMECCFYx8kxMOdD8jM0Rw+GrfNEKsa9BUQzGG2PFVZ+g51xyfuUIuL1dQzasMMqqrdhSmSP2qt5JxSAIoM9Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712480343; c=relaxed/simple; bh=APMjPK8g5pOGPv0dwlk1KSseSXNGp/4m07t8x/ixSo0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rENAwyih+zOqxIKT+KN1x0uc4uAvd41w0SX0TYlnInbzz6O0/6u/y7IxzkNQClUThJnNmODNwCP2sUQxuUEYIqr+xGpXb1fBB9zt6ajM/PoCbnwlLZCdDxqiAc/4Q+pCJkhqH/s8DSsS0gKGVA8xTZO02Dy8ni9OCvQhd8oas78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=pass smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=W4KM894T; arc=none smtp.client-ip=185.70.40.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proton.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="W4KM894T" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=pqs54sg6ifhbtj7unmv7pp4qau.protonmail; t=1712480338; x=1712739538; bh=APMjPK8g5pOGPv0dwlk1KSseSXNGp/4m07t8x/ixSo0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=W4KM894T30Nvu/5Jg8f5a0pedkYEE9Ylz9e18LTSxXUYXznis8BometXs7Yrf7al6 SU7+lWst6jQZdOOyRDFBM4ps0WD/pkIt0cuSbgU/hFttyxhj/p200c9O7D+XSdfb2S uBHSq2l8JFwrOVb0vV5qUJJBwELvvFxrP+TIly1xKnw+TtGeonf4Nbe6+WS5Hbxw+K yUf4ubNEklQZ6OhSeku5G9NqwLaSOlliVdOFsQfQ9jMqApNkCEYE6SaYH1ys5XNRdZ QWtDcR6Vmwyy/qSS+nnNS6xXzmjxAq4y124thVRZB8Agf5UZkjV6GOdNCMWsht4a4D caZhhArNRMktA== Date: Sun, 07 Apr 2024 08:58:50 +0000 To: Alice Ryhl From: Benno Lossin Cc: Miguel Ojeda , Matthew Wilcox , Al Viro , Andrew Morton , Kees Cook , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Greg Kroah-Hartman , =?utf-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Subject: Re: [PATCH v4 4/4] rust: add abstraction for `struct page` Message-ID: In-Reply-To: References: <20240404-alice-mm-v4-0-49a84242cf02@google.com> <20240404-alice-mm-v4-4-49a84242cf02@google.com> Feedback-ID: 71780778:user:proton Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05.04.24 09:44, Alice Ryhl wrote: > On Fri, Apr 5, 2024 at 12:33=E2=80=AFAM Benno Lossin wrote: >> >> On 04.04.24 14:31, Alice Ryhl wrote: >>> +/// A bitwise shift for the page size. >>> +#[allow(clippy::unnecessary_cast)] >> >> Why can't you remove the cast? >=20 > Bindgen could decide to use a different type in the future or on > different platforms. Did that already happen? I think that we might want to know if the type changes, since then the value might change? --=20 Cheers, Benno