From: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
To: Thomas Bertschinger <tahbertschinger@gmail.com>,
ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com,
rust-for-linux@vger.kernel.org
Cc: Alice Ryhl <aliceryhl@google.com>
Subject: Re: [PATCH v2] rust: place generated init_module() function in .init.text
Date: Mon, 5 Feb 2024 22:39:40 -0300 [thread overview]
Message-ID: <c5a8d670-2574-4d64-8928-d606968f360e@gmail.com> (raw)
In-Reply-To: <20240206012535.480193-1-tahbertschinger@gmail.com>
On 2/5/24 22:25, Thomas Bertschinger wrote:
> [...]
> // Loadable modules need to export the `{{init,cleanup}}_module` identifiers.
> + /// # Safety
> + /// This function must only be called once, during module initialization, because it
> + /// may be freed after it returns.
The thing with this doc comment is that it's going to be hidden because
of the `#[doc(hidden)]` attribute. I think that it should either be a
common comment, placed elsewhere or removed.
> [...]
next prev parent reply other threads:[~2024-02-06 1:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 1:25 [PATCH v2] rust: place generated init_module() function in .init.text Thomas Bertschinger
2024-02-06 1:39 ` Martin Rodriguez Reboredo [this message]
2024-02-06 2:13 ` Thomas Bertschinger
2024-02-06 3:10 ` Trevor Gross
2024-02-06 3:17 ` Trevor Gross
2024-02-06 10:01 ` Greg KH
2024-02-06 10:51 ` Miguel Ojeda
2024-02-06 10:58 ` Greg KH
2024-02-06 11:31 ` Miguel Ojeda
2024-02-06 14:49 ` Thomas Bertschinger
2024-02-06 16:07 ` Martin Rodriguez Reboredo
2024-02-06 17:19 ` Miguel Ojeda
2024-02-06 21:28 ` Martin Rodriguez Reboredo
2024-02-06 17:19 ` Miguel Ojeda
2024-02-06 10:01 ` Greg KH
2024-02-06 10:29 ` Alice Ryhl
2024-02-06 10:50 ` Greg KH
2024-02-06 11:18 ` Miguel Ojeda
2024-02-06 10:57 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5a8d670-2574-4d64-8928-d606968f360e@gmail.com \
--to=yakoyoku@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tahbertschinger@gmail.com \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).