From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sonic313-56.consmr.mail.ne1.yahoo.com (sonic313-56.consmr.mail.ne1.yahoo.com [66.163.185.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 113DC235BFB for ; Wed, 2 Apr 2025 11:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.163.185.31 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743595171; cv=none; b=jd0arseTvIIdho3ysXbYU39oFDMbx1fIFDm+dYCSnlAvLzv33luj0ng54Y8+a+cqYVcfR1BxXahfXjhGE857otII1L1jkDxRgEsT6qH1UfE1UDtxnTHj6DQIv7bNagjd0WquvY2/SoCbphPmDEAp43NgyH0F98Ec0NhsbpuadDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743595171; c=relaxed/simple; bh=K9mgS3gB83UNYPiJrFTJbiz5/atmBVU2yJ0hy/JCmjE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CG14h9uEzJvOAYMUiobXVbtBhSrWVy+kUa9SpRt41j/gAX0IGnRC7e6qr0cyGe7RQjiOGpTgU8iKwr9Z8lBpd1RoYimjDzJ2RXVwtrYclQvO0hk8JWpoq0mNZorvFZ0+HYFbq3MXteuVHTGr8B4p6MOmp+r4IeyhPHJ3K1y7uHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com; spf=pass smtp.mailfrom=yahoo.com; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b=ODmC5kKA; arc=none smtp.client-ip=66.163.185.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yahoo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b="ODmC5kKA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1743595163; bh=6IzAKpf/lnjFDO7jeweEIN/2TWpXazBiCV70Zfhg8BE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=ODmC5kKAVnB1KW2SnscgZbobg3b5rzIGDKs3t5m41UdggNFz/zOl38Teb9zEP2CnKSBxmv+8uMOwoRXuBEJPoBqjwTm/q953Dpw4LPmAgF6P96k+s74/ybtdrVI/4xH0nU2QGDRbZkCpR0rQ3r2fJvq8c+/NAr79pPw4c5mGPG5SZ41Mu3ipEEQ729B0QAHRPmj0PFHBxrRMlq8+CGs2+hfyP2c47aoBm8dUTliTgWo9nyiLHE1T/167WaFTsbJmvSKPJVBkCkJOS26bHVH3KrJHnRBWvdbd1a/+8daylOendEHaAhIwobxqV56tr49FmIgGaZbt3NAaS3gMvuuqUQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1743595163; bh=E9Pq4s7EmjLiN4m66lfBTZ1IU5gWwScm/YcW2oG8dIZ=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=rhG2+h+c8XnIdg6deKg8WH24Owg3SD6P7UKFtO/K/Wp7yfoUt4HCpQqi5+VwvyjFUrvfWo6iDkPrcvHjSraKsCiszRnXrQBeTVJy/KzNUggQLwk09CmuVTm575GwtFS7YwvxBOyFaZzKAijYTiZZL8Ctc1JS0aQFdh7ztw7mAh71v8V3nfgobiJ6+iAIrPQDT9Jk9AMk08lH7q5fEbQrs7ZvksFHERbRCMVpY3hIrHzoRKvIxdpKpsFPBOaZonPewB4rYqTsAWIDe3xy/Er5/IDdzJzKmX7CbxE0k8imQoCVVcdJC+awWDGemSOadlDopptgp+WzrZ9NOq7LL0q+Mw== X-YMail-OSG: aCExLDUVM1nR0khNM8NmyNboVtWDlG1O3.5pwXI._R7a3xbYSJPgfquKR_3WvLY TbDR2tuRQTkvpmiRlZrlTXeuqYFUzmdHJdCIiwj.QFgnDqik5zuUp9UVyTfih_xNby.vf9fseoBC DIjDMFROfLD1JBiQwZpVpBlB6z0jC.HAq9TdjNo_u29BUwhts_VW2gFUzT8Em48zYQ2yWHpr3NTU 28mW_8_2N0Px6WsNxCBdQ.fesboM2qSEFHMhvsVtFrVTHubSQxneACBgMllb4Kwf4EokNac.1wtz oZ8aJfXpKlGoHLqG5iscO9_jPnVTuWPoqmwWeb6TJNOFxZP_UlkUBRnsZcOEwPWBIdo0YESCRxZu lQw3OYPMewf9DkeqBHS_zv5RG_kij84dmXxjXl6D33loyhxvvLKt2xS7qJH8diFM9sxGmwY670ku Gg9k3RgVbD7kWyzanCIh3E8efD5Oyepyvd8BBSGvVQDDaustX3yofwNZSTMQtiL6pPAYRYNHxXYH duKcRaEuuIhMHDB23sYsYfqUBEGhg9LLSYqelMkI.XfzvReYU9BBC7OE901tumicicYEWqBWQfxt oIeFhJdV8kbOSernp28YctHt1j5uJCJQvTP6ElDyPID8Rwv7NEog6YWAsp3.JrYFC4fcavpumadZ eZL1PfaIkzV_dWs7HcRjNOczWFYWgMcQbN75bdleejfmV9mp9YYReP.xIH8uI8d3qTqoFBi74zU3 ae0LmNc7b7AbrLWBq7LfQYgZq2wQkUruMj2x3xqXiG7gvDw.Mps4Vjvv0ec7vGh7L_jWgh5hQH6a EtoyKOoaoinCUjgaFdEGG_tBeNO9zsZqfhAK54qPGQ61wGGDpgK8qnFX6BKwVufmxIlrBontHnRd oz.HX75xr83A9kDdnD1f0GsWZletEp7kLyKYoudXLECTcyB_RQNPGCSDEXyMdZdsPWQqAwPabQOV WOUQlSeF9HRW5VMalNS8rE1gr1AHxnaikNNPkURP_ZuOO2ODgcUV9GnBVXky2cjR86Zi.Q2nA_N7 ex2tnqB4QxNb4WfOOo0Y_IP.nrZqpdrUNe1FLURb9K3nwzalqu9G_FE8k04E02AymYvKt7rd1Qgg 7MoxyWiTELLEMdOMhoGEvbojOO9wEUxLdJrey5noPfP1QHfg5psENQoFT7AokG1fP2fR6rw.Ruoa nYrxbGyMpIEDfBx3zuPGU4PS_GIl6BpbqyIcgQHAqrq0EKc5h9msuPrHwCAuFRcQL3KzqzoQ8y6z 2FhFssWY358VdBdwiuXuRgQWLs390ty25XfY72NQCzgarq0cmRQziEg9QGCqBBINAMkD0FdM3un7 wyNPuhIX27epTM7zMy7TDXqBl96WNTyDhdF.epstfmmHH0_jlesR06mP0ZWSJy5mWF.TKgm8WR5e 05d5pXQOrRhMDG27yR.omU340Z8cjtSJhSecQi.hZWGqGO8KHzG_0mTKezV.4LV0rIc_5.YHFLRY y6hIoiMDrOOVcwDG5R2CtRfhN6v.g7t81DI5GzgSE8HGka2xg_DIUcz7YvleADuCjCcipY8hcQEj J2P.JwGYyc_B6vEm.gZJHzYJHKcFoJ9lqQ6S59KUgEbL5t8sTdQJlpNqVg_SO7Fiq7cymKjR2iX0 7NYevenAyB6WZLyxEQ47nMi5gTumgd2E8THRwWXtjCzXazqigy.CeArnMuxzqURGsPkR2F.9ER0G XS0HUZP8r3ZLXtrVEL7Q4Yu4G3oI8FOc65h6rl5GVrZoN3qrj4FHNrTtJedXguXE6lmoEKMJHJXL MNgBadhfPTAkzZHLOJ.BDlRdU0kyAKVHswoeEh8hHxeL6R9J8WUGqJx4ifCuykWH3lgHQN0j.476 BnMwkBIt6jVCbmf4MyI011P07SuP888RhR_w7BUglShA0lbercyPha.AAppfEcbONZGkQ6AgLiN4 rCXN2aU4LBUP.Kq0tkFysGTrznnr1HVGQ3vZ8qFgelDOzGBioG55NxDAHukEV3cRUk3w74.HaIho yjCjshlIZzcvJEzgySdee7.v_7dPAsHAHfnqNMkxaOiKcjgmAPORHdThhPuBrcSLc_zEp1bVNj9Z Hq_J2haRO6k6wmTz34y7_roFvfy5Br1jZpZS3OUilibHVmsYXXd7hAT6u0rH.3hZlTXjGVXBzRlH bmuYGULKibfy.i0ZXnx4jxef5ETxhe9WFjNXD9tEQqOKgb8ziRRNmiMbkPdhMT6ILLMvOfFnfp1s tPG862rV.BUS7.Cy4THmYvibI5ZKOH.bcgq8QKQLJ7ySXGK8Jbw-- X-Sonic-MF: X-Sonic-ID: 6fa753fb-2bde-48ad-be1b-01ae2c5bac15 Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Wed, 2 Apr 2025 11:59:23 +0000 Received: by hermes--production-ir2-54ff696c44-6c6z5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID c1f234074c8b9a8996b30914a55443ef; Wed, 02 Apr 2025 11:49:09 +0000 (UTC) Message-ID: Date: Wed, 2 Apr 2025 12:49:08 +0100 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] docs: rust: quick-start: update Ubuntu instructions To: Miguel Ojeda Cc: Miguel Ojeda , Alex Gaynor , Benno Lossin , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , rust-for-linux@vger.kernel.org References: <20250402104759.1764282-1-igor.korotin.ref@yahoo.com> <20250402104759.1764282-1-igor.korotin@yahoo.com> Content-Language: en-US From: Igor Korotin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.23590 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo On 4/2/25 12:26, Miguel Ojeda wrote: > On Wed, Apr 2, 2025 at 12:48 PM Igor Korotin wrote: >> >> +``PATH`` needs to be set when installing rust 1.80 with apt, e.g.:: >> + >> + PATH=/usr/lib/rust-1.80/bin:$PATH > > Why does it need to be set? i.e. why not `RUSTC=...` for that one too? > > In other words, why are we mixing the approaches? We can explain both, > but mixing them seems confusing. I checked what happens with other tools(For example rustdoc) if I define only `RUSTC=rustc-1.80`. Unsurprisingly `rustdoc` remains 1.75, which is installed from `rustc` package, which in its turn is dependency for the package `bindgen-0.65`. Though I see that this mix works fine, it seems a little bit weird when you have one tool of version 1.80 another 1.75, etc. Without a doubt one can define each tool explicitly using `RUSTC`, `RUSTDOC`, etc. On the other hand defining `PATH` to `/usr/lib/rust-1.80/bin/` automatically makes build to use rust-1.80 tools. >> +Deb package bindgen-0.65 does not set itself as a default, thus it should be set >> +explicitly, e.g.:: >> + >> + BINDGEN=bindgen-0.65 > > I don't think this example adds much, since we already show it below. This was intention to explain each additional environment part of the overall command. >> + make LLVM=1 PATH=/usr/lib/rust-1.80/bin:$PATH \ >> + RUST_LIB_SRC=/usr/src/rustc-$(rustc-1.80 --version | cut -d' ' -f2)/library \ > > Note that `RUST_LIB_SRC` (and `PATH`) are not needed there, i.e. those > two can be set as environment variables. > > Perhaps we could just add something like this to the existing paragraph: > > ``RUST_LIB_SRC`` needs to be set (possibly as an environment variable) ... By adding these as part of the overall build command, I was going by your earlier statement that you prefer setups that minimize global changes. > > Also, weren't we going to mention `RUSTDOC`, `RUSTFMT` and `CLIPPY_DRIVER`? This one was supposed to be covered by `PATH=/usr/lib/rust-1.80/bin:$PATH` Thanks for the review Best Regards Igor