From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-222.mta1.migadu.com [95.215.58.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C956F3BB138 for ; Thu, 13 Aug 2026 11:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.222 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786621964; cv=none; b=PEQk2nh8hQO0sZI4ymp7BEC1ITVWkzbwLYWqw6CQqxn99Ttgo8aztIVVez3LCkf0eqAGhCMU9uKUTcY57he8vCThbrKVIgfzza10+IWgnif+dcsG/814H6+MG03mp/fC88C3KgVOb65gQZQOBR5rU17TEL599a4vcw91eCYzEds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786621964; c=relaxed/simple; bh=R2f0PJtuTSVROgAmYKIuGCx86gpNuYMzhmVycIrzC/0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d81VTl5ZaE7OH4em62wPUEthOaU8UjcX5vJE96qn2RL4FAWp6Zb9hHZP+Ab2R4QwjQhey7z5p7p+7daIXTuD/OWHGtc48xEZBrkzL2SoYvbshfRH5TP/mR8Hi+QM7dy6jKBcs0uKsSqIoXi5Ao7qY2Kc2g6YAVA0o27Ho6HVQEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ubtiHOCi; arc=none smtp.client-ip=95.215.58.222 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ubtiHOCi" X-Envelope-To: rust-for-linux@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=R2f0PJtuTSVROgAmYKIuGCx86gpNuYMzhmVycIrzC/0=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1786621958; v=1; x=1787226758; b=ubtiHOCiVF+6G2c57ZPAvI6l+awYjHl+AIb5taDvumN7OMQCvAXROI+r8LU1Uh4u47ZDTwcP +c1G/hi9ZzkB30pl20V961orVKZoU3tfKI/qpVs+Jk6DnEGQfKo/qnEmgrN069VuLkPSLEc+jBz c14PQhuIwKPL9sizx6dY8eoM= X-Envelope-To: rust-for-linux@vger.kernel.org Received: from [192.168.200.2] (2a11:3:200::10a9) by smtp.migadu.com with ESMTPS id dd9de6576435b65a; Thu, 13 Aug 2026 11:52:38 +0000 X-Migadu-Flow: FLOW_OUT Message-ID: Date: Thu, 13 Aug 2026 19:51:04 +0800 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 00/10] Fix missing fops.owner in Rust DRM/misc abstractions To: Miguel Ojeda Cc: Danilo Krummrich , Gary Guo , Mark Brown , Miguel Ojeda , Boqun Feng , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Greg Kroah-Hartman , "Rafael J. Wysocki" , David Airlie , Simona Vetter , Daniel Almeida , Arnd Bergmann , Brendan Higgins , David Gow , Rae Moar , Breno Leitao , Jens Axboe , Dave Ertman , Leon Romanovsky , Igor Korotin , FUJITA Tomonori , Bjorn Helgaas , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , =?UTF-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Christian Brauner , Carlos Llamas , rust-for-linux@vger.kernel.org, linux-modules@vger.kernel.org, driver-core@lists.linux.dev, dri-devel@lists.freedesktop.org, nova-gpu@lists.linux.dev, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org References: <20260811-fix-fops-owner-v10-0-7e71776f9dbe@linux.dev> From: Alvin Sun In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/13/26 17:32, Miguel Ojeda wrote: > On Thu, Aug 13, 2026 at 1:57 AM Gary Guo wrote: >> IMO this is the correct way, also consistent with >> >> https://lore.kernel.org/rust-for-linux/20260811-fix-fops-owner-v10-3-7e71776f9dbe@linux.dev/ >> >> It might make sense to add this to rust-next. > Yeah, it is also consistent (in the sense of adding a fallback) with > the other fix I added when applying the series for the `macros` > doctest; and the `kernel` crate is not an actual module yet. > > I guess yet another solution would be to have an even more local > fallback, but that would be too local in my opinion, i.e. we will want > to use it elsewhere sooner or later. > > So I could fold [2] into commit 98f256e27262, but a commit on top is > fine, I will reference that commit from the new one instead. > > Ok, done -- Danilo, I took your diff and converted it into a proper > commit, please double-check you are OK with the Signed-off-by: > > ec6fcf8a175a ("rust: kernel: add `LocalModule` fallback for > `#[vtable]` `impl`s") I was just looking at the difference between the doctest and in-crate `#[kunit_tests]` test paths — thanks for taking care of this. I'll look into [3] once the new build system lands. Best regards, Alvin > > Thanks! > > Cheers, > Miguel