From: Andrew Lunn <andrew@lunn.ch>
To: FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: boqun.feng@gmail.com, dirk.behme@de.bosch.com,
aliceryhl@google.com, netdev@vger.kernel.org,
rust-for-linux@vger.kernel.org, hkallweit1@gmail.com,
tmgross@umich.edu, ojeda@kernel.org, alex.gaynor@gmail.com,
gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me, a.hindborg@samsung.com
Subject: Re: iopoll abstraction
Date: Fri, 4 Oct 2024 15:37:57 +0200 [thread overview]
Message-ID: <d2351ed1-c77c-4a2c-a0ed-d23d9bcc388a@lunn.ch> (raw)
In-Reply-To: <20241004.204803.2223000488444244418.fujita.tomonori@gmail.com>
On Fri, Oct 04, 2024 at 08:48:03PM +0900, FUJITA Tomonori wrote:
> On Thu, 3 Oct 2024 18:09:15 +0200
> Andrew Lunn <andrew@lunn.ch> wrote:
>
> > We probably also want a comment that this helper cannot be used in
> > atomic context.
>
> Yeah, I'll add such.
>
> > Do we have a Rust equivalent of might_sleep()?
> >
> > https://elixir.bootlin.com/linux/v6.12-rc1/source/include/linux/kernel.h#L93
>
> No. I'll add bindings for might_sleep() and cpu_relax().
Please make sure you involve the scheduler people. This is now well
outside of networking, same as the discussion around time has little
to do with networking.
The might_sleep() is not a strong requirement for iopoll, so you might
want to get the basic functionality merged first, and then once
might_sleep() is agreed on, add it to iopoll. It is just a debug
feature.
Andrew
next prev parent reply other threads:[~2024-10-04 13:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 11:25 [PATCH net-next v1 0/2] add delay abstraction (sleep functions) FUJITA Tomonori
2024-10-01 11:25 ` [PATCH net-next v1 1/2] rust: add delay abstraction FUJITA Tomonori
2024-10-01 11:33 ` Alice Ryhl
2024-10-01 12:31 ` Andrew Lunn
2024-10-01 15:08 ` Miguel Ojeda
2024-10-02 11:34 ` FUJITA Tomonori
2024-10-02 12:18 ` Andrew Lunn
2024-10-02 12:35 ` Miguel Ojeda
2024-10-02 12:51 ` Andrew Lunn
2024-10-02 13:21 ` Miguel Ojeda
2024-10-02 20:04 ` Thomas Gleixner
2024-10-02 12:37 ` Alice Ryhl
2024-10-02 13:58 ` FUJITA Tomonori
2024-10-02 14:27 ` Alice Ryhl
2024-10-02 14:40 ` FUJITA Tomonori
2024-10-02 14:52 ` Miguel Ojeda
2024-10-02 19:40 ` Thomas Gleixner
2024-10-03 1:24 ` FUJITA Tomonori
2024-10-03 10:50 ` Miguel Ojeda
2024-10-03 12:33 ` Andrew Lunn
2024-10-04 12:08 ` FUJITA Tomonori
2024-10-04 14:08 ` Andrew Lunn
2024-10-01 11:25 ` [PATCH net-next v1 2/2] net: phy: qt2025: wait until PHY becomes ready FUJITA Tomonori
2024-10-01 11:36 ` Alice Ryhl
2024-10-01 12:48 ` Andrew Lunn
2024-10-02 4:39 ` iopoll abstraction (was: Re: [PATCH net-next v1 2/2] net: phy: qt2025: wait until PHY becomes ready) Dirk Behme
2024-10-02 9:56 ` iopoll abstraction FUJITA Tomonori
2024-10-03 11:52 ` Boqun Feng
2024-10-03 13:45 ` FUJITA Tomonori
2024-10-03 14:25 ` Boqun Feng
2024-10-03 16:00 ` Andrew Lunn
2024-10-04 11:54 ` FUJITA Tomonori
2024-10-03 16:09 ` Andrew Lunn
2024-10-04 11:48 ` FUJITA Tomonori
2024-10-04 13:37 ` Andrew Lunn [this message]
2024-10-02 10:13 ` [PATCH net-next v1 2/2] net: phy: qt2025: wait until PHY becomes ready FUJITA Tomonori
2024-10-02 12:31 ` Andrew Lunn
2024-10-03 5:07 ` FUJITA Tomonori
2024-10-02 11:17 ` FUJITA Tomonori
2024-10-01 11:39 ` [PATCH net-next v1 0/2] add delay abstraction (sleep functions) Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2351ed1-c77c-4a2c-a0ed-d23d9bcc388a@lunn.ch \
--to=andrew@lunn.ch \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dirk.behme@de.bosch.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).