Rust for Linux List
 help / color / mirror / Atom feed
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: "Daniel Almeida" <daniel.almeida@collabora.com>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Joerg Roedel (AMD)" <joro@8bytes.org>,
	"Will Deacon" <will@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Tamir Duberstein" <tamird@kernel.org>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"Onur Özkan" <work@onurozkan.dev>,
	"Abdiel Janulgue" <abdiel.janulgue@gmail.com>,
	iommu@lists.linux.dev, rust-for-linux@vger.kernel.org,
	linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
	"Detlev Casanova" <detlev.casanova@collabora.com>
Subject: Re: [PATCH 0/6] rust: iommu: add a paging domain abstraction
Date: Thu, 19 Nov 2026 10:47:01 -0500	[thread overview]
Message-ID: <da198506005be5c69d61105a5519121fe7bcdd36.camel@collabora.com> (raw)
In-Reply-To: <20261119150857.GK3115493@ziepe.ca>

[-- Attachment #1: Type: text/plain, Size: 2394 bytes --]

Le jeudi 19 novembre 2026 à 11:08 -0400, Jason Gunthorpe a écrit :
> On Thu, Nov 19, 2026 at 09:52:59AM -0500, Nicolas Dufresne wrote:
> > Le jeudi 19 novembre 2026 à 10:31 -0400, Jason Gunthorpe a écrit :
> > > With the additional twist that alot of embedded HW has apparently
> > > choosen to not implement SSID but instead has a pool of SIDs that one
> > > device can use, functionally similar to SSID.
> > > 
> > > We'd need also API support for unbundling the DT iommus=[] SID list
> > > into something that the SIDs can be attached more like a PASID.  That
> > > need, I think, has become clear with all the DT tricks and fake busses
> > > to try to work around this issue. :|
> > 
> > The word "fake" never flies with the DT maintainers. On that subject, I still
> > don't know what you mean with iommus=[].
> 
> When you write your DT you can list all the iommu streams in one
> iommus property. Like this randomly picked out of the DT files:
> 
>         iommus = <&sysmmu_decon0x>, <&sysmmu_decon1x>;
> 
> If you do that then Linux sets the struct device containing it to
> put the same paging domain on all of those iommus.
> 
> It doesn't make any sense to open code this in drivers when you can
> just have the core code do it by writing your DT to match how the
> driver wants to work...

The will be rejected, as it does not map the hardware. If you check multi-core
codecs, each pair of core+iommu are independent from each other, at least enough
that they could be driven by different device drivers. And so they have been
described separately in the DTs. I don't see a fault here.

Its a Linux design decision to manage them as a group, so Linux can schedule
them fairly between processes. It would also conflict with the power management,
which arguably should happen independently. On this last bit, I'm actually a bit
concern of how careless the multi-core patchset are regarding PM of the device
that owns the shared domain, it only works by accident as they schedule core0
first, and other cores are only used if core0 is busy (there is no affinity).

Collecting all cores using the component mechanism, and picking one master and
sharing its domain to all other is pretty small effort, I don't want to go too
crazy here. But I'm open for better DT mapping if something would be accepted by
the DT maintainer.

Nicolas

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-11-19 15:47 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 17:00 [PATCH 0/6] rust: iommu: add a paging domain abstraction Daniel Almeida
2026-11-12 17:00 ` [PATCH 1/6] rust: iommu: move the protection flags to the module root Daniel Almeida
2026-11-12 17:00 ` [PATCH 2/6] rust: scatterlist: make SGTable::as_raw() visible to the crate Daniel Almeida
2026-11-12 17:00 ` [PATCH 3/6] rust: iommu: add the paging domain abstraction Daniel Almeida
2026-11-12 17:00 ` [PATCH 4/6] rust: iommu: add Domain::attach() Daniel Almeida
2026-11-16 21:54   ` Detlev Casanova
2026-11-12 17:00 ` [PATCH 5/6] rust: iommu: add Domain::map() Daniel Almeida
2026-11-12 17:00 ` [PATCH 6/6] rust: iommu: add Domain::with_fault_handler() Daniel Almeida
2026-11-16 19:38 ` [PATCH 0/6] rust: iommu: add a paging domain abstraction Jason Gunthorpe
2026-11-17 20:09   ` Daniel Almeida
2026-11-17 20:20     ` Jason Gunthorpe
2026-11-18 15:25       ` Nicolas Dufresne
2026-11-18 15:55         ` Daniel Almeida
2026-11-18 15:59           ` Daniel Almeida
2026-11-18 16:09         ` Jason Gunthorpe
2026-11-18 19:31           ` Nicolas Dufresne
2026-11-18 19:51             ` Jason Gunthorpe
2026-11-18 21:56               ` Nicolas Dufresne
2026-11-19 12:24           ` Robin Murphy
2026-11-19 13:25             ` Daniel Almeida
2026-11-19 14:31               ` Jason Gunthorpe
2026-11-19 14:52                 ` Nicolas Dufresne
2026-11-19 15:08                   ` Jason Gunthorpe
2026-11-19 15:47                     ` Nicolas Dufresne [this message]
2026-11-19 14:34             ` Jason Gunthorpe
2026-11-19 14:45               ` Robin Murphy
2026-11-18 19:11       ` Daniel Almeida
2026-11-18 19:35         ` Jason Gunthorpe
2026-11-18 19:41           ` Nicolas Dufresne
2026-11-18 21:06             ` Jason Gunthorpe
2026-11-19 13:03               ` Robin Murphy
2026-11-19 14:55                 ` Jason Gunthorpe
2026-11-16 21:54 ` Detlev Casanova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da198506005be5c69d61105a5519121fe7bcdd36.camel@collabora.com \
    --to=nicolas.dufresne@collabora.com \
    --cc=a.hindborg@kernel.org \
    --cc=abdiel.janulgue@gmail.com \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=detlev.casanova@collabora.com \
    --cc=driver-core@lists.linux.dev \
    --cc=gary@garyguo.net \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=will@kernel.org \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox