From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4CC4372ED7; Tue, 21 Apr 2026 18:36:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776796621; cv=none; b=G/DePrgtSEz91Z1b56hcrPo53BvLqDsG5wLkwKmh7ix84kG8gbbHwjySMxIrOU4qgrc3yG9AoFWWRwg4kn8tPo/zwBGfKbGaZ8D76A9XKe8yL9Mf/O3bBQbOSkZd1FfEFLJodlUoKxGszb7F0XG5NXqVas1xkMF3PctCwMIAEns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776796621; c=relaxed/simple; bh=nsAJlvZaoRqjWzwDu8wN2hnZIZWp3b5TT0kiRhM/c04=; h=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=KKbtF5U687O6kLzGlozQYd5bU7f8QM1wjOvH7ANCl3s7+HZ3C0BmGZ/zGD8aDCviFIt1+dxtII/ceBg5HOrjQMt//coKXQFUH5UGbsvmNXk8AmtHFCthTYQvLD4vyngcWuY22RXchRAmpHbAG9snReE9WBDhU73mLbW2gYOxUH0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IL5c/WE8; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IL5c/WE8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776796615; x=1808332615; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=nsAJlvZaoRqjWzwDu8wN2hnZIZWp3b5TT0kiRhM/c04=; b=IL5c/WE8nYs6nGdy3xnSabdk7c0TlFcCw23f2e7/vlnSnXCpZ3V6nrMm g9IFFWoD5e5CyDswb60iIJQOfBCy2YvjTTwK1ydxIvB68OzoI/qnaNQR6 2gScIYmH5xRkycgRC+XB9U4RVuP/XcOriYB7AQTwD7gSh5o52K+20Pmmb fPYk5/wZ/Q/owHV56rgxPj07qD0hGgSPmrwOWlChVonabs2EGnInWxu6n 4FN0IdIw3MVMY6KZwhVD0jWmAX6WGL5cQTZSy6t9QPDxJYaic4i72zQcU C6Qo7jf1/Lq3bufzWs1rB0VF1f4n+CSDpZ5TGdd7hbhwlB4mV5U7ECxpl g==; X-CSE-ConnectionGUID: ufWi67EyRAO2zUL17z8HYQ== X-CSE-MsgGUID: xEerVYcjRpGB+IqSeKQ6jQ== X-IronPort-AV: E=McAfee;i="6800,10657,11763"; a="100400827" X-IronPort-AV: E=Sophos;i="6.23,192,1770624000"; d="scan'208";a="100400827" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2026 11:36:51 -0700 X-CSE-ConnectionGUID: iIGHsrCJT7i31+GiNoXViQ== X-CSE-MsgGUID: cHtQWGqHRK6KgGIy3f/OlA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,192,1770624000"; d="scan'208";a="237094542" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.105]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2026 11:36:44 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Tue, 21 Apr 2026 21:36:41 +0300 (EEST) To: Markus Probst cc: Hans de Goede , Bryan O'Donoghue , Lee Jones , Pavel Machek , Miguel Ojeda , Boqun Feng , Gary Guo , =?ISO-8859-15?Q?Bj=F6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, LKML , rust-for-linux@vger.kernel.org Subject: Re: [PATCH v8 2/2] platform: Add initial synology microp driver In-Reply-To: <1cc39657ac50f3930dfa27de41a1b4605a7167d9.camel@posteo.de> Message-ID: References: <20260420-synology_microp_initial-v8-0-7946a9124491@posteo.de> <20260420-synology_microp_initial-v8-2-7946a9124491@posteo.de> <6104a5fe-a6e3-4c35-ff4f-731d1a5e4acb@linux.intel.com> <1cc39657ac50f3930dfa27de41a1b4605a7167d9.camel@posteo.de> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323328-843182584-1776796601=:972" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-843182584-1776796601=:972 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE On Tue, 21 Apr 2026, Markus Probst wrote: > On Tue, 2026-04-21 at 21:10 +0300, Ilpo J=C3=A4rvinen wrote: > > On Tue, 21 Apr 2026, Markus Probst wrote: > >=20 > > > On Tue, 2026-04-21 at 14:59 +0300, Ilpo J=C3=A4rvinen wrote: > > > > On Mon, 20 Apr 2026, Markus Probst wrote: > > > >=20 > > > > > Add a initial synology microp driver, written in Rust. > > > > > The driver targets a microcontroller found in Synology NAS device= s. It > > > > > currently only supports controlling of the power led, status led,= alert > > > > > led and usb led. Other components such as fan control or handling > > > > > on-device buttons will be added once the required rust abstractio= ns are > > > > > there. > > > > >=20 > > > > > This driver can be used both on arm and x86, thus it goes into th= e root > > > > > directory of drivers/platform. > > > > >=20 > > > > > Tested successfully on a Synology DS923+. > > > > >=20 > > > > > Signed-off-by: Markus Probst > > > > > --- > > > > > MAINTAINERS | 6 + > > > > > drivers/platform/Kconfig | 2 + > > > > > drivers/platform/Makefile | 1 + > > > > > drivers/platform/synology_microp/Kconfig | 13 + > > > > > drivers/platform/synology_microp/Makefile | 3 + > > > > > drivers/platform/synology_microp/TODO | 7 + > > > > > drivers/platform/synology_microp/command.rs | 54 ++++ > > > > > drivers/platform/synology_microp/led.rs | 281 +++++++= ++++++++++++++ > > > > > drivers/platform/synology_microp/model.rs | 49 ++++ > > > > > .../platform/synology_microp/synology_microp.rs | 110 +++++++= + > > > > > 10 files changed, 526 insertions(+) > > > > >=20 > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > > index c1c686846cdd..49f08290eed0 100644 > > > > > --- a/MAINTAINERS > > > > > +++ b/MAINTAINERS > > > > > @@ -25555,6 +25555,12 @@ F:=09drivers/dma-buf/sync_* > > > > > F:=09include/linux/sync_file.h > > > > > F:=09include/uapi/linux/sync_file.h > > > > > =20 > > > > > +SYNOLOGY MICROP DRIVER > > > > > +M:=09Markus Probst > > > >=20 > > > > You should probably add: > > > >=20 > > > > L:=09platform-driver-x86@vger.kernel.org > > > >=20 > > > > Through which tree the patches to this driver are generally expecte= d to be=20 > > > > picked up? > > >=20 > > > I suppose platform-drivers-x86. > >=20 > > Okay (with the platform drivers maintainer hat on). Just don't expect m= e=20 > > to have deep Rust knowledge. > >=20 > > > The driver itself can be used both on > > > x86 and arm64. Although I also have seen Synology devices with PowerP= C > > > (no device with PowerPC is supported in the driver yet).=20 > >=20 > > In practice platform drivers scope has already expanded beyond x86 so t= he=20 > > platform-drivers-x86 list naming is just a historic artifact. > > Does this also include the drivers/platform/x86 folder? >=20 > Because of the multiple architectures, I put it into the root, i. e. > drivers/platform/synology_microp/ >=20 > Is this fine or should I move it into drivers/platform/x86 ? No. The current place you have it is fine with me. There's actually a small number of files that have migrated away from x86/= =20 when they've become useful for non-x86 systems. > > > > > +S:=09Maintained > > > > > +F:=09Documentation/devicetree/bindings/embedded-controller/synol= ogy,ds1825p-microp.yaml > > > > > +F:=09drivers/platform/synology_microp/ > > > > > + > > > > > SYNOPSYS ARC ARCHITECTURE > > > > > M:=09Vineet Gupta > > > > > L:=09linux-snps-arc@lists.infradead.org --=20 i. --8323328-843182584-1776796601=:972--