Re: [PATCH RFC] nova-core: mm: Add initial structures for page table management

[Joel Fernandes <joelagnelf@nvidia.com>]

On 10/14/2025 10:08 PM, John Hubbard wrote:
> On 10/6/25 2:09 PM, Joel Fernandes wrote:
>> Add initial structures and helpers for page table management. Will
>> expand and build on this in later patches. Uses bitstruct for clean
>> code.
>>
>> Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
>> ---
>> Rebased on rust-drm-next + bitfield patches [1].
>>
>> [1] https://lore.kernel.org/all/20251003154748.1687160-1-joelagnelf@nvidia.com/
>>
>>  drivers/gpu/nova-core/falcon/gsp.rs |   2 +-
>>  drivers/gpu/nova-core/mm/mod.rs     |   3 +
>>  drivers/gpu/nova-core/mm/types.rs   | 382 ++++++++++++++++++++++++++++
>>  drivers/gpu/nova-core/nova_core.rs  |   1 +
>>  4 files changed, 387 insertions(+), 1 deletion(-)
>>  create mode 100644 drivers/gpu/nova-core/mm/mod.rs
>>  create mode 100644 drivers/gpu/nova-core/mm/types.rs
>>
>
> Hi Joel,
>
> This will be easier to provide a meaningful review for, once there are
> some callers to look at. Structures alone are very difficult to review,
> in the absence of behaviors (callers).

John, true. For next posting of this particular patch, I will post the page
table walker patches as well. There are still several prerequisites that PT
walking needs though (PRAMIN, bitfield, buddy allocator), which I will post in
advance before that. This patch was mainly to show how bitfield (formerly
bitstruct) will be used.

Thanks.