From: John Hubbard <jhubbard@nvidia.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Joel Fernandes <joelagnelf@nvidia.com>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
Danilo Krummrich <dakr@kernel.org>,
Dave Airlie <airlied@gmail.com>,
Alexandre Courbot <acourbot@nvidia.com>,
Alistair Popple <apopple@nvidia.com>,
Miguel Ojeda <ojeda@kernel.org>,
Alex Gaynor <alex.gaynor@gmail.com>,
Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
bjorn3_gh@protonmail.com, Benno Lossin <lossin@kernel.org>,
Andreas Hindborg <a.hindborg@kernel.org>,
Alice Ryhl <aliceryhl@google.com>,
Trevor Gross <tmgross@umich.edu>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Timur Tabi <ttabi@nvidia.com>,
Joel Fernandes <joel@joelfernandes.org>,
Lyude Paul <elle@weathered-steel.dev>,
Daniel Almeida <daniel.almeida@collabora.com>,
Andrea Righi <arighi@nvidia.com>,
Philipp Stanner <phasta@kernel.org>
Subject: Re: [PATCH v3] rust: clist: Add support to interface with C linked lists
Date: Mon, 1 Dec 2025 14:54:43 -0800 [thread overview]
Message-ID: <ddc0c618-095d-417d-a52a-4294d692022d@nvidia.com> (raw)
In-Reply-To: <CANiq72nhkOMGGb7evGn441J-8nX=jSWeDTASn0gj+TCa692B+A@mail.gmail.com>
On 12/1/25 2:50 PM, Miguel Ojeda wrote:
> On Mon, Dec 1, 2025 at 11:18 PM John Hubbard <jhubbard@nvidia.com> wrote:
>>
>> But for API developers, the problem with doctests is that no one has ever
>> actually *run* the code. It's just a build test. And so critical bugs, such
>> as the kernel crash/hang below, are missed.
>
> No, it is not just a build test. Doctests are actually transformed
> into KUnit tests automatically, and `assert!`s inside them actually
> report back to KUnit too.
I somehow failed to really internalize the connection to KUnit (or
to even remember it). Joel pointed it out too.
>
> It was a major hack to implement, but I am proud of that one :)
>
> That also allows us to build them with Clippy, to e.g. get the safety
> comments right, which is something normal Rust doesn't support yet.
>
> We are actually getting a feature from upstream Rust to support it all
> in a stable and nice way!
>
thanks,
--
John Hubbard
next prev parent reply other threads:[~2025-12-01 22:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 21:30 [PATCH v3] rust: clist: Add support to interface with C linked lists Joel Fernandes
2025-12-01 0:34 ` John Hubbard
2025-12-01 20:32 ` Joel Fernandes
2025-12-01 20:57 ` Joel Fernandes
2025-12-01 22:17 ` John Hubbard
2025-12-01 22:43 ` Joel Fernandes
2025-12-01 22:52 ` John Hubbard
2025-12-01 23:09 ` Joel Fernandes
2025-12-01 23:15 ` John Hubbard
2025-12-01 23:21 ` Joel Fernandes
2025-12-01 22:58 ` Miguel Ojeda
2025-12-01 22:50 ` Miguel Ojeda
2025-12-01 22:54 ` John Hubbard [this message]
2025-12-01 15:25 ` Alice Ryhl
2025-12-01 21:35 ` Joel Fernandes
2025-12-01 16:51 ` Daniel Almeida
2025-12-01 19:35 ` John Hubbard
2025-12-01 20:06 ` Joel Fernandes
2025-12-01 23:01 ` Daniel Almeida
2025-12-01 23:23 ` Joel Fernandes
2025-12-01 22:54 ` Daniel Almeida
2025-12-01 22:58 ` Miguel Ojeda
2025-12-01 21:46 ` Joel Fernandes
2025-12-03 13:06 ` Alexandre Courbot
2025-12-03 15:08 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddc0c618-095d-417d-a52a-4294d692022d@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=arighi@nvidia.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=elle@weathered-steel.dev \
--cc=gary@garyguo.net \
--cc=joel@joelfernandes.org \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=phasta@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).