From: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
To: "Benno Lossin" <benno.lossin@proton.me>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>, "Tejun Heo" <tj@kernel.org>
Cc: Wedson Almeida Filho <walmeida@microsoft.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] rust: workqueue: add `#[pin_data]` to `Work`
Date: Mon, 18 Dec 2023 17:49:45 -0300 [thread overview]
Message-ID: <e1bebeca-858c-4fd5-addd-be55421935ee@gmail.com> (raw)
In-Reply-To: <cf36ec44-466a-4c00-afd6-8387dd1ed1f2@proton.me>
On 12/18/23 14:47, Benno Lossin wrote:
> On 12/14/23 04:13, Martin Rodriguez Reboredo wrote:
>> On 12/13/23 19:09, Benno Lossin wrote:
>>> The previous two patches made it possible to add `#[pin_data]` on
>>> structs with default generic parameter values.
>>> This patch makes `Work` use `#[pin_data]` and removes an invocation of
>>> `pin_init_from_closure`. This function is intended as a low level manual
>>> escape hatch, so it is better to rely on the safe `pin_init!` macro.
>>>
>>> Signed-off-by: Benno Lossin <benno.lossin@proton.me>
>>> ---
>>> [...]
>
> Did you mean to add your reviewed by? Because I received only
> the quote.
>
Thunderbird is a disaster for plain-text emails.
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
next prev parent reply other threads:[~2023-12-18 20:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 22:08 [PATCH v2 1/3] rust: macros: add `decl_generics` to `parse_generics()` Benno Lossin
2023-12-13 22:08 ` [PATCH v2 2/3] rust: macros: allow generic parameter default values in `#[pin_data]` Benno Lossin
2023-12-14 3:11 ` Martin Rodriguez Reboredo
2023-12-23 14:42 ` Gary Guo
2024-01-04 15:18 ` Alice Ryhl
2023-12-13 22:09 ` [PATCH v2 3/3] rust: workqueue: add `#[pin_data]` to `Work` Benno Lossin
2023-12-14 3:13 ` Martin Rodriguez Reboredo
2023-12-18 17:47 ` Benno Lossin
2023-12-18 20:49 ` Martin Rodriguez Reboredo [this message]
2023-12-23 14:43 ` Gary Guo
2024-01-04 15:19 ` Alice Ryhl
2023-12-14 2:57 ` [PATCH v2 1/3] rust: macros: add `decl_generics` to `parse_generics()` Martin Rodriguez Reboredo
2023-12-23 14:41 ` Gary Guo
2024-01-04 15:17 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1bebeca-858c-4fd5-addd-be55421935ee@gmail.com \
--to=yakoyoku@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tj@kernel.org \
--cc=walmeida@microsoft.com \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).