From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 632D6311C22; Wed, 22 Oct 2025 09:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761124210; cv=none; b=THyffi1ISoAunnnccHlq49HR19PPUPgmRF9IE3kQMDBH3xnXcOftncIttOk3H9sbq+0wo7cx1/DWG3wA7yUOgd6OIrMXnDaBU/FJZmMe4Gjz/eqZM/TO+BlbVMslKgHPS3jhnVCrXB7+wL5R6AhvDZnd5sCVE5bTLg46B6BoIeU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761124210; c=relaxed/simple; bh=XBwcSKAt7pmMIAlH4P9UOJg9seAvmBafg4+HNgtE9uA=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=cAcTP/bduSSxuc+ZmOeLiBUO6YgSljVMp00rsc0qiTuce66D4rOFiB7EBOqVCEP2gSWsSCS8EM6Lrkp9UgQclevzs9sUGaGnGSXv1bg48A8dNO7LDBS9Q+s1aHU7uhbE2rSYGLQb67joPInKWIPJUCm962LvSsWCvEy9UQcSQ7o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tJNmji4J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tJNmji4J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B7B0C4CEE7; Wed, 22 Oct 2025 09:10:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761124207; bh=XBwcSKAt7pmMIAlH4P9UOJg9seAvmBafg4+HNgtE9uA=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=tJNmji4J3S+RsYSsWOyEd44dMG2opN4PZ6QTDS9iGf412Ikx4VoOdlQurU1FUDAla oObwS5j8v51ltDfCZvv/jL7xqCte/Nqfirbd4qy9Pq5kOHd3epBvjxemzr+3QnpBWl te9XFfCxVnhEQynEi0Cm5sbcS9qCXXvB8S7cvoAoyJbbCE8ze84XPU7NtBRZuuVqmr A4BPIEzzCs4jMA5H5br2hzjYyBIHcLMc5zA0ehjOcFVk09pyp6Yzr/R4ika9b48lec nce7YuPUIW5+Zwz267GNLK3dndCsemwbTyyFy7ViVgq+egqXzhn/Itwhfy+pW6MBOd eNWFNYDAbniVQ== Message-ID: Date: Wed, 22 Oct 2025 11:10:02 +0200 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rust: debugfs: Implement Reader for Mutex only when T is Unpin From: Danilo Krummrich To: Boqun Feng Cc: Peter Zijlstra , Daniel Almeida , Matthew Maurer , Stephen Rothwell , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, Miguel Ojeda , Alex Gaynor , Gary Guo , lossin@kernel.org, Andreas Hindborg , Alice Ryhl , Trevor Gross , rust-for-linux@vger.kernel.org References: <20251022034237.70431-1-boqun.feng@gmail.com> <4b556c24-cd4c-4c1a-a757-5df3a6782e11@kernel.org> Content-Language: en-US In-Reply-To: <4b556c24-cd4c-4c1a-a757-5df3a6782e11@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/22/25 11:07 AM, Danilo Krummrich wrote: > On 10/22/25 5:42 AM, Boqun Feng wrote: >> Since we are going to make `Mutex` structurally pin the data (i.e. >> `T`), therefore `.lock()` function only returns a `Guard` that can >> dereference a mutable reference to `T` if only `T` is `Unpin`, therefore >> restrict the impl `Reader` block of `Mutex` to that. >> >> Signed-off-by: Boqun Feng > > I assume this can go through the driver-core tree, since it's only about a > conflict in linux-next? Sorry, I confused this, obviously your tree is broken without this change, please feel free to take it. Acked-by: Danilo Krummrich