From: Asuna <spriteovo@gmail.com>
To: Conor Dooley <conor@kernel.org>
Cc: "Jason Montleon" <jmontleo@redhat.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: RISC-V: Re-enable GCC+Rust builds
Date: Wed, 3 Sep 2025 08:59:29 +0800 [thread overview]
Message-ID: <e48699fb-287d-42a9-ba6c-5edad86965f4@gmail.com> (raw)
In-Reply-To: <20250901-unseemly-blimp-a74e3c77e780@spud>
> That particular one might be a problem not because of -mstack-protector-guard itself, but rather three options get added at once:
> $(eval KBUILD_CFLAGS += -mstack-protector-guard=tls \
> -mstack-protector-guard-reg=tp \
> -mstack-protector-guard-offset=$(shell \
> awk '{if ($$2 == "TSK_STACK_CANARY") print $$3;}' \
> $(objtree)/include/generated/asm-offsets.h))
> and the other ones might be responsible for the error.
I still don't understand the problem here. `bindgen_skip_c_flags` in
`rust/Makefile` contains a pattern `-mstack-protector-guard%`, the % at
the end enables it to match all those 3 options at the same time, and
`filter-out` function removes them before passing to Rust bindgen's
libclang. Am I missing something here?
> Similarly, something like -Wno-unterminated-string-initialization could cause a problem if gcc supports it but not libclang.
Yes. However, this option is only about warnings, not architecture
related and does not affect the generated results, so simply adding it
into `bindgen_skip_c_flags` patterns should be enough, I think.
> I think you're mostly better off catching that sort of thing in Kconfig, where possible and just make incompatible mixes invalid. What's actually incompatible is likely going to depend heavily on what options are enabled.
Sounds better, I'll go down that path.
next prev parent reply other threads:[~2025-09-03 0:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 5:00 RISC-V: Re-enable GCC+Rust builds Asuna Yang
2025-08-30 18:17 ` Conor Dooley
2025-09-01 14:08 ` Conor Dooley
2025-09-01 17:19 ` Asuna
2025-09-01 18:04 ` Conor Dooley
2025-09-03 0:59 ` Asuna [this message]
2025-09-04 11:28 ` Conor Dooley
2025-09-03 18:52 ` Asuna
[not found] ` <20250903190806.2604757-1-SpriteOvO@gmail.com>
2025-09-03 23:24 ` [PATCH 1/2] rust: get the version of libclang used by bindgen in a separate script Miguel Ojeda
2025-09-04 23:15 ` Asuna
[not found] ` <20250903190806.2604757-2-SpriteOvO@gmail.com>
2025-09-03 23:27 ` [PATCH 2/2] RISC-V: re-enable gcc + rust builds Miguel Ojeda
2025-09-04 23:17 ` Asuna
[not found] ` <20250904-sterilize-swagger-c7999b124e83@spud>
[not found] ` <f7434b76-49d0-4ef3-8c77-c1642dc211cd@gmail.com>
2025-09-04 23:07 ` Asuna
2025-09-05 15:25 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e48699fb-287d-42a9-ba6c-5edad86965f4@gmail.com \
--to=spriteovo@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=alex@ghiti.fr \
--cc=aliceryhl@google.com \
--cc=aou@eecs.berkeley.edu \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=conor@kernel.org \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=jmontleo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).