From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ED0047ECF2 for ; Thu, 20 Aug 2026 17:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787248186; cv=none; b=QbZDK1yVmq1oVGLvPcWV8mhJoGvZjzw24JaFMylL1g+WkdB4anRgTwIfCgKIrywpUcl69nLp7hOlYrk8vq0r2F50dsuNHQSqHTtaKFszOujRVCBJRuM5yzsD9Cp676+hKkGFkAhjRPop90hNbVoCCe+zimHWDgs/0UtMWa65+tU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787248186; c=relaxed/simple; bh=sJiCG9GMt+8ts/wSdpjtZKthk4D4iZFfORrDzQ4jEXE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rhFOv4z+x/k41/wurk6u5933Xmz1Nhx2AFowLx4lM4QgPBJV2ACe7U7C7s0df5T2saVfrPij+jInmkxlyS66KehiohsspbiPizKXRkMY8HvxEvm/6OzTAgzG9zfOAvJU3st93PF4ZPVH8uHcfaFfJIAucKmhggqFJXOUn6yK6R8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Qa2N9n89; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Qa2N9n89" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787248183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6+qiRA0Rr68w6luARuut3h/5z5IL9+5qPOnuZ1Bth1E=; b=Qa2N9n89qzL7LHK1UmEu5L0TouYM7HY9V/YhR2cDJC5yWPXSFcAGiF5BRPJH43wThkwFq1 uCRaQR4D1FX0ZmaKzUWqT/aSevBu8DyW9s3fm3pUm5yMHM0XUTjHQxpE3e/o7UhTDAMNs/ 7+pX/5Pd+yBVaAEerh/G077lLZWBblg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-401-ruODuvWuPw2OM6j8Om2lKA-1; Thu, 20 Aug 2026 13:49:41 -0400 X-MC-Unique: ruODuvWuPw2OM6j8Om2lKA-1 X-Mimecast-MFC-AGG-ID: ruODuvWuPw2OM6j8Om2lKA_1787248181 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-481558a96e2so90019f8f.3 for ; Thu, 20 Aug 2026 10:49:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787248180; x=1787852980; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6+qiRA0Rr68w6luARuut3h/5z5IL9+5qPOnuZ1Bth1E=; b=JzRcUm6PXriN6vqoFel1Ny49m1PPH28TzP+tqNMPsue9GqloK30plpKeovRGyMdGPz aJcchZHE2DwGbed3+g3Ayo0cRNGvedwMpFzz+49m2p31zJBDNCtPHR9d1Ck+D4sUom1P 5SrNFxIYSgHF1dnfHTZT7jmy2B9E6o3o0lO5dhJyjq+g2NZp/Ni4hZSJByQbJgK1u9El dLj7obLCltOem5QI1sZrY8uWYndLiF3Ui86ELX9aWlaZYPd9sirD8Nt++605nPKFh29F dypi51+jHUApr/tibRoSkwegnLkwRs0n7Ooa469HWhWdYuNqBj/xA1qFZ0E7GcWzQe1d pHNg== X-Forwarded-Encrypted: i=1; AHgh+RqtnXjkcUPchsH5jba5uAyCou5+QIeJ0jdeyjwsCL7TdoNSaGGg/jQv9/iKCa8w1mUpvdk9UpbtJYWyJvE7sA==@vger.kernel.org X-Gm-Message-State: AFuF++lI195VMbLZucd1/a/7k607khFaVeV4DkMTeKuhgGOxi2vvGs5M zmMBe63gWv4jAsDt8rSHnHJMflwhX29365Nr/hMXT+UmuvoJy84Ovd/JCET9428kREJNVyhQBVM +rQDCfqFIQbusYAWG3QxSoZlIcrLkyZD4H4RreR737t2qir/hJVXmV/3HdJrC6j9kNK5a X-Gm-Gg: AR+sD132rNVmqT/gVNrJw5ndjL8mxN4sXrRqM8h3/mXi8rmD7/S5mwion4bTnpCJYB7 JI71adZ6f/JE64h7uytm781L3ZLLhBUAnkN4+Z1WI0w42NVUPL225G9+TyWi7ervkS2nYBcxkxM TWgEHrPsiIvntbWHr7UHnlqbbyf6/OEp2GHCvSB8uQJKsABp9E186ikfw/ocD+DjgEJbeY1Ld6o kLtCXQUI8KEc2atmtkhpmfGQA6MwHBnNGLdHK/fRkX1Naiq0hF8cLhFKT7/VXb9EFY+h+4czEUs kI4IEeGEVTCTqJKVjQvRE6nivO2yTOeunE5++f4AdirwCrJN7w2B+3/NdnMZqi9tVQ3jxlFhAIU gOj9fowKG0hkxhlTAcu9IUN+xOYkgR1dUL/09BSDAlz44Ag== X-Received: by 2002:a05:6000:184e:b0:47f:f339:556c with SMTP id ffacd0b85a97d-482c0b4a40dmr705161f8f.2.1787248180694; Thu, 20 Aug 2026 10:49:40 -0700 (PDT) X-Received: by 2002:a05:6000:184e:b0:47f:f339:556c with SMTP id ffacd0b85a97d-482c0b4a40dmr705081f8f.2.1787248180291; Thu, 20 Aug 2026 10:49:40 -0700 (PDT) Received: from ?IPV6:2a01:e0a:11aa:87f0:935:4f8e:b423:64eb? ([2a01:e0a:11aa:87f0:935:4f8e:b423:64eb]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b145d31bsm13853815f8f.16.2026.08.20.10.49.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 10:49:39 -0700 (PDT) Message-ID: Date: Thu, 20 Aug 2026 19:49:36 +0200 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/12] drm/panic: Split into core and helpers To: Thomas Zimmermann , javierm@redhat.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, rust-for-linux@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, nouveau@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, virtualization@lists.linux.dev, sashiko-reviews@lists.linux.dev References: <20260818125012.468092-1-tzimmermann@suse.de> From: Jocelyn Falempe In-Reply-To: <20260818125012.468092-1-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4HNVhfHmwTPuhs0RudFkZjH0B9WDysRAdOMyEDFey8M_1787248181 X-Mimecast-Originator: redhat.com Content-Language: en-US, fr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/08/2026 14:27, Thomas Zimmermann wrote: > Split DRM's current panic handling into a core and a helper module. > The core is still part of DRM's core library. The panic helpers are > part of DRM's KMS helper module (for now). > > The motivation behind this series is to get panic handling's drawing > code out of the DRM core. At some point it should share a single > module with DRM's other drawing and format conversion. > > With the series applied, panic hanlding follows DRM's established > design pattern of having a DRM core interface with an dedicated > implementation in each driver. Drivers share common code in helper > modules. For panic handling, the DRM core still contains the panic > entry points, the parameters and the debugfs interface. All drawing > is now located in the panic helpers. > > Patches 1 to 4 improve several issues in the current panic code. It > makes sense to fix them before moving the core around. > > Patches 5 to 8 put handling of all panic state and locking into a > single place, drm_panic_display_panic_screen(). It is maintained by > panic handling's DRM core code. This also enables the test cases to > work more independently from the kernel's configuration. > > Patches 9 to 11 split the panic-handling code into the core and panic > helpers. The former maintain all state, locking and public interfaces. > The latter handles drawing and details of the involved framebuffers. > > DRM devices that offer panic handling provide a single callback, struct > drm_plane_funcs.display_panic_screen. A new initializer macro makes it > point to the existing panic-drawing implementation. Hence there's no > change in features or functionality. If panic handling is configured > off, it all clears out to NULL. > > Patch 12 reworks the test cases slighly, so that they can be build as > a separate module. Do 'modprobe drm_panic_helper_test' to run them. > > Tested under bochs with debugfs and test cases. Overall the series looks good to me, and I like the split between the helper and the core. I would just drop the first two patches, as I don't see much difference between static allocation or kmalloc() at init, and I think that memset() the buffers to 0 is not useful in this case. Best regards, -- Jocelyn > > Future directions: > > - Panic handling shares some drawing code with format conversion and > clients. There's even more drawing code in vkms. Later series' can > attempt to unify and harmonize all these implementations in a single > draw module. > > - The drawing helper drm_plane_helper_display_panic_screen() still > implements various access schemes (map, set_pixel, memcpy) in a single > function. It could be split up into specifialized helpers. > > - If we ever need a driver-specific helper, it is now possible to > implement a custom version of display_panic_screen. > > Thomas Zimmermann (12): > drm/panic: Allocate QR-code buffers statically > drm/panic: Make allocation of zlib workspace more robust > drm/panic: Return -EINVAL if font is not available > drm/panic: Return errno codes if panic output fails > drm/panic: Pass colors to draw_panic_dispatch() > drm/panic: Pass global module parameters to drm_panic_dispatch() > drm/panic: Retry in dispatch function if panic output fails > drm/panic: Split draw_panic_plane() > drm/panic: Display panic screen via per-plane callback > drm/panic: Internalize panic locking in DRM core and helpers > drm/panic: Move panic display code into helper library > drm/panic: Compile KUnit tests as module > > Documentation/gpu/drm-kms-helpers.rst | 11 +- > Documentation/gpu/drm-kms.rst | 3 + > MAINTAINERS | 11 +- > drivers/gpu/drm/Kconfig | 5 + > drivers/gpu/drm/Kconfig.debug | 1 + > drivers/gpu/drm/Makefile | 3 +- > .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 2 + > drivers/gpu/drm/ast/ast_mode.c | 2 + > drivers/gpu/drm/drm_atomic_helper.c | 2 +- > drivers/gpu/drm/drm_crtc_internal.h | 2 - > drivers/gpu/drm/drm_drv.c | 3 +- > drivers/gpu/drm/drm_kms_helper_common.c | 14 + > drivers/gpu/drm/drm_panic.c | 914 +---------------- > drivers/gpu/drm/drm_panic_helper.c | 915 ++++++++++++++++++ > ...drm_panic_qr.rs => drm_panic_helper_qr.rs} | 4 +- > drivers/gpu/drm/drm_panic_internal.h | 59 ++ > drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 2 + > drivers/gpu/drm/i915/display/i9xx_plane.c | 3 + > .../drm/i915/display/skl_universal_plane.c | 4 + > drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c | 2 + > drivers/gpu/drm/mgag200/mgag200_drv.h | 4 +- > drivers/gpu/drm/nouveau/dispnv50/wndw.c | 2 + > .../gpu/drm/renesas/rcar-du/rcar_du_plane.c | 2 + > .../drm/renesas/shmobile/shmob_drm_plane.c | 2 + > drivers/gpu/drm/sysfb/drm_sysfb_helper.h | 4 +- > drivers/gpu/drm/sysfb/vesadrm.c | 1 + > drivers/gpu/drm/tests/Makefile | 1 + > ...m_panic_test.c => drm_panic_helper_test.c} | 65 +- > drivers/gpu/drm/tidss/tidss_plane.c | 2 + > drivers/gpu/drm/tiny/bochs.c | 4 +- > drivers/gpu/drm/virtio/virtgpu_plane.c | 2 + > include/drm/drm_mode_config.h | 4 +- > include/drm/drm_modeset_helper_vtables.h | 11 +- > include/drm/drm_panic.h | 117 +-- > include/drm/drm_panic_helper.h | 40 + > include/drm/drm_plane.h | 57 ++ > rust/bindings/bindings_helper.h | 4 +- > 37 files changed, 1253 insertions(+), 1031 deletions(-) > create mode 100644 drivers/gpu/drm/drm_panic_helper.c > rename drivers/gpu/drm/{drm_panic_qr.rs => drm_panic_helper_qr.rs} (99%) > create mode 100644 drivers/gpu/drm/drm_panic_internal.h > rename drivers/gpu/drm/tests/{drm_panic_test.c => drm_panic_helper_test.c} (80%) > create mode 100644 include/drm/drm_panic_helper.h > > > base-commit: dc462ab791b686c48545c160ecc81be64f77a846 > prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 > prerequisite-patch-id: a5a973e527c88a5b47053d7a72aefe0b550197cb > prerequisite-patch-id: b9adc9622920a3e70168e672c2c92795b3e3a106 > prerequisite-patch-id: 5030de433a01c2e99056cadb676a8e2ba35f055a