Re: [PATCH 11/11] gpu: nova-core: add PIO support for loading firmware images

[Timur Tabi <ttabi@nvidia.com>]

On Mon, 2025-11-17 at 18:34 -0500, Joel Fernandes wrote:
> > +    /// See nvkm_falcon_pio_wr - takes a byte array instead of a FalconFirmware
> > +    fn pio_wr_bytes(
> > +        &self,
> > +        bar: &Bar0,
> > +        source: *const u8,
> > +        mem_base: u16,
> > +        length: usize,
> > +        target_mem: FalconMem,
> > +        port: u8,
> > +        tag: u16
> 
> Please don't use pointers for source, use slices instead, then you don't need
> to assume length is multiple of 4, you can just return error if it is.

I changed this to use a slice instead of pointer/length, and the code is much better, thanks!