next-20250915: error[E0425]: cannot find function `atomic_read_acquire` in crate `bindings`

next-20250915: error[E0425]: cannot find function `atomic_read_acquire` in crate `bindings`

[Naresh Kamboju]

The following build warnings / errors noticed on the arm arm64 and x86_64
with rust config build on the Linux next-20250915 tag.

First seen on next-20250915
Good: next-20250912
Bad: next-20250915

Regression Analysis:
- New regression? yes
- Reproducibility? yes

* arm, build
  - rustclang-lkftconfig-kselftest
  - rustgcc-lkftconfig-kselftest

* arm64, build
  - rustclang-lkftconfig-kselftest
  - rustgcc-lkftconfig-kselftest

* x86_64, build
  - rustgcc-lkftconfig-kselftest
  - rustclang-nightly-lkftconfig-kselftest

Build regression: next-20250915: error[E0425]: cannot find function
`atomic_read_acquire` in crate `bindings`

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

## Build log
error[E0425]: cannot find function `atomic_read_acquire` in crate `bindings`
   --> rust/kernel/sync/atomic/internal.rs:124:37
    |
124 |                   $unsafe { bindings::[< $ctype _ $func >]($($c_arg,)*) }
    |                                       ^^^^^^^^^^^^^^^^^^^^ not
found in `bindings`
...
201 | / declare_and_impl_atomic_methods!(
202 | |     /// Basic atomic operations
203 | |     pub trait AtomicBasicOps {
204 | |         /// Atomic read (load).
...   |
216 | | );
    | |_- in this macro invocation
    |
    = note: this error originates in the macro `impl_atomic_method`
which comes from the expansion of the macro
`declare_and_impl_atomic_methods` (in Nightly builds, run with -Z
macro-backtrace for more info)
error: aborting due to 34 previous errors

For more information about this error, try `rustc --explain E0425`.
make[3]: *** [rust/Makefile:553: rust/kernel.o] Error 1


## Source
* Kernel version: 6.17.0-rc6
* Git tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next.git
* Git describe: 6.17.0-rc6-next-20250915
* Git commit: c3067c2c38316c3ef013636c93daa285ee6aaa2e
* Architectures: arm, arm64 and x86_64
* Toolchains: gcc (Debian 15.2.0-3) 15.2.0
* Kconfigs: rust config

## Build
* Build log: https://qa-reports.linaro.org/api/testruns/29894207/log_file/
* Build details:
https://regressions.linaro.org/lkft/linux-next-master/next-20250915/build/rustgcc-lkftconfig-kselftest/
* Build plan: https://tuxapi.tuxsuite.com/v1/groups/linaro/projects/lkft/builds/32l4UDzp0FMtS73JeG3kWpcoQrm
* Build link: https://storage.tuxsuite.com/public/linaro/lkft/builds/32l4UDzp0FMtS73JeG3kWpcoQrm/
* Kernel config:
https://storage.tuxsuite.com/public/linaro/lkft/builds/32l4UDzp0FMtS73JeG3kWpcoQrm/config

--
Linaro LKFT

Re: next-20250915: error[E0425]: cannot find function `atomic_read_acquire` in crate `bindings`

[Naresh Kamboju]

On Tue, 16 Sept 2025 at 11:17, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> The following build warnings / errors noticed on the arm arm64 and x86_64
> with rust config build on the Linux next-20250915 tag.
>
> First seen on next-20250915
> Good: next-20250912
> Bad: next-20250915
>
> Regression Analysis:
> - New regression? yes
> - Reproducibility? yes
>
> * arm, build
>   - rustclang-lkftconfig-kselftest
>   - rustgcc-lkftconfig-kselftest
>
> * arm64, build
>   - rustclang-lkftconfig-kselftest
>   - rustgcc-lkftconfig-kselftest
>
> * x86_64, build
>   - rustgcc-lkftconfig-kselftest
>   - rustclang-nightly-lkftconfig-kselftest
>
> Build regression: next-20250915: error[E0425]: cannot find function
> `atomic_read_acquire` in crate `bindings`

Anders bisected this build regressions and found,

# first bad commit:
 [eb57133305f61b612252382d0c1478bba7f57b67]
 rust: sync: Add basic atomic operation mapping framework

>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> ## Build log
> error[E0425]: cannot find function `atomic_read_acquire` in crate `bindings`
>    --> rust/kernel/sync/atomic/internal.rs:124:37
>     |
> 124 |                   $unsafe { bindings::[< $ctype _ $func >]($($c_arg,)*) }
>     |                                       ^^^^^^^^^^^^^^^^^^^^ not
> found in `bindings`
> ...
> 201 | / declare_and_impl_atomic_methods!(
> 202 | |     /// Basic atomic operations
> 203 | |     pub trait AtomicBasicOps {
> 204 | |         /// Atomic read (load).
> ...   |
> 216 | | );
>     | |_- in this macro invocation
>     |
>     = note: this error originates in the macro `impl_atomic_method`
> which comes from the expansion of the macro
> `declare_and_impl_atomic_methods` (in Nightly builds, run with -Z
> macro-backtrace for more info)
> error: aborting due to 34 previous errors
>
> For more information about this error, try `rustc --explain E0425`.
> make[3]: *** [rust/Makefile:553: rust/kernel.o] Error 1
>
>
> ## Source
> * Kernel version: 6.17.0-rc6
> * Git tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next.git
> * Git describe: 6.17.0-rc6-next-20250915
> * Git commit: c3067c2c38316c3ef013636c93daa285ee6aaa2e
> * Architectures: arm, arm64 and x86_64
> * Toolchains: gcc (Debian 15.2.0-3) 15.2.0
> * Kconfigs: rust config
>
> ## Build
> * Build log: https://qa-reports.linaro.org/api/testruns/29894207/log_file/
> * Build details:
> https://regressions.linaro.org/lkft/linux-next-master/next-20250915/build/rustgcc-lkftconfig-kselftest/
> * Build plan: https://tuxapi.tuxsuite.com/v1/groups/linaro/projects/lkft/builds/32l4UDzp0FMtS73JeG3kWpcoQrm
> * Build link: https://storage.tuxsuite.com/public/linaro/lkft/builds/32l4UDzp0FMtS73JeG3kWpcoQrm/
> * Kernel config:
> https://storage.tuxsuite.com/public/linaro/lkft/builds/32l4UDzp0FMtS73JeG3kWpcoQrm/config
>
> --
> Linaro LKFT

- Naresh

Re: next-20250915: error[E0425]: cannot find function `atomic_read_acquire` in crate `bindings`

[Miguel Ojeda]

On Tue, Sep 16, 2025 at 6:26 PM Naresh Kamboju
<naresh.kamboju@linaro.org> wrote:
>
> Anders bisected this build regressions and found,
>
> # first bad commit:
>  [eb57133305f61b612252382d0c1478bba7f57b67]
>  rust: sync: Add basic atomic operation mapping framework

That is very useful, thanks.

We (Boqun and others) are in the middle of Kangrejos now, so we may
take a bit to reply, sorry.

Cheers,
Miguel

Re: next-20250915: error[E0425]: cannot find function `atomic_read_acquire` in crate `bindings`

[Boqun Feng]

On Tue, Sep 16, 2025 at 06:40:42PM +0200, Miguel Ojeda wrote:
> On Tue, Sep 16, 2025 at 6:26 PM Naresh Kamboju
> <naresh.kamboju@linaro.org> wrote:
> >
> > Anders bisected this build regressions and found,
> >
> > # first bad commit:
> >  [eb57133305f61b612252382d0c1478bba7f57b67]
> >  rust: sync: Add basic atomic operation mapping framework
> 
> That is very useful, thanks.
> 

Yeah, if this is the bad commit, I believe the issue has been fixed.
Because that commit in linue-next indicated the problematic locking/core
branck of tip was used:

eb57133305f6 rust: sync: Add basic atomic operation mapping framework
76eeb9b8de98 (tag: v6.17-rc5) Linux 6.17-rc5

one patch was missing in that version as I mentioned here [1]

[1]: https://lore.kernel.org/lkml/aMWMVQiZxE_mv7va@tardis.local/

Regards,
Boqun

> We (Boqun and others) are in the middle of Kangrejos now, so we may
> take a bit to reply, sorry.
> 
> Cheers,
> Miguel

Re: next-20250915: error[E0425]: cannot find function `atomic_read_acquire` in crate `bindings`

[Christian Heusel]

[-- Attachment #1: Type: text/plain, Size: 3450 bytes --]

On 25/09/16 09:56PM, Naresh Kamboju wrote:
> On Tue, 16 Sept 2025 at 11:17, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >
> > The following build warnings / errors noticed on the arm arm64 and x86_64
> > with rust config build on the Linux next-20250915 tag.
> >
> > First seen on next-20250915
> > Good: next-20250912
> > Bad: next-20250915
> >
> > Regression Analysis:
> > - New regression? yes
> > - Reproducibility? yes
> >
> > * arm, build
> >   - rustclang-lkftconfig-kselftest
> >   - rustgcc-lkftconfig-kselftest
> >
> > * arm64, build
> >   - rustclang-lkftconfig-kselftest
> >   - rustgcc-lkftconfig-kselftest
> >
> > * x86_64, build
> >   - rustgcc-lkftconfig-kselftest
> >   - rustclang-nightly-lkftconfig-kselftest
> >
> > Build regression: next-20250915: error[E0425]: cannot find function
> > `atomic_read_acquire` in crate `bindings`
> 
> Anders bisected this build regressions and found,
> 
> # first bad commit:
>  [eb57133305f61b612252382d0c1478bba7f57b67]
>  rust: sync: Add basic atomic operation mapping framework

Is this still an issue on next-20250916? As far as I can tell this has
been fixed, but now there is another rust build issue, see
https://lore.kernel.org/regressions/0fee48bb-7411-4414-b4e7-395a8c3d0f6c@heusel.eu/
for more information.

Cheers,
Chris

> 
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >
> > ## Build log
> > error[E0425]: cannot find function `atomic_read_acquire` in crate `bindings`
> >    --> rust/kernel/sync/atomic/internal.rs:124:37
> >     |
> > 124 |                   $unsafe { bindings::[< $ctype _ $func >]($($c_arg,)*) }
> >     |                                       ^^^^^^^^^^^^^^^^^^^^ not
> > found in `bindings`
> > ...
> > 201 | / declare_and_impl_atomic_methods!(
> > 202 | |     /// Basic atomic operations
> > 203 | |     pub trait AtomicBasicOps {
> > 204 | |         /// Atomic read (load).
> > ...   |
> > 216 | | );
> >     | |_- in this macro invocation
> >     |
> >     = note: this error originates in the macro `impl_atomic_method`
> > which comes from the expansion of the macro
> > `declare_and_impl_atomic_methods` (in Nightly builds, run with -Z
> > macro-backtrace for more info)
> > error: aborting due to 34 previous errors
> >
> > For more information about this error, try `rustc --explain E0425`.
> > make[3]: *** [rust/Makefile:553: rust/kernel.o] Error 1
> >
> >
> > ## Source
> > * Kernel version: 6.17.0-rc6
> > * Git tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next.git
> > * Git describe: 6.17.0-rc6-next-20250915
> > * Git commit: c3067c2c38316c3ef013636c93daa285ee6aaa2e
> > * Architectures: arm, arm64 and x86_64
> > * Toolchains: gcc (Debian 15.2.0-3) 15.2.0
> > * Kconfigs: rust config
> >
> > ## Build
> > * Build log: https://qa-reports.linaro.org/api/testruns/29894207/log_file/
> > * Build details:
> > https://regressions.linaro.org/lkft/linux-next-master/next-20250915/build/rustgcc-lkftconfig-kselftest/
> > * Build plan: https://tuxapi.tuxsuite.com/v1/groups/linaro/projects/lkft/builds/32l4UDzp0FMtS73JeG3kWpcoQrm
> > * Build link: https://storage.tuxsuite.com/public/linaro/lkft/builds/32l4UDzp0FMtS73JeG3kWpcoQrm/
> > * Kernel config:
> > https://storage.tuxsuite.com/public/linaro/lkft/builds/32l4UDzp0FMtS73JeG3kWpcoQrm/config
> >
> > --
> > Linaro LKFT
> 
> - Naresh
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: next-20250915: error[E0425]: cannot find function `atomic_read_acquire` in crate `bindings`

[Dan Carpenter]

On Tue, Sep 16, 2025 at 06:46:06PM +0200, Christian Heusel wrote:
> On 25/09/16 09:56PM, Naresh Kamboju wrote:
> > On Tue, 16 Sept 2025 at 11:17, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> > >
> > > The following build warnings / errors noticed on the arm arm64 and x86_64
> > > with rust config build on the Linux next-20250915 tag.
> > >
> > > First seen on next-20250915
> > > Good: next-20250912
> > > Bad: next-20250915
> > >
> > > Regression Analysis:
> > > - New regression? yes
> > > - Reproducibility? yes
> > >
> > > * arm, build
> > >   - rustclang-lkftconfig-kselftest
> > >   - rustgcc-lkftconfig-kselftest
> > >
> > > * arm64, build
> > >   - rustclang-lkftconfig-kselftest
> > >   - rustgcc-lkftconfig-kselftest
> > >
> > > * x86_64, build
> > >   - rustgcc-lkftconfig-kselftest
> > >   - rustclang-nightly-lkftconfig-kselftest
> > >
> > > Build regression: next-20250915: error[E0425]: cannot find function
> > > `atomic_read_acquire` in crate `bindings`
> > 
> > Anders bisected this build regressions and found,
> > 
> > # first bad commit:
> >  [eb57133305f61b612252382d0c1478bba7f57b67]
> >  rust: sync: Add basic atomic operation mapping framework
> 
> Is this still an issue on next-20250916? As far as I can tell this has
> been fixed, but now there is another rust build issue, see
> https://lore.kernel.org/regressions/0fee48bb-7411-4414-b4e7-395a8c3d0f6c@heusel.eu/
> for more information.
> 
> Cheers,
> Chris
> 

next-20250916 still fails but with a different Rust issue.

$ make
  SYNC    include/config/auto.conf
  HOSTCC  scripts/basic/fixdep
  CALL    scripts/checksyscalls.sh
  DESCEND objtool
  INSTALL libsubcmd_headers
  RUSTC L rust/kernel.o
error: expected one of `,` or `}`, found `;`
  --> rust/kernel/block/mq/gen_disk.rs:12:23
   |
12 |     fmt::{self, Write};
   |                       ^
   |                       |
   |                       expected one of `,` or `}`
   |                       help: missing `,`

error: aborting due to 1 previous error

make[2]: *** [rust/Makefile:553: rust/kernel.o] Error 1
make[1]: *** [/home/dcarpenter/progs/kernel/devel/Makefile:1286: prepare] Error 2
make: *** [Makefile:248: __sub-make] Error 2

regards,
dan carpenter

Re: next-20250915: error[E0425]: cannot find function `atomic_read_acquire` in crate `bindings`

[Thorsten Leemhuis]

On 17.09.25 09:42, Dan Carpenter wrote:
> On Tue, Sep 16, 2025 at 06:46:06PM +0200, Christian Heusel wrote:
>> On 25/09/16 09:56PM, Naresh Kamboju wrote:
>>> On Tue, 16 Sept 2025 at 11:17, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>>>>
>>>> The following build warnings / errors noticed on the arm arm64 and x86_64
>>>> with rust config build on the Linux next-20250915 tag.
>>>>
>>>> First seen on next-20250915
>>>> Good: next-20250912
>>>> Bad: next-20250915
> [...]
>>>> Build regression: next-20250915: error[E0425]: cannot find function
>>>> `atomic_read_acquire` in crate `bindings`
>>>
>>> Anders bisected this build regressions and found,
>>>
>>> # first bad commit:
>>>  [eb57133305f61b612252382d0c1478bba7f57b67]
>>>  rust: sync: Add basic atomic operation mapping framework
>>
>> Is this still an issue on next-20250916?

FWIW, I ran into this on next-20250915 and it afaics was fixed for
next-20250916.

>> As far as I can tell this has
>> been fixed, but now there is another rust build issue, see
>> https://lore.kernel.org/regressions/0fee48bb-7411-4414-b4e7-395a8c3d0f6c@heusel.eu/
>> for more information.
> 
> next-20250916 still fails but with a different Rust issue.

Ran into that that merge mistake, too, but that can be fixed by the
patch Christian linked to above  -- and I expect Mark (now CCed) has
seen it and will resolve this with today's -next.

> [...]

Ciao, Thorsten

Re: next-20250915: error[E0425]: cannot find function `atomic_read_acquire` in crate `bindings`

[Christian Heusel]

[-- Attachment #1: Type: text/plain, Size: 1689 bytes --]

On 25/09/17 09:58AM, Thorsten Leemhuis wrote:
> On 17.09.25 09:42, Dan Carpenter wrote:
> > On Tue, Sep 16, 2025 at 06:46:06PM +0200, Christian Heusel wrote:
> >> On 25/09/16 09:56PM, Naresh Kamboju wrote:
> >>> On Tue, 16 Sept 2025 at 11:17, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >>>>
> >>>> The following build warnings / errors noticed on the arm arm64 and x86_64
> >>>> with rust config build on the Linux next-20250915 tag.
> >>>>
> >>>> First seen on next-20250915
> >>>> Good: next-20250912
> >>>> Bad: next-20250915
> > [...]
> >>>> Build regression: next-20250915: error[E0425]: cannot find function
> >>>> `atomic_read_acquire` in crate `bindings`
> >>>
> >>> Anders bisected this build regressions and found,
> >>>
> >>> # first bad commit:
> >>>  [eb57133305f61b612252382d0c1478bba7f57b67]
> >>>  rust: sync: Add basic atomic operation mapping framework
> >>
> >> Is this still an issue on next-20250916?
> 
> FWIW, I ran into this on next-20250915 and it afaics was fixed for
> next-20250916.
> 
> >> As far as I can tell this has
> >> been fixed, but now there is another rust build issue, see
> >> https://lore.kernel.org/regressions/0fee48bb-7411-4414-b4e7-395a8c3d0f6c@heusel.eu/
> >> for more information.
> > 
> > next-20250916 still fails but with a different Rust issue.
> 
> Ran into that that merge mistake, too, but that can be fixed by the
> patch Christian linked to above  -- and I expect Mark (now CCed) has
> seen it and will resolve this with today's -next.

The issue was indeed resolved with todays next release :)

> > [...]
> 
> Ciao, Thorsten

Thanks everyone for their input!

Cheers,
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]