From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Danilo Krummrich" <dakr@redhat.com>,
"Viresh Kumar" <vireshk@kernel.org>, "Nishanth Menon" <nm@ti.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: "Viresh Kumar" <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org,
"Vincent Guittot" <vincent.guittot@linaro.org>,
rust-for-linux@vger.kernel.org,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Erik Schilling" <erik.schilling@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Joakim Bech" <joakim.bech@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Yury Norov" <yury.norov@gmail.com>,
"Burak Emir" <bqe@google.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Russell King" <linux@armlinux.org.uk>,
linux-clk@vger.kernel.org,
"Michael Turquette" <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH V9 16/17] rust: opp: Extend OPP abstractions with cpufreq support
Date: Fri, 11 Apr 2025 16:25:15 +0530 [thread overview]
Message-ID: <e88fae38cb339ff88cb64fcd506ce767b458f310.1744366572.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1744366571.git.viresh.kumar@linaro.org>
Extend the OPP abstractions to include support for interacting with the
cpufreq core, including the ability to retrieve frequency tables from
OPP table.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
rust/kernel/opp.rs | 67 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 67 insertions(+)
diff --git a/rust/kernel/opp.rs b/rust/kernel/opp.rs
index 7bf612fa0cc5..a46ac28d4464 100644
--- a/rust/kernel/opp.rs
+++ b/rust/kernel/opp.rs
@@ -20,6 +20,12 @@
types::{ARef, AlwaysRefCounted, Opaque},
};
+#[cfg(CONFIG_CPU_FREQ)]
+use crate::cpufreq;
+
+#[cfg(CONFIG_CPU_FREQ)]
+use core::ops::Deref;
+
use core::{marker::PhantomData, ptr};
use macros::vtable;
@@ -497,6 +503,60 @@ extern "C" fn config_regulators(
}
}
+/// OPP frequency table.
+///
+/// A [`cpufreq::Table`] created from [`Table`].
+#[cfg(CONFIG_CPU_FREQ)]
+pub struct FreqTable {
+ dev: ARef<Device>,
+ ptr: *mut bindings::cpufreq_frequency_table,
+}
+
+#[cfg(CONFIG_CPU_FREQ)]
+impl FreqTable {
+ /// Creates a new instance of [`FreqTable`] from [`Table`].
+ fn new(table: &Table) -> Result<Self> {
+ let mut ptr: *mut bindings::cpufreq_frequency_table = ptr::null_mut();
+
+ // SAFETY: The requirements are satisfied by the existence of [`Device`] and its safety
+ // requirements.
+ to_result(unsafe {
+ bindings::dev_pm_opp_init_cpufreq_table(table.dev.as_raw(), &mut ptr)
+ })?;
+
+ Ok(Self {
+ dev: table.dev.clone(),
+ ptr,
+ })
+ }
+
+ // Returns a reference to the underlying [`cpufreq::Table`].
+ #[inline]
+ fn table(&self) -> &cpufreq::Table {
+ // SAFETY: The `ptr` is guaranteed by the C code to be valid.
+ unsafe { cpufreq::Table::from_raw(self.ptr) }
+ }
+}
+
+#[cfg(CONFIG_CPU_FREQ)]
+impl Deref for FreqTable {
+ type Target = cpufreq::Table;
+
+ #[inline]
+ fn deref(&self) -> &Self::Target {
+ self.table()
+ }
+}
+
+#[cfg(CONFIG_CPU_FREQ)]
+impl Drop for FreqTable {
+ fn drop(&mut self) {
+ // SAFETY: The pointer was created via `dev_pm_opp_init_cpufreq_table`, and is only freed
+ // here.
+ unsafe { bindings::dev_pm_opp_free_cpufreq_table(self.dev.as_raw(), &mut self.as_raw()) };
+ }
+}
+
/// A reference-counted OPP table.
///
/// Rust abstraction for the C `struct opp_table`.
@@ -752,6 +812,13 @@ pub fn adjust_voltage(
})
}
+ /// Creates [`FreqTable`] from [`Table`].
+ #[cfg(CONFIG_CPU_FREQ)]
+ #[inline]
+ pub fn cpufreq_table(&mut self) -> Result<FreqTable> {
+ FreqTable::new(self)
+ }
+
/// Configures device with [`OPP`] matching the frequency value.
#[inline]
pub fn set_rate(&self, freq: Hertz) -> Result<()> {
--
2.31.1.272.g89b43f80a514
next prev parent reply other threads:[~2025-04-11 10:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 10:54 [PATCH V9 00/17] Rust abstractions for clk, cpumask, cpufreq, OPP Viresh Kumar
2025-04-11 10:55 ` [PATCH V9 01/17] rust: cpumask: Use non-atomic helpers Viresh Kumar
2025-04-11 15:20 ` Yury Norov
2025-04-11 10:55 ` [PATCH V9 02/17] rust: cpumask: Add few more helpers Viresh Kumar
2025-04-11 10:55 ` [PATCH V9 03/17] rust: cpumask: Add initial abstractions Viresh Kumar
2025-04-11 15:54 ` Yury Norov
2025-04-14 11:29 ` Viresh Kumar
2025-04-11 10:55 ` [PATCH V9 04/17] MAINTAINERS: Add entry for Rust cpumask API Viresh Kumar
2025-04-11 10:55 ` [PATCH V9 05/17] rust: clk: Add helpers for Rust code Viresh Kumar
2025-04-11 10:55 ` [PATCH V9 06/17] rust: clk: Add initial abstractions Viresh Kumar
2025-04-11 10:55 ` [PATCH V9 07/17] rust: macros: enable use of hyphens in module names Viresh Kumar
2025-04-11 10:55 ` [PATCH V9 08/17] cpufreq: Use enum for cpufreq flags that use BIT() Viresh Kumar
2025-04-11 16:07 ` Yury Norov
2025-04-11 17:05 ` Miguel Ojeda
2025-04-11 10:55 ` [PATCH V9 09/17] rust: cpu: Add from_cpu() Viresh Kumar
2025-04-11 16:18 ` Yury Norov
2025-04-11 18:03 ` Danilo Krummrich
2025-04-11 10:55 ` [PATCH V9 10/17] rust: opp: Add initial abstractions for OPP framework Viresh Kumar
2025-04-11 10:55 ` [PATCH V9 11/17] rust: opp: Add abstractions for the OPP table Viresh Kumar
2025-04-11 16:29 ` Yury Norov
2025-04-11 10:55 ` [PATCH V9 12/17] rust: opp: Add abstractions for the configuration options Viresh Kumar
2025-04-11 10:55 ` [PATCH V9 13/17] rust: cpufreq: Add initial abstractions for cpufreq framework Viresh Kumar
2025-04-11 10:55 ` [PATCH V9 14/17] rust: cpufreq: Extend abstractions for policy and driver ops Viresh Kumar
2025-04-11 10:55 ` [PATCH V9 15/17] rust: cpufreq: Extend abstractions for driver registration Viresh Kumar
2025-04-11 11:58 ` Danilo Krummrich
2025-04-14 8:47 ` Viresh Kumar
2025-04-14 9:39 ` Danilo Krummrich
2025-04-14 10:52 ` Viresh Kumar
2025-04-14 11:51 ` Danilo Krummrich
2025-04-11 10:55 ` Viresh Kumar [this message]
2025-04-11 10:55 ` [PATCH V9 17/17] cpufreq: Add Rust-based cpufreq-dt driver Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e88fae38cb339ff88cb64fcd506ce767b458f310.1744366572.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=a.hindborg@kernel.org \
--cc=alex.bennee@linaro.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=bqe@google.com \
--cc=dakr@kernel.org \
--cc=dakr@redhat.com \
--cc=erik.schilling@linaro.org \
--cc=gary@garyguo.net \
--cc=joakim.bech@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rasmusvillemoes.dk \
--cc=manos.pitsidianakis@linaro.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mturquette@baylibre.com \
--cc=nm@ti.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tmgross@umich.edu \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).