From: Asuna Yang <spriteovo@gmail.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nicolas.schier@linux.dev>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Nicolas Schier" <nsc@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Vivian Wang" <wangruikang@iscas.ac.cn>,
"Han Gao" <rabenda.cn@gmail.com>,
"Jason Montleon" <jmontleo@redhat.com>,
"Conor Dooley" <conor@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org, llvm@lists.linux.dev,
linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 3/4] rust: add a Kconfig function to test for support of bindgen options
Date: Mon, 24 Nov 2025 10:42:04 +0800 [thread overview]
Message-ID: <ef617970-5539-400a-8717-dd96e82bf271@gmail.com> (raw)
In-Reply-To: <CANiq72k=XXRR6pw0Uhk89dmRHFYan6WzJhnDTC0T5oMYAaNnZw@mail.gmail.com>
On 11/24/25 9:48 AM, Miguel Ojeda wrote:
> More importantly, should we just have a separate function for backend
> flags? That would be easier and would avoid having to use the
> environment variable, if I understand the commit message here
> correctly. And, anyway, it is actually the only function we need so
> far.
You are right, separated might be better.
Another reason is, in `scripts/Makefile.compiler`, there is a set of
functions with the same name provided for use by Makefile. Since we
currently do not need to check for bindgen options in Makefile, I didn't
add function for bindgen there. If we add it in the future, the
`bindgen-option` function in `Kconfig.include` will correspond to the
`bindgen-option-yn` function in `Makefile.compiler`, and
`bindgen-option` function in `Makefile.compiler` will return the
selected option instead of yn.
If we don't separate them now, for consistency, in `Makefile.compiler`,
`$(call bindgen-option,-- --some-flag-a,-- --some-flag-b)` will return
an option prefixed with --, which makes it difficult to use.
I will separate them into two functions in the next revision,
`bindgen-option` and `bindgen-backend-option` (or `bindgen-cc-option`?
Which one do you prefer?).
next prev parent reply other threads:[~2025-11-24 2:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 0:23 [PATCH v4 0/4] RISC-V: re-enable gcc + rust builds Asuna Yang
2025-11-24 0:23 ` [PATCH v4 1/4] rust: export BINDGEN_TARGET from a separate Makefile Asuna Yang
2025-11-24 1:40 ` Miguel Ojeda
2025-11-24 0:23 ` [PATCH v4 2/4] rust: generate a fatal error if BINDGEN_TARGET is undefined Asuna Yang
2025-11-24 1:24 ` Miguel Ojeda
2025-11-24 0:23 ` [PATCH v4 3/4] rust: add a Kconfig function to test for support of bindgen options Asuna Yang
2025-11-24 1:48 ` Miguel Ojeda
2025-11-24 2:42 ` Asuna Yang [this message]
2025-11-24 3:08 ` Miguel Ojeda
2025-11-24 18:36 ` Nathan Chancellor
2025-11-24 0:23 ` [PATCH v4 4/4] RISC-V: fix gcc + rust builds Asuna Yang
2025-11-24 1:21 ` Miguel Ojeda
2025-11-24 2:05 ` Asuna Yang
2025-11-24 2:12 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef617970-5539-400a-8717-dd96e82bf271@gmail.com \
--to=spriteovo@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=alex@ghiti.fr \
--cc=aliceryhl@google.com \
--cc=aou@eecs.berkeley.edu \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=jmontleo@redhat.com \
--cc=justinstitt@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nicolas.schier@linux.dev \
--cc=nsc@kernel.org \
--cc=ojeda@kernel.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=rabenda.cn@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).