Rust for Linux List
 help / color / mirror / Atom feed
From: NoisyCoil <noisycoil@disroot.org>
To: stable@vger.kernel.org
Cc: regressions@lists.linux.dev, ojeda@kernel.org,
	alex.gaynor@gmail.com, linux-kernel@vger.kernel.org,
	rust-for-linux@vger.kernel.org
Subject: FTBFS: Rust firmware abstractions in current stable (6.13.4) on arm64 with rustc 1.85.0
Date: Sat, 22 Feb 2025 13:09:29 +0100	[thread overview]
Message-ID: <ef950304-0e98-4c91-8fa1-d236cbb782b8@disroot.org> (raw)

Hi!

The Rust firmware abstractions FTBFS on arm64 and current stable 
(6.13.4) when compiled with rustc 1.85.0:


```
   RUSTC L rust/kernel.o
error[E0308]: mismatched types
   --> rust/kernel/firmware.rs:20:14
    |
20 |         Self(bindings::request_firmware)
    |         ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^ expected fn pointer, found 
fn item
    |         |
    |         arguments to this function are incorrect
    |
    = note: expected fn pointer `unsafe extern "C" fn(_, *const i8, _) -> _`
                  found fn item `unsafe extern "C" fn(_, *const u8, _) 
-> _ {request_firmware}`
note: tuple struct defined here
   --> rust/kernel/firmware.rs:14:8
    |
14 | struct FwFunc(
    |        ^^^^^^

error[E0308]: mismatched types
   --> rust/kernel/firmware.rs:24:14
    |
24 |         Self(bindings::firmware_request_nowarn)
    |         ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected fn 
pointer, found fn item
    |         |
    |         arguments to this function are incorrect
    |
    = note: expected fn pointer `unsafe extern "C" fn(_, *const i8, _) -> _`
                  found fn item `unsafe extern "C" fn(_, *const u8, _) 
-> _ {firmware_request_nowarn}`
note: tuple struct defined here
   --> rust/kernel/firmware.rs:14:8
    |
14 | struct FwFunc(
    |        ^^^^^^

error[E0308]: mismatched types
   --> rust/kernel/firmware.rs:64:45
    |
64 |         let ret = unsafe { func.0(pfw as _, name.as_char_ptr(), 
dev.as_raw()) };
    |                            ------           ^^^^^^^^^^^^^^^^^^ 
expected `*const i8`, found `*const u8`
    |                            |
    |                            arguments to this function are incorrect
    |
    = note: expected raw pointer `*const i8`
               found raw pointer `*const u8`

error: aborting due to 3 previous errors

For more information about this error, try `rustc --explain E0308`.
```


This is because rustc 1.85 (now stable) switched core::ffi::c_char from 
i8 to u8 on arm64 and other platforms [1], and because current stable 
still uses rustc's core's instead of the custom ffi integer types like 
6.14 will. Looking for other i8's in *.rs files tells me only the QR 
code panic screen should be affected in addition to the firmware 
abstractions, and that was already reported in [2].

A simple fix would be to switch i8 to u8 in `struct FwFunc`, but that 
breaks rustc <= 1.84 so I guess a more robust solution is needed.

Cheers!


[1] https://github.com/rust-lang/rust/pull/132975
[2] 
https://lore.kernel.org/all/20250120124531.2581448-1-linkmauve@linkmauve.fr/

             reply	other threads:[~2025-02-22 12:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-22 12:09 NoisyCoil [this message]
2025-02-22 12:20 ` FTBFS: Rust firmware abstractions in current stable (6.13.4) on arm64 with rustc 1.85.0 Miguel Ojeda
2025-02-22 15:14   ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef950304-0e98-4c91-8fa1-d236cbb782b8@disroot.org \
    --to=noisycoil@disroot.org \
    --cc=alex.gaynor@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox