From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C223E1862BC for ; Fri, 7 Jun 2024 11:04:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717758262; cv=none; b=rEahkCSI2IB6DiCaxiXI/Kbp0Fu+eBLkzVqxDcXiBMQ4KhokVHYtmJX75f61KRw1KX9iqqt3Kkcr3W3BICRSUvFLOvXlFKlAcIvtvGeCKm3DEdkD9ZZYjlR6+Iwm8JVUaJtwiqQI+MyeIE/Xpt/zGlUIT7oh36EaQoZEt027g5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717758262; c=relaxed/simple; bh=AN/mXFLmmOOxh4ohQqh0I5EZsgTEbPwsV7LU8Ha71SI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=IGLYbcw+qRklCqmJRWGcOJUJlDCgSLAiDWGS6pxApDP3rtFnTV0aqJVPQtVUjUEF5TQTfNXhs+mdcl8zeUYeQch7oJTfqwPEY2TnP+y4SkGBO0tFbobC7c01NyY9zS72MnVeHGHqd1zQSKbv6lQwY3/aD8mweVY/AObfpQozuL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=sx8ROLsc; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sx8ROLsc" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4210aa00c94so18404795e9.1 for ; Fri, 07 Jun 2024 04:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717758258; x=1718363058; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:in-reply-to :references:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=dlz1M1Q96MoJTbBHiqN6xZFkx4A4jAugPwmqHEAfQlM=; b=sx8ROLscim+16/5RnC+EJHtkqutKqN66BekfmIea1CLQhllcXogYZaoxQi8OF/AFFb LdpWUCQFpqsnLrV5UlB2nE3NOkXOxvhgnlViZjHiyQxI6wEbEy/RZGJvt3Fc2JixA7gP cIy67SSNzLIGMq8jmWLPb1uuYlgiDIOoIXuWzYBT0fVeHMrzeUVNzOS/57nTalCcXOxC ti8HfZnqu7yar+kDZ154joNwXa8SWV9heVAVfXVM4rGrBdii1yK2E7+jzIMuDH/G8IeL vcrqYUIcv8nrBx8cWUZRRcgVeT1zSM2opxHYaE2AdckFqqpzQe9JxLgYZ4GqD4/BOCXh chKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717758258; x=1718363058; h=content-transfer-encoding:mime-version:message-id:in-reply-to :references:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dlz1M1Q96MoJTbBHiqN6xZFkx4A4jAugPwmqHEAfQlM=; b=wxWMRHwKY4UK201OAULRObmhlFr5e+/5vGrS01ku05hPgSIIcINisfNSse4MmlvTDE GrcSo3LXBayhHlNyQ9bEtC+sz60jle56eToV2a050tfGlkomvcosGqOjVDVy3PK4dFaD 2SYBCupGAbYo60xCl3mQWF8BKZHmb2xkINKoGI5Lwqmszhx4xEHy8W7ynNLplLiFpPWF DibIYByIVcMLubkcPm6kX3jSjgzQjXVsuRUDs4nK1ipeJ/HklAIMN7ZU+NSbYQQBOLP5 pChTUYAQZZvaJ0lVe2jqFG7A/jBniPJ/kd44BUN2AoPmUsExTrOvif/KScTbgufWyA0b ZBrA== X-Forwarded-Encrypted: i=1; AJvYcCVLC8VlDiABFDaxp3LsDQeygiS+2GhO0JwKDbGS+NxgcfnSk9z0RhpTTwWxNzmS+zlbYbos6z/2WVol5LFyu00FuKcFAf4qvkVX7HR4org= X-Gm-Message-State: AOJu0YysZoDpQ3d4d1DiGVZrAj/iL/xQ0aF+W2hZLplLupZBFtZobXBM wJtIzQJsYAamfo05AXpIcYHlAf0bVMuLwVj5TyoXzXqaf+XzWzJK8drvIN/cV5k= X-Google-Smtp-Source: AGHT+IHod7WifBUl7WN31uqgwKkQIdjobL7dtcDM7zsUKlmpwG3Nkk+YAZ0yifsUngtlMlKS08HWgA== X-Received: by 2002:a05:600c:4f8e:b0:41b:f022:8e69 with SMTP id 5b1f17b1804b1-42164a03160mr19707055e9.19.1717758258064; Fri, 07 Jun 2024 04:04:18 -0700 (PDT) Received: from meli-email.org (adsl-105.37.6.1.tellas.gr. [37.6.1.105]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4215809fcbesm84707525e9.0.2024.06.07.04.04.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 04:04:17 -0700 (PDT) Date: Fri, 07 Jun 2024 13:38:17 +0300 From: Manos Pitsidianakis To: Viresh Kumar , "Rafael J. Wysocki" , Miguel Ojeda , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , Bj=?UTF-8?B?w7Y=?= rn Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , Stephen Boyd , Nishanth Menon , rust-for-linux@vger.kernel.org, Manos Pitsidianakis , Erik Schilling , Alex Benn=?UTF-8?B?w6k=?= e , Joakim Bech , Rob Herring , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH V2 2/8] rust: Extend OPP bindings for the OPP table User-Agent: meli 0.8.5 References: In-Reply-To: Message-ID: Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8; format=flowed On Fri, 07 Jun 2024 12:12, Viresh Kumar wrote: >This extends OPP bindings with the bindings for the `struct opp_table`. > >Signed-off-by: Viresh Kumar >--- > rust/kernel/opp.rs | 374 ++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 372 insertions(+), 2 deletions(-) > >diff --git a/rust/kernel/opp.rs b/rust/kernel/opp.rs >index 9e5cf0412ed5..06f36845047f 100644 >--- a/rust/kernel/opp.rs >+++ b/rust/kernel/opp.rs >@@ -7,9 +7,9 @@ > //! C header: [`include/linux/pm_opp.h`](../../../../../../include/linux/pm_opp.h) > > use crate::{ >- bindings, >+ bindings, cpumask, > device::Device, >- error::{code::*, to_result, Result}, >+ error::{code::*, from_err_ptr, to_result, Error, Result}, > types::{ARef, AlwaysRefCounted, Opaque}, > }; > >@@ -31,6 +31,376 @@ pub fn new(freq: u64, u_volt: u64, level: u32, turbo: bool) -> Self { > } > } > >+/// OPP search types. >+#[derive(Copy, Clone, Debug, Eq, PartialEq)] >+pub enum SearchType { >+ /// Search for exact value. >+ Exact, >+ /// Search for highest value less than equal to value. >+ Floor, >+ /// Search for lowest value greater than equal to value. >+ Ceil, >+} Seeing this enum made me think about memory layouts which are not stable in Rust and can change between compilations unless they have a specific `repr`. Not related to this series directly, has there been discussion about guaranteeing struct layouts in kernel APIs? It'd require a lot of things to happen to cause a problem (multiple users of an API in the kernel in separate compilation units maybe even compiled with different rustc versions). >+ >+/// Operating performance point (OPP) table. >+/// >+/// # Invariants >+/// >+/// The pointer stored in `Self` is non-null and valid for the lifetime of the ARef instance. In >+/// particular, the ARef instance owns an increment on underlying object’s reference count. >+pub struct Table { >+ ptr: *mut bindings::opp_table, >+ dev: ARef, >+ em: bool, >+ of: bool, >+ cpumask: Option, >+} >+ >+// SAFETY: The fields of `Table` are safe to be used from any thread. >+unsafe impl Send for Table {} >+ >+// SAFETY: The fields of `Table` are safe to be referenced from any thread. >+unsafe impl Sync for Table {} >+ >+impl Table { >+ /// Creates a new OPP table instance from raw pointer. >+ /// >+ /// # Safety >+ /// >+ /// Callers must ensure that `ptr` is valid and non-null. >+ unsafe fn from_ptr(ptr: *mut bindings::opp_table, dev: ARef) -> Self { >+ // SAFETY: By the safety requirements, ptr is valid and its refcount will be incremented. >+ unsafe { bindings::dev_pm_opp_get_opp_table_ref(ptr) }; >+ >+ Self { >+ ptr, >+ dev, >+ em: false, >+ of: false, >+ cpumask: None, >+ } >+ } >+ >+ /// Find OPP table from device. >+ pub fn from_dev(dev: ARef) -> Result { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. Refcount of the OPP table is incremented as well. >+ let ptr = from_err_ptr(unsafe { bindings::dev_pm_opp_get_opp_table(dev.as_raw()) })?; >+ >+ Ok(Self { >+ ptr, >+ dev: dev.clone(), Clone is not probably not needed here, right? the argument value will be dropped after this. >+ em: false, >+ of: false, >+ cpumask: None, >+ }) >+ } >+ >+ /// Add device tree based OPP table for the device. >+ #[cfg(CONFIG_OF)] >+ pub fn from_of(dev: ARef, index: i32) -> Result { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. Refcount of the OPP table is incremented as well. >+ to_result(unsafe { bindings::dev_pm_opp_of_add_table_indexed(dev.as_raw(), index) })?; >+ >+ // Fetch the newly created table. >+ let mut table = Self::from_dev(dev)?; >+ table.of = true; >+ >+ Ok(table) >+ } >+ >+ // Remove device tree based OPP table for the device. >+ #[cfg(CONFIG_OF)] >+ fn remove_of(&self) { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. We took the reference from `from_of` earlier, it is safe to drop the same >+ // now. >+ unsafe { bindings::dev_pm_opp_of_remove_table(self.dev.as_raw()) }; >+ } >+ >+ /// Add device tree based OPP table for CPU devices. >+ #[cfg(CONFIG_OF)] >+ pub fn from_of_cpumask(dev: ARef, cpumask: &mut cpumask::Cpumask) -> Result { >+ // SAFETY: The cpumask is valid and the returned ptr will be owned by the [`Table`] instance. >+ to_result(unsafe { bindings::dev_pm_opp_of_cpumask_add_table(cpumask.as_ptr()) })?; >+ >+ // Fetch the newly created table. >+ let mut table = Self::from_dev(dev)?; >+ // SAFETY: The `cpumask` is guaranteed by the C code to be valid. >+ table.cpumask = Some(unsafe { cpumask::Cpumask::new(cpumask.as_mut_ptr()) }); >+ >+ Ok(table) >+ } >+ >+ // Remove device tree based OPP table for CPU devices. >+ #[cfg(CONFIG_OF)] >+ fn remove_of_cpumask(&self, cpumask: &cpumask::Cpumask) { >+ // SAFETY: The cpumask is valid and we took the reference from `from_of_cpumask` earlier, >+ // it is safe to drop the same now. >+ unsafe { bindings::dev_pm_opp_of_cpumask_remove_table(cpumask.as_ptr()) }; >+ } >+ >+ /// Returns the number of OPPs in the table. >+ pub fn opp_count(&self) -> Result { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. >+ let ret = unsafe { bindings::dev_pm_opp_get_opp_count(self.dev.as_raw()) }; >+ if ret < 0 { >+ Err(Error::from_errno(ret)) >+ } else { >+ Ok(ret as u32) >+ } >+ } >+ >+ /// Returns max clock latency of the OPPs in the table. >+ pub fn max_clock_latency(&self) -> u64 { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. >+ unsafe { bindings::dev_pm_opp_get_max_clock_latency(self.dev.as_raw()) } >+ } >+ >+ /// Returns max volt latency of the OPPs in the table. >+ pub fn max_volt_latency(&self) -> u64 { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. >+ unsafe { bindings::dev_pm_opp_get_max_volt_latency(self.dev.as_raw()) } >+ } >+ >+ /// Returns max transition latency of the OPPs in the table. >+ pub fn max_transition_latency(&self) -> u64 { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. >+ unsafe { bindings::dev_pm_opp_get_max_transition_latency(self.dev.as_raw()) } >+ } >+ >+ /// Returns the suspend OPP. >+ pub fn suspend_freq(&self) -> u64 { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. >+ unsafe { bindings::dev_pm_opp_get_suspend_opp_freq(self.dev.as_raw()) } >+ } >+ >+ /// Synchronizes regulators used by the OPP table. >+ pub fn sync_regulators(&self) -> Result<()> { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. >+ to_result(unsafe { bindings::dev_pm_opp_sync_regulators(self.dev.as_raw()) }) >+ } >+ >+ /// Gets sharing CPUs. >+ pub fn sharing_cpus(dev: ARef, cpumask: &mut cpumask::Cpumask) -> Result<()> { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. >+ to_result(unsafe { >+ bindings::dev_pm_opp_get_sharing_cpus(dev.as_raw(), cpumask.as_mut_ptr()) >+ }) >+ } >+ >+ /// Sets sharing CPUs. >+ pub fn set_sharing_cpus(&self, cpumask: &cpumask::Cpumask) -> Result<()> { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. >+ to_result(unsafe { >+ bindings::dev_pm_opp_set_sharing_cpus(self.dev.as_raw(), cpumask.as_ptr()) >+ }) >+ } >+ >+ /// Gets sharing CPUs from Device tree. >+ #[cfg(CONFIG_OF)] >+ pub fn of_sharing_cpus(dev: ARef, cpumask: &mut cpumask::Cpumask) -> Result<()> { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. >+ to_result(unsafe { >+ bindings::dev_pm_opp_of_get_sharing_cpus(dev.as_raw(), cpumask.as_mut_ptr()) >+ }) >+ } >+ >+ /// Updates the voltage value for an OPP. >+ pub fn adjust_voltage( >+ &self, >+ freq: u64, >+ u_volt: u64, >+ u_volt_min: u64, >+ u_volt_max: u64, >+ ) -> Result<()> { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. >+ to_result(unsafe { >+ bindings::dev_pm_opp_adjust_voltage( >+ self.dev.as_raw(), >+ freq, >+ u_volt, >+ u_volt_min, >+ u_volt_max, >+ ) >+ }) >+ } >+ >+ /// Sets a matching OPP based on frequency. >+ pub fn set_rate(&self, freq: u64) -> Result<()> { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. >+ to_result(unsafe { bindings::dev_pm_opp_set_rate(self.dev.as_raw(), freq) }) >+ } >+ >+ /// Sets exact OPP. >+ pub fn set_opp(&self, opp: ARef) -> Result<()> { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. >+ to_result(unsafe { bindings::dev_pm_opp_set_opp(self.dev.as_raw(), opp.as_mut_ptr()) }) >+ } >+ >+ /// Finds OPP based on frequency. >+ pub fn opp_from_freq( >+ &self, >+ mut freq: u64, >+ available: Option, >+ index: Option, >+ stype: SearchType, >+ ) -> Result> { >+ let rdev = self.dev.as_raw(); >+ let index = index.unwrap_or(0); >+ >+ let ptr = from_err_ptr(match stype { >+ SearchType::Exact => { >+ if let Some(available) = available { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and >+ // its safety requirements. The returned ptr will be owned by the new [`OPP`] >+ // instance. >+ unsafe { >+ bindings::dev_pm_opp_find_freq_exact_indexed(rdev, freq, index, available) >+ } >+ } else { >+ return Err(EINVAL); >+ } >+ } >+ >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its >+ // safety requirements. The returned ptr will be owned by the new [`OPP`] instance. >+ SearchType::Ceil => unsafe { >+ bindings::dev_pm_opp_find_freq_ceil_indexed(rdev, &mut freq as *mut u64, index) >+ }, >+ >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its >+ // safety requirements. The returned ptr will be owned by the new [`OPP`] instance. >+ SearchType::Floor => unsafe { >+ bindings::dev_pm_opp_find_freq_floor_indexed(rdev, &mut freq as *mut u64, index) >+ }, >+ })?; >+ >+ // SAFETY: The `ptr` is guaranteed by the C code to be valid. >+ unsafe { OPP::from_ptr_owned(ptr) } >+ } >+ >+ /// Finds OPP based on level. >+ pub fn opp_from_level(&self, mut level: u32, stype: SearchType) -> Result> { >+ let rdev = self.dev.as_raw(); >+ >+ let ptr = from_err_ptr(match stype { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its >+ // safety requirements. The returned ptr will be owned by the new [`OPP`] instance. >+ SearchType::Exact => unsafe { bindings::dev_pm_opp_find_level_exact(rdev, level) }, >+ Minor style comment, the empty lines between match patterns are unusual >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its >+ // safety requirements. The returned ptr will be owned by the new [`OPP`] instance. >+ SearchType::Ceil => unsafe { >+ bindings::dev_pm_opp_find_level_ceil(rdev, &mut level as *mut u32) >+ }, >+ >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its >+ // safety requirements. The returned ptr will be owned by the new [`OPP`] instance. >+ SearchType::Floor => unsafe { >+ bindings::dev_pm_opp_find_level_floor(rdev, &mut level as *mut u32) >+ }, >+ })?; >+ >+ // SAFETY: The `ptr` is guaranteed by the C code to be valid. >+ unsafe { OPP::from_ptr_owned(ptr) } >+ } >+ >+ /// Finds OPP based on bandwidth. >+ pub fn opp_from_bw(&self, mut bw: u32, index: i32, stype: SearchType) -> Result> { >+ let rdev = self.dev.as_raw(); >+ >+ let ptr = from_err_ptr(match stype { >+ // The OPP core doesn't support this yet. >+ SearchType::Exact => return Err(EINVAL), >+ >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its >+ // safety requirements. The returned ptr will be owned by the new [`OPP`] instance. >+ SearchType::Ceil => unsafe { >+ bindings::dev_pm_opp_find_bw_ceil(rdev, &mut bw as *mut u32, index) >+ }, >+ >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its >+ // safety requirements. The returned ptr will be owned by the new [`OPP`] instance. >+ SearchType::Floor => unsafe { >+ bindings::dev_pm_opp_find_bw_floor(rdev, &mut bw as *mut u32, index) >+ }, >+ })?; >+ >+ // SAFETY: The `ptr` is guaranteed by the C code to be valid. >+ unsafe { OPP::from_ptr_owned(ptr) } >+ } >+ >+ /// Enable the OPP. >+ pub fn enable_opp(&self, freq: u64) -> Result<()> { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. >+ to_result(unsafe { bindings::dev_pm_opp_enable(self.dev.as_raw(), freq) }) >+ } >+ >+ /// Disable the OPP. >+ pub fn disable_opp(&self, freq: u64) -> Result<()> { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. >+ to_result(unsafe { bindings::dev_pm_opp_disable(self.dev.as_raw(), freq) }) >+ } >+ >+ /// Registers with Energy model. >+ #[cfg(CONFIG_OF)] >+ pub fn of_register_em(&mut self, cpumask: &mut cpumask::Cpumask) -> Result<()> { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. >+ to_result(unsafe { >+ bindings::dev_pm_opp_of_register_em(self.dev.as_raw(), cpumask.as_mut_ptr()) >+ })?; >+ >+ self.em = true; >+ Ok(()) >+ } >+ >+ // Unregisters with Energy model. >+ #[cfg(CONFIG_OF)] >+ fn of_unregister_em(&self) { >+ // SAFETY: The requirements are satisfied by the existence of `Device` and its safety >+ // requirements. We registered with the EM framework earlier, it is safe to unregister now. >+ unsafe { bindings::em_dev_unregister_perf_domain(self.dev.as_raw()) }; >+ } >+} >+ >+impl Drop for Table { >+ fn drop(&mut self) { >+ // SAFETY: By the type invariants, we know that `self` owns a reference, so it is safe >+ // to relinquish it now. >+ unsafe { bindings::dev_pm_opp_put_opp_table(self.ptr) }; >+ >+ #[cfg(CONFIG_OF)] >+ { >+ if self.em { >+ self.of_unregister_em(); >+ } >+ >+ if self.of { >+ self.remove_of(); >+ } else if let Some(cpumask) = &self.cpumask { >+ self.remove_of_cpumask(cpumask); >+ } >+ } >+ } >+} >+ > /// Operating performance point (OPP). > /// > /// # Invariants >-- >2.31.1.272.g89b43f80a514 >