From: lyude@redhat.com
To: Timur Tabi <ttabi@nvidia.com>, Danilo Krummrich <dakr@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>,
joelagnelf@nvidia.com, nouveau@lists.freedesktop.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 1/7] rust: pci: add PCI device name method
Date: Mon, 15 Dec 2025 11:49:03 -0500 [thread overview]
Message-ID: <f0ad76f8e6e044f56f86d39718843f838b5a8be1.camel@redhat.com> (raw)
In-Reply-To: <20251212204952.3690244-2-ttabi@nvidia.com>
On Fri, 2025-12-12 at 14:49 -0600, Timur Tabi wrote:
> + // `struct pci_dev`, which contains a `struct device dev`
> member.
> + unsafe {
> + let pci_dev = self.as_raw();
> + let dev = addr_of_mut!((*pci_dev).dev);
> +
JFYI - addr_of!/addr_of_mut! shouldn't be used in new code, we're
moving to using &raw const and &raw mut respectively (which pretty much
do the same thing without a macro).
next prev parent reply other threads:[~2025-12-15 16:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 20:49 [PATCH 0/7] gpu: nova-core: expose the logging buffers via debugfs Timur Tabi
2025-12-12 20:49 ` [PATCH 1/7] rust: pci: add PCI device name method Timur Tabi
2025-12-15 11:35 ` Gary Guo
2025-12-15 16:49 ` lyude [this message]
2025-12-12 20:49 ` [PATCH 2/7] gpu: nova-core: Replace module_pci_driver! with explicit module init Timur Tabi
2025-12-13 23:46 ` Joel Fernandes
2025-12-15 11:36 ` Gary Guo
2025-12-12 20:49 ` [PATCH 3/7] gpu: nova-core: create debugfs root in PCI init closure Timur Tabi
2025-12-15 11:40 ` Gary Guo
2025-12-15 16:45 ` Timur Tabi
2025-12-16 10:04 ` John Hubbard
2025-12-16 20:28 ` Timur Tabi
2025-12-16 22:01 ` Joel Fernandes
2025-12-16 22:29 ` Timur Tabi
2025-12-16 23:17 ` Joel Fernandes
2025-12-16 23:29 ` Timur Tabi
2025-12-12 20:49 ` [PATCH 4/7] gpu: nova-core: implement BinaryWriter for LogBuffer Timur Tabi
2025-12-12 20:49 ` [PATCH 5/7] gpu: nova-core: use pin projection in method boot() Timur Tabi
2025-12-12 20:49 ` [PATCH 6/7] gpu: nova-core: create loginit debugfs entry Timur Tabi
2025-12-15 16:45 ` Timur Tabi
2025-12-12 20:49 ` [PATCH 7/7] gpu: nova-core: create GSP-RM logging buffers debugfs entries Timur Tabi
2025-12-13 23:44 ` Joel Fernandes
2025-12-13 19:19 ` [PATCH 0/7] gpu: nova-core: expose the logging buffers via debugfs Joel Fernandes
2025-12-13 20:47 ` Timur Tabi
2025-12-13 21:49 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0ad76f8e6e044f56f86d39718843f838b5a8be1.camel@redhat.com \
--to=lyude@redhat.com \
--cc=acourbot@nvidia.com \
--cc=dakr@kernel.org \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).