From: Igor Korotin <igor.korotin@linux.dev>
To: "Gary Guo" <gary@garyguo.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Igor Korotin" <igor.korotin.linux@gmail.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/8] rust: samples: i2c: remove redundant `.as_ref()` for `dev_*` print
Date: Tue, 27 Jan 2026 18:52:40 +0000 [thread overview]
Message-ID: <f2385851-87c0-44d1-8e1c-4e5553aa1893@linux.dev> (raw)
In-Reply-To: <20260123175854.176735-5-gary@kernel.org>
Hi
On 1/23/2026 5:58 PM, Gary Guo wrote:
> From: Gary Guo <gary@garyguo.net>
>
> This is now handled by the macro itself.
>
> Signed-off-by: Gary Guo <gary@garyguo.net>
> ---
> samples/rust/rust_driver_i2c.rs | 10 ++++------
> samples/rust/rust_i2c_client.rs | 10 ++--------
> 2 files changed, 6 insertions(+), 14 deletions(-)
>
> diff --git a/samples/rust/rust_driver_i2c.rs b/samples/rust/rust_driver_i2c.rs
> index 6be79f9e9fb5..3079d57fe473 100644
> --- a/samples/rust/rust_driver_i2c.rs
> +++ b/samples/rust/rust_driver_i2c.rs
> @@ -44,23 +44,21 @@ fn probe(
> idev: &i2c::I2cClient<Core>,
> info: Option<&Self::IdInfo>,
> ) -> impl PinInit<Self, Error> {
> - let dev = idev.as_ref();
> -
> - dev_info!(dev, "Probe Rust I2C driver sample.\n");
> + dev_info!(idev, "Probe Rust I2C driver sample.\n");
>
> if let Some(info) = info {
> - dev_info!(dev, "Probed with info: '{}'.\n", info);
> + dev_info!(idev, "Probed with info: '{}'.\n", info);
> }
>
> Ok(Self)
> }
>
> fn shutdown(idev: &i2c::I2cClient<Core>, _this: Pin<&Self>) {
> - dev_info!(idev.as_ref(), "Shutdown Rust I2C driver sample.\n");
> + dev_info!(idev, "Shutdown Rust I2C driver sample.\n");
> }
>
> fn unbind(idev: &i2c::I2cClient<Core>, _this: Pin<&Self>) {
> - dev_info!(idev.as_ref(), "Unbind Rust I2C driver sample.\n");
> + dev_info!(idev, "Unbind Rust I2C driver sample.\n");
> }
> }
>
> diff --git a/samples/rust/rust_i2c_client.rs b/samples/rust/rust_i2c_client.rs
> index 8d2c12e535b0..72da5499f150 100644
> --- a/samples/rust/rust_i2c_client.rs
> +++ b/samples/rust/rust_i2c_client.rs
> @@ -113,10 +113,7 @@ fn probe(
> pdev: &platform::Device<device::Core>,
> _info: Option<&Self::IdInfo>,
> ) -> impl PinInit<Self, Error> {
> - dev_info!(
> - pdev.as_ref(),
> - "Probe Rust I2C Client registration sample.\n"
> - );
> + dev_info!(pdev, "Probe Rust I2C Client registration sample.\n");
>
> kernel::try_pin_init!( Self {
> parent_dev: pdev.into(),
> @@ -130,10 +127,7 @@ fn probe(
> }
>
> fn unbind(pdev: &platform::Device<device::Core>, _this: Pin<&Self>) {
> - dev_info!(
> - pdev.as_ref(),
> - "Unbind Rust I2C Client registration sample.\n"
> - );
> + dev_info!(pdev, "Unbind Rust I2C Client registration sample.\n");
> }
> }
>
Acked-by: Igor Korotin <igor.korotin.linux@gmail.com>
Thanks
Igor
next prev parent reply other threads:[~2026-01-27 18:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 17:58 [PATCH v2 1/8] rust: device: support `dev_printk` on all devices Gary Guo
2026-01-23 17:58 ` [PATCH v2 2/8] rust: pci: remove redundant `.as_ref()` for `dev_*` print Gary Guo
2026-01-24 0:38 ` Danilo Krummrich
2026-01-23 17:58 ` [PATCH v2 3/8] rust: samples: driver-core: " Gary Guo
2026-01-24 0:38 ` Danilo Krummrich
2026-01-23 17:58 ` [PATCH v2 4/8] rust: samples: dma: " Gary Guo
2026-01-24 0:39 ` Danilo Krummrich
2026-01-23 17:58 ` [PATCH v2 5/8] rust: samples: i2c: " Gary Guo
2026-01-27 18:52 ` Igor Korotin [this message]
2026-01-23 17:58 ` [PATCH v2 6/8] rust: samples: usb: " Gary Guo
2026-01-24 5:36 ` kernel test robot
2026-01-23 17:58 ` [PATCH v2 7/8] gpu: nova-core: " Gary Guo
2026-01-24 13:07 ` Alexandre Courbot
2026-01-24 13:29 ` Danilo Krummrich
2026-02-13 0:11 ` Alexandre Courbot
2026-02-24 14:17 ` Danilo Krummrich
2026-02-27 19:30 ` Aditya Rajan
2026-01-23 17:58 ` [PATCH v2 8/8] gpu: tyr: " Gary Guo
2026-01-24 0:37 ` [PATCH v2 1/8] rust: device: support `dev_printk` on all devices Danilo Krummrich
2026-01-24 6:31 ` Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2385851-87c0-44d1-8e1c-4e5553aa1893@linux.dev \
--to=igor.korotin@linux.dev \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=igor.korotin.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox