From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Danilo Krummrich" <dakr@redhat.com>,
"Viresh Kumar" <vireshk@kernel.org>, "Nishanth Menon" <nm@ti.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: "Viresh Kumar" <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org,
"Vincent Guittot" <vincent.guittot@linaro.org>,
rust-for-linux@vger.kernel.org,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Joakim Bech" <joakim.bech@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Yury Norov" <yury.norov@gmail.com>,
"Burak Emir" <bqe@google.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Russell King" <linux@armlinux.org.uk>,
linux-clk@vger.kernel.org,
"Michael Turquette" <mturquette@baylibre.com>,
"Andrew Ballance" <andrewjballance@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH V12 14/15] rust: opp: Extend OPP abstractions with cpufreq support
Date: Mon, 19 May 2025 12:37:19 +0530 [thread overview]
Message-ID: <f4a35fcc3c4f6b737bbd359854ea12f5a53bcb37.1747634382.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1747634382.git.viresh.kumar@linaro.org>
Extend the OPP abstractions to include support for interacting with the
cpufreq core, including the ability to retrieve frequency tables from
OPP table.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
rust/kernel/opp.rs | 70 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 70 insertions(+)
diff --git a/rust/kernel/opp.rs b/rust/kernel/opp.rs
index 7be6fd33d93f..1e5fd9887b3a 100644
--- a/rust/kernel/opp.rs
+++ b/rust/kernel/opp.rs
@@ -19,6 +19,69 @@
types::{ARef, AlwaysRefCounted, Opaque},
};
+#[cfg(CONFIG_CPU_FREQ)]
+/// Frequency table implementation.
+mod freq {
+ use super::*;
+ use crate::cpufreq;
+ use core::ops::Deref;
+
+ /// OPP frequency table.
+ ///
+ /// A [`cpufreq::Table`] created from [`Table`].
+ pub struct FreqTable {
+ dev: ARef<Device>,
+ ptr: *mut bindings::cpufreq_frequency_table,
+ }
+
+ impl FreqTable {
+ /// Creates a new instance of [`FreqTable`] from [`Table`].
+ pub(crate) fn new(table: &Table) -> Result<Self> {
+ let mut ptr: *mut bindings::cpufreq_frequency_table = ptr::null_mut();
+
+ // SAFETY: The requirements are satisfied by the existence of [`Device`] and its safety
+ // requirements.
+ to_result(unsafe {
+ bindings::dev_pm_opp_init_cpufreq_table(table.dev.as_raw(), &mut ptr)
+ })?;
+
+ Ok(Self {
+ dev: table.dev.clone(),
+ ptr,
+ })
+ }
+
+ /// Returns a reference to the underlying [`cpufreq::Table`].
+ #[inline]
+ fn table(&self) -> &cpufreq::Table {
+ // SAFETY: The `ptr` is guaranteed by the C code to be valid.
+ unsafe { cpufreq::Table::from_raw(self.ptr) }
+ }
+ }
+
+ impl Deref for FreqTable {
+ type Target = cpufreq::Table;
+
+ #[inline]
+ fn deref(&self) -> &Self::Target {
+ self.table()
+ }
+ }
+
+ impl Drop for FreqTable {
+ fn drop(&mut self) {
+ // SAFETY: The pointer was created via `dev_pm_opp_init_cpufreq_table`, and is only
+ // freed here.
+ unsafe {
+ bindings::dev_pm_opp_free_cpufreq_table(self.dev.as_raw(), &mut self.as_raw())
+ };
+ }
+ }
+}
+
+#[cfg(CONFIG_CPU_FREQ)]
+pub use freq::FreqTable;
+
use core::{marker::PhantomData, ptr};
use macros::vtable;
@@ -753,6 +816,13 @@ pub fn adjust_voltage(
})
}
+ /// Creates [`FreqTable`] from [`Table`].
+ #[cfg(CONFIG_CPU_FREQ)]
+ #[inline]
+ pub fn cpufreq_table(&mut self) -> Result<FreqTable> {
+ FreqTable::new(self)
+ }
+
/// Configures device with [`OPP`] matching the frequency value.
#[inline]
pub fn set_rate(&self, freq: Hertz) -> Result<()> {
--
2.31.1.272.g89b43f80a514
next prev parent reply other threads:[~2025-05-19 7:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <HVTDJypFNQFfSQJmmYDSPU4o-irFnjmDN22RW3S0z5Kwe_hVk9kquZWElv-C2k6d5kOIiewhj_Xo2kAoTHbHgg==@protonmail.internalid>
2025-05-19 7:07 ` [PATCH V12 00/15] Rust abstractions for clk, cpumask, cpufreq, OPP Viresh Kumar
2025-05-19 7:07 ` [PATCH V12 01/15] rust: cpumask: Add few more helpers Viresh Kumar
2025-05-19 7:07 ` [PATCH V12 02/15] rust: cpumask: Add initial abstractions Viresh Kumar
2025-05-19 7:07 ` [PATCH V12 03/15] MAINTAINERS: Add entry for Rust cpumask API Viresh Kumar
2025-05-19 7:07 ` [PATCH V12 04/15] rust: clk: Add helpers for Rust code Viresh Kumar
2025-05-19 7:07 ` [PATCH V12 05/15] rust: clk: Add initial abstractions Viresh Kumar
2025-05-19 7:07 ` [PATCH V12 06/15] rust: macros: enable use of hyphens in module names Viresh Kumar
2025-05-19 8:00 ` Benno Lossin
2025-05-19 9:58 ` Viresh Kumar
2025-05-19 14:15 ` Miguel Ojeda
2025-05-20 4:33 ` Viresh Kumar
2025-05-20 6:13 ` Anisse Astier
2025-05-20 6:22 ` Viresh Kumar
2025-05-19 7:07 ` [PATCH V12 07/15] rust: cpu: Add from_cpu() Viresh Kumar
2025-05-19 7:07 ` [PATCH V12 08/15] rust: opp: Add initial abstractions for OPP framework Viresh Kumar
2025-05-19 7:07 ` [PATCH V12 09/15] rust: opp: Add abstractions for the OPP table Viresh Kumar
2025-05-19 7:07 ` [PATCH V12 10/15] rust: opp: Add abstractions for the configuration options Viresh Kumar
2025-05-19 7:07 ` [PATCH V12 11/15] rust: cpufreq: Add initial abstractions for cpufreq framework Viresh Kumar
2025-05-19 7:07 ` [PATCH V12 12/15] rust: cpufreq: Extend abstractions for policy and driver ops Viresh Kumar
2025-05-19 7:07 ` [PATCH V12 13/15] rust: cpufreq: Extend abstractions for driver registration Viresh Kumar
2025-05-19 11:06 ` Danilo Krummrich
2025-05-19 11:41 ` Benno Lossin
2025-05-19 11:49 ` Miguel Ojeda
2025-05-20 5:59 ` Viresh Kumar
2025-05-19 7:07 ` Viresh Kumar [this message]
2025-05-19 7:07 ` [PATCH V12 15/15] cpufreq: Add Rust-based cpufreq-dt driver Viresh Kumar
2025-05-20 6:23 ` [PATCH V12 00/15] Rust abstractions for clk, cpumask, cpufreq, OPP Viresh Kumar
2025-06-05 19:41 ` Andreas Hindborg
2025-06-05 20:12 ` Boqun Feng
2025-06-06 4:20 ` Viresh Kumar
2025-06-06 4:19 ` Viresh Kumar
2025-06-06 10:10 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4a35fcc3c4f6b737bbd359854ea12f5a53bcb37.1747634382.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=a.hindborg@kernel.org \
--cc=alex.bennee@linaro.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=andrewjballance@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=bqe@google.com \
--cc=dakr@kernel.org \
--cc=dakr@redhat.com \
--cc=gary@garyguo.net \
--cc=joakim.bech@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rasmusvillemoes.dk \
--cc=manos.pitsidianakis@linaro.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mturquette@baylibre.com \
--cc=nm@ti.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tmgross@umich.edu \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).