From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB8DAC76196 for ; Mon, 3 Apr 2023 17:57:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232682AbjDCR5H (ORCPT ); Mon, 3 Apr 2023 13:57:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232705AbjDCR5D (ORCPT ); Mon, 3 Apr 2023 13:57:03 -0400 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CAC72134; Mon, 3 Apr 2023 10:56:58 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 994395C0050; Mon, 3 Apr 2023 13:56:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 03 Apr 2023 13:56:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ryhl.io; h=cc:cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1680544617; x=1680631017; bh=8RIO0uCEvz64g3NovXvBT0P64254DQg2kzJ W/e/1H9A=; b=jSKHpUw6brenmYW3Gb7aIeWXZkuijj4LRomLcC71oncTnIcL1FD N1Nwf8iX4RPNNxcZ7t1VWwCMLdVDUDIELi441qJIXwf9WkjbeVGtFmcigqC9YMGT cFdogfR8YYARUEwFgUW02SHwIzEXTPn8Y1Q+G/+yBXLURzp5ckdSE54CWrNQfOdW MNhJwJiqy95Th1xgPdgzC6hPUBhT/evth83okCu+DoMOPVOy+otJXkv60fyICJzx yQW7nTxMHPXqiEGz8+rAwEvVLVi1DGINJkr+tcyN1XcKzOhSm4zIOr6QU58NtlZE /weEv6+klXcXvQg+up/phQJyzzsTneW8+Ug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1680544617; x=1680631017; bh=8RIO0uCEvz64g3NovXvBT0P64254DQg2kzJ W/e/1H9A=; b=UYj9CGd0OnGazN/2vnUvxW+90loTPEZwp+b06GWOmSKdD+E7ZIl A4rea3i9vbpPYmW2q4dhdgerVe8af1ZXPMPHY9/BSSKr7/535EPFKTDGJdesvCkP Ho1SZlYsqr8l9T9k7rU3Q8cX1gIR0CydKja3xnteUBgpzMqKIoQ11/sC0OZPug1m o6IddIlSN/vMzvSVmidHbG7Th3/k9sWs4gvK3p18Pt9clheZk57LToXvHNhyE9ts upmPk2KaHx2aFJ+nUofZ9vZqNiKClA1Mk8pPGdOnRYgzvVNTrKZy6I7l07Gxhxw0 KqXsXhhbgFbQw7EzcXFqEYHu3O6xqFfCvDg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeijedguddvtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfhuffvvehfjggtgfesthejredttdefjeenucfhrhhomheptehl ihgtvgcutfihhhhluceorghlihgtvgesrhihhhhlrdhioheqnecuggftrfgrthhtvghrnh ephfehueeileevjeefkeetvdffveffudeuhffgtedvuefgiefgiedvjeegvdejleejnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlihgtvg esrhihhhhlrdhioh X-ME-Proxy: Feedback-ID: i56684263:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 3 Apr 2023 13:56:54 -0400 (EDT) Message-ID: Date: Mon, 3 Apr 2023 19:56:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Alice Ryhl Subject: Re: [PATCH v5 03/15] rust: sync: change error type of constructor functions To: Benno Lossin Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andreas Hindborg , Alice Ryhl , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=c3=b6rn_Roy_Baron?= References: <20230403154422.168633-1-y86-dev@protonmail.com> <20230403154422.168633-4-y86-dev@protonmail.com> Content-Language: en-US In-Reply-To: <20230403154422.168633-4-y86-dev@protonmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: rust-for-linux@vger.kernel.org On 4/3/23 17:44, Benno Lossin wrote: > Change the error type of the constructors of `Arc` and `UniqueArc` to be > `AllocError` instead of `Error`. This makes the API more clear as to > what can go wrong when calling `try_new` or its variants. > > Signed-off-by: Benno Lossin > Reviewed-by: Andreas Hindborg > Cc: Gary Guo > Cc: Alice Ryhl Reviewed-by: Alice Ryhl