From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E3A42E413; Tue, 16 Dec 2025 09:13:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765876393; cv=none; b=bIiaZTXvjqcNDIAdq9edd1UF3vXP8RQ2+ORG4lkC/O4iQyB0GWl/IkSD/iU8GSCQMEo9Mk6k1CFPKx6sq9WO6JBasOpbS4RcTi613kXKZFYAhVIg2DIuH4zru0d5+uZb6Iw+sJ/YXe1TXb425+Pv6M0TtxKtBm16V8hLi4wuA7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765876393; c=relaxed/simple; bh=+bQXQluU40rX6u2ZXNQ5SqKPtFENGuQAWMbyvBYnupc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Exy/IJ9XGg8xYJqwonsBcFTwgjf0p3a19foBf7LQ6NsCcEL8FXwbuCUc3twpSh37qNJjUm36/I2Qzxi8Xj6dYfpYx5m5keHG5m45odoq3islRureKdwlelEGarLSvhyQ9BDYbUixqIccPVLyYQEYkIE8dlRrVWrpav7OC+P6wvM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RWVN9lwe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RWVN9lwe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99F22C4CEF1; Tue, 16 Dec 2025 09:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765876393; bh=+bQXQluU40rX6u2ZXNQ5SqKPtFENGuQAWMbyvBYnupc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RWVN9lweHnBibbTiKH7eLyr6F6YQAgadzFt5KOeUqNbokkf3/zZr09wicU0Tpx4aK e0fAXOB8skaJUk+8A8HKsf9F0IgQV9Jl275MTRBVfqKuBh8Ys3j5VvGoNpQcaoNIYK iDAEWs6wlm+BPD2Du5c3fZfeCVgx4I6rihk9oeniDxHhc4Fmp0qgRwA6dWn5zZ0Gxm DneRAcEMTt8gz2HrcYLtnPrUsa0ygJVgX6U/pDEdOLzbmikw+UtvtLpifm9zG7BDao lpv/L6rGJhDUD/LujpTS7P5e5ahnVtnPu5HdlqUZg/RQKKFiEqYPSB/fG+RNUYrPHO YRMh6WwA/FX6Q== Message-ID: Date: Tue, 16 Dec 2025 10:13:08 +0100 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: Provide pci_free_irq_vectors() for CONFIG_PCI=n To: Boqun Feng , Bjorn Helgaas Cc: Miguel Ojeda , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Joel Fernandes , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org References: <20251215025444.65544-1-boqun.feng@gmail.com> From: Danilo Krummrich Content-Language: en-US In-Reply-To: <20251215025444.65544-1-boqun.feng@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/15/25 3:54 AM, Boqun Feng wrote: > Commit 473b9f331718 ("rust: pci: fix build failure when CONFIG_PCI_MSI > is disabled") fixed a build error by providing rust helpers when > CONFIG_PCI_MSI=n. However the rust helpers rely on the > pci_alloc_irq_vectors() function is defined, which is not true when > CONFIG_PCI=n. There are multiple ways to fix this, e.g. a possible fix > could be just remove the calling of pci_alloc_irq_vectors() since it's > empty when CONFIG_PCI_MSI=n anyway. However, since PCI irq APIs, such as > pci_alloc_irq_vectors(), are already defined even when CONFIG_PCI=n, the > more reasonable fix is to define pci_alloc_irq_vectors() when > CONFIG_PCI=n and this aligns with the situations of other primitives as > well. > > Fixes: 473b9f331718 ("rust: pci: fix build failure when CONFIG_PCI_MSI is disabled") > Signed-off-by: Boqun Feng Reviewed-by: Danilo Krummrich Bjorn, I assume you will pick this up? Otherwise I can pick it up as well, I will likely send a -fixes PR for -rc2 anyways.