From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C367C101E6; Sat, 22 Feb 2025 06:04:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740204264; cv=none; b=t1QP3kN31Udki0s1HApeciY9biNLtVelF9qZQ4Kr2Mv34WACrcIaodcN6KnWyx0QEQ/L6GnSK/vm+8bo1cCfzlrG8xHgK542GPWv5dXz4KOkJE7+JLIAqocMHIpChnudbm5sJZaHiObxi79wthBEMQ2+7XeWFvSxmcCZF+aSDLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740204264; c=relaxed/simple; bh=duzOIBj+WvWSqYXc4UWBI/jJcPgeKRT2xWPYPWTrPz8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=NKi9UQNW5+61wZeJxiBvSb6BQiGAiwJhUcE0+oqT/TNzdqOFxWtnqH2+FSsv+5XNQIZOdgNTLw/rQW11DwL8ZkEHKRXVvsobELzny6zn3oIyLYrQVxz3FFPHh/GEmaTskrtmVAFGj/d0WHMJCxaQKYahtO5sDEG1U58CSVdW5II= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=buRjWkec; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="buRjWkec" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91617C4CED1; Sat, 22 Feb 2025 06:04:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740204264; bh=duzOIBj+WvWSqYXc4UWBI/jJcPgeKRT2xWPYPWTrPz8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=buRjWkecRfA2bXqvU/V1obcs/SoMhlXySQKVDmRHT1CKGOBdYhfe2jRRglAR8arvv jS5dSXRLUnErU9Mv3kbnk8JbAbiB9tgng85F0F6OKmtDhHFe1IF4aeyzKRvlW2QT38 KUH6pXZU8eF5pYo3FkGgQx3M9m8zZymnYfg9HypHd1y6couAn2oVjfCqHBOh5FT6aL QM/LfX0Ulhoxp0yZTeVn8YwBGQ/CfR6At9yxKDZM94CSXcWir65tYbqg5RQer5nSvA p2qoyKsD0Qxm/6XpYP10EvMNPm/lhyIcyHeNP9fhXOT+WgD7r/XTC22SPYHJDLNhiI /sLqPFNdeYXWA== Message-ID: Subject: Re: [PATCH] rust: workqueue: define built-in bh queues From: Jarkko Sakkinen To: Boqun Feng Cc: Miguel Ojeda , Hamza Mahfooz , Tejun Heo , Lai Jiangshan , rust-for-linux@vger.kernel.org, Miguel Ojeda , Alex Gaynor , Gary Guo , =?ISO-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Wedson Almeida Filho , Nell Shamrell-Harrington , Dirk Behme , Konstantin Andrikopoulos , Danilo Krummrich , Roland Xu , linux-kernel@vger.kernel.org Date: Sat, 22 Feb 2025 08:04:19 +0200 In-Reply-To: References: <20250221223533.158959-1-hamzamahfooz@linux.microsoft.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2025-02-21 at 20:41 -0800, Boqun Feng wrote: > On Sat, Feb 22, 2025 at 06:37:06AM +0200, Jarkko Sakkinen wrote: > > On Sat, Feb 22, 2025 at 06:17:41AM +0200, Jarkko Sakkinen wrote: > > > On Fri, Feb 21, 2025 at 11:45:38PM +0100, Miguel Ojeda wrote: > > > > On Fri, Feb 21, 2025 at 11:36=E2=80=AFPM Hamza Mahfooz > > > > wrote: > > > > >=20 > > > > > We provide these methods because it lets us access these > > > > > queues from > > > > > Rust without using unsafe code. > > > > >=20 > > > > > Signed-off-by: Hamza Mahfooz > > > > > > > > >=20 > > > > Cc'ing WORKQUEUE -- thanks! > > >=20 > > > Not meaning to complain but it by practical has no commit > > > message. > >=20 > > oops, sorry, "... but by practical means it ..." > >=20 > > Anyway I hope my message was received ;-) Leaves me wonder tho why > > this was queued because it apparently is not even part of a patch >=20 > What do you mean by "queued"? IIUC, Miguel was just copying workqueue > maintainers, since they should be in the review process. >=20 > Thanks for your review in another email anyway! Ah sorry! I have dyslexia (for real) and I did read that the patch was queued :-) Thanks for correcting and please do also the next time! I spent also last 48h awake setting up my personal Rust development and QA environment... [1] Anyway, to soften my feedback a bit I'll say this: everything else was great: 1. Code was great 2. It was commented like you'd expect. And I don't have much to complain about code quality in any other patches I've seen so far. I've been silently following this list for some time and this is a common problem that the commit messages are quite bad. Thus, I even wrote a public post about the topic now that I had this in mind: https://social.kernel.org/notice/ArMk27Ism4Citb90K0 There's two great arguments to improve across the board: 1. Education 2. Integrity. E.g. AI is actually acceptable for short a patch, if you can in detail unmask the implementation (as is e.g. Windows notepad or really anything that produces text). But AI can be also used to engineer harmless looking changes that are actually vulns. By being punctual in expalanations we also contribute to the=20 governance of our ecosystem. I'm personally reading this list exactly for learning purposes because I have a roadmap to Rust driver ongoing, and explanations even in trivial things help to gather bits and pieces... So please help me to succeed by doing just a tiny bit more effort ;-) > Regards, > Boqun [1] https://codeberg.org/jarkko/linux-tpmdd-nixos BR, Jarkko