[PATCH] rust: printing macros sample: add missing newlines

[PATCH] rust: printing macros sample: add missing newlines

[albankurti]

Fixes calls to pr_*! to include \n

Reported-by: ojeda <ojeda@kernel.org>
Closes: https://github.com/Rust-for-Linux/linux/issues/1139
Signed-off-by: albankurti <kurti@invicto.ai>
---
 samples/rust/rust_print_main.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/samples/rust/rust_print_main.rs b/samples/rust/rust_print_main.rs
index 7e8af5f176a3..7ef3cecc65a1 100644
--- a/samples/rust/rust_print_main.rs
+++ b/samples/rust/rust_print_main.rs
@@ -23,10 +23,10 @@ fn arc_print() -> Result {
     let b = UniqueArc::new("hello, world", GFP_KERNEL)?;
 
     // Prints the value of data in `a`.
-    pr_info!("{}", a);
+    pr_info!("{}\n", a);
 
     // Uses ":?" to print debug fmt of `b`.
-    pr_info!("{:?}", b);
+    pr_info!("{:?}\n", b);
 
     let a: Arc<&str> = b.into();
     let c = a.clone();
@@ -42,7 +42,7 @@ fn arc_print() -> Result {
 
         use core::fmt::Display;
         fn arc_dyn_print(arc: &Arc<dyn Display>) {
-            pr_info!("Arc<dyn Display> says {arc}");
+            pr_info!("Arc<dyn Display> says {arc}\n");
         }
 
         let a_i32_display: Arc<dyn Display> = Arc::new(42i32, GFP_KERNEL)?;
@@ -53,7 +53,7 @@ fn arc_dyn_print(arc: &Arc<dyn Display>) {
     }
 
     // Pretty-prints the debug formatting with lower-case hexadecimal integers.
-    pr_info!("{:#x?}", a);
+    pr_info!("{:#x?}\n", a);
 
     Ok(())
 }
-- 
2.48.1

Re: [PATCH] rust: printing macros sample: add missing newlines

[Charalampos Mitrodimas]

albankurti <kurti@invicto.ai> writes:

> Fixes calls to pr_*! to include \n
>
> Reported-by: ojeda <ojeda@kernel.org>
> Closes: https://github.com/Rust-for-Linux/linux/issues/1139
> Signed-off-by: albankurti <kurti@invicto.ai>
> ---
>  samples/rust/rust_print_main.rs | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/samples/rust/rust_print_main.rs b/samples/rust/rust_print_main.rs
> index 7e8af5f176a3..7ef3cecc65a1 100644
> --- a/samples/rust/rust_print_main.rs
> +++ b/samples/rust/rust_print_main.rs
> @@ -23,10 +23,10 @@ fn arc_print() -> Result {
>      let b = UniqueArc::new("hello, world", GFP_KERNEL)?;
>  
>      // Prints the value of data in `a`.
> -    pr_info!("{}", a);
> +    pr_info!("{}\n", a);
>  
>      // Uses ":?" to print debug fmt of `b`.
> -    pr_info!("{:?}", b);
> +    pr_info!("{:?}\n", b);
>  
>      let a: Arc<&str> = b.into();
>      let c = a.clone();
> @@ -42,7 +42,7 @@ fn arc_print() -> Result {
>  
>          use core::fmt::Display;
>          fn arc_dyn_print(arc: &Arc<dyn Display>) {
> -            pr_info!("Arc<dyn Display> says {arc}");
> +            pr_info!("Arc<dyn Display> says {arc}\n");
>          }
>  
>          let a_i32_display: Arc<dyn Display> = Arc::new(42i32, GFP_KERNEL)?;
> @@ -53,7 +53,7 @@ fn arc_dyn_print(arc: &Arc<dyn Display>) {
>      }
>  
>      // Pretty-prints the debug formatting with lower-case hexadecimal integers.
> -    pr_info!("{:#x?}", a);
> +    pr_info!("{:#x?}\n", a);
>  
>      Ok(())
>  }

Hi Alban,

We also have these, but not sure if we care about them, since they are
comments.

  rust/kernel/print.rs
  408:/// pr_info!("hello");

  rust/kernel/init.rs
  885:    ///         pr_info!("Setting up foo");
  989:    ///         pr_info!("Setting up foo");
  1339:///         pr_info!("Foo is being dropped!");

  rust/kernel/init/macros.rs
  48://!         pr_info!("{self:p} is getting dropped.");
  415://!         pr_info!("{self:p} is getting dropped.");
  426://!         pr_info!("{self:p} is getting dropped.");

Otherwise,
Reviewed-by: Charalampos Mitrodimas <charmitro.posteo.net>

Re: [PATCH] rust: printing macros sample: add missing newlines

[Miguel Ojeda]

On Mon, Feb 3, 2025 at 10:38 PM Charalampos Mitrodimas
<charmitro@posteo.net> wrote:
>
> We also have these, but not sure if we care about them, since they are
> comments.

Yeah, we care about those -- albankurti: please fix all across the
tree if possible.

Thanks!

Cheers,
Miguel

Re: [PATCH] rust: printing macros sample: add missing newlines

[Miguel Ojeda]

On Mon, Feb 3, 2025 at 2:37 PM albankurti <kurti@invicto.ai> wrote:
>
> Signed-off-by: albankurti <kurti@invicto.ai>

The kernel requires a "known identity" for signatures. For instance,
the name you use to sign documents in real life. Please let us know if
that is a problem -- see:

    https://docs.kernel.org/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

Cheers,
Miguel