From: SeongJae Park <sj@kernel.org>
To: SeongJae Park <sj@kernel.org>
Cc: damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, sashiko@lists.linux.dev
Subject: Re: (sashiko review) [RFC PATCH v5.2 07/11] Docs/ABI/damon: document fail_charge_{num,denom}
Date: Sun, 12 Apr 2026 11:10:20 -0700 [thread overview]
Message-ID: <20260412181021.84296-1-sj@kernel.org> (raw)
In-Reply-To: <20260412161957.82835-8-sj@kernel.org>
TL; DR: Sashiko found no issue but hallucinated.
Forwarding full sashiko review in a reply format with my inline comments below,
for sharing details of my view and doing followup discussions via mails if
needed.
> # review url: https://sashiko.dev/#/patchset/20260412161957.82835-8-sj@kernel.org
> # start of sashiko.dev inline review
> commit 4091d558c881126aba4445ec7fa5033266c62c55
> Author: SeongJae Park <sj@kernel.org>
>
> Docs/ABI/damon: document fail_charge_{num,denom}
>
> Update DAMON ABI document for the DAMOS action failed regions quota
> charge ratio control sysfs files.
>
> > diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > index 2424237ebb105..213eb87392d88 100644
> > --- a/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > +++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > @@ -322,6 +322,18 @@ Contact: SeongJae Park <sj@kernel.org>
> > Description: Writing to and reading from this file sets and gets the
> > goal-based effective quota auto-tuning algorithm to use.
> >
> > +What: /sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/quotas/fail_charge_num
> > +Date: Mar 2026
>
> This isn't a bug, but is the year 2026 a typo?
Apparently a hallucination of Sashiko.
>
> > +Contact: SeongJae Park <sj@kernel.org>
> > +Description: Writing to and reading from this file sets and gets the
> > + action-failed memory quota charging ratio numerator.
> > +
> > +What: /sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/quotas/fail_charge_denom
> > +Date: Mar 2026
>
> Is the year a typo here as well?
Ditto.
>
> > +Contact: SeongJae Park <sj@kernel.org>
> > +Description: Writing to and reading from this file sets and gets the
> > + action-failed memory quota charging ratio denominator.
>
>
> # end of sashiko.dev inline review
> # review url: https://sashiko.dev/#/patchset/20260412161957.82835-8-sj@kernel.org
Thanks,
SJ
# hkml [1] generated a draft of this mail. You can regenerate
# this using below command:
#
# hkml patch sashiko_dev --for_forwarding \
# 20260412161957.82835-8-sj@kernel.org
#
# [1] https://github.com/sjp38/hackermail
parent reply other threads:[~2026-04-12 18:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20260412161957.82835-8-sj@kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260412181021.84296-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox