From: Rob Herring <robh@kernel.org>
To: Bui Duc Phuc <phucduc.bui@gmail.com>
Cc: sashiko@lists.linux.dev, devicetree@vger.kernel.org,
wsa+renesas@sang-engineering.com, krzk+dt@kernel.org,
conor+dt@kernel.org, Geert Uytterhoeven <geert@linux-m68k.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH v3 01/10] ASoC: dt-bindings: renesas,fsi: add support multiple clocks
Date: Thu, 14 May 2026 10:17:18 -0500 [thread overview]
Message-ID: <20260514151718.GA505743-robh@kernel.org> (raw)
In-Reply-To: <CAABR9nEhOTz1-0NmCMTbz=-+782Pto0yovSQhBXrXqhLwMg80Q@mail.gmail.com>
On Tue, May 12, 2026 at 01:42:06PM +0700, Bui Duc Phuc wrote:
> Hi all,
>
> Based on the Sashiko AI review, I am thinking of adding the following
> constraints specifically for renesas,fsi2-r8a7740 to address the
> reported issues.
>
> I think this may also help balance both Geert's and Krzysztof's
> comments from the previous v2 review.
>
> Does this approach look reasonable to you?
>
> ---------------------------------------------
>
> -allOf:
> - - $ref: dai-common.yaml#
> -
> properties:
> $nodename:
> pattern: "^sound@.*"
> @@ -94,6 +91,78 @@ required:
>
> unevaluatedProperties: false
>
> +allOf:
> + - $ref: dai-common.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,fsi2-r8a7740
> + then:
> + properties:
> + clock-names:
> + oneOf:
> + - items: # FSIA & FSIB is slave
> + - const: fck
> + - const: spu
> + - items: # FSIA slave & FSIB master use internal clock
> + - const: fck
> + - const: spu
> + - const: ickb
> + - const: divb
> + - items: # FSIA slave & FSIB master use external clock
> + - const: fck
> + - const: spu
> + - const: ickb
> + - const: xckb
> + - items: # FSIB slave & FSIA master use internal clock
> + - const: fck
> + - const: spu
> + - const: icka
> + - const: diva
> + - items: # FSIB slave & FSIA master use external clock
> + - const: fck
> + - const: spu
> + - const: icka
> + - const: xcka
> + - items: # FSIA master ex-clk & FSIB master ex-clk
> + - const: fck
> + - const: spu
> + - const: icka
> + - const: xcka
> + - const: ickb
> + - const: xckb
> + - items: # FSIA master in-xlk & FSIB master in-clk
> + - const: fck
> + - const: spu
> + - const: icka
> + - const: diva
> + - const: ickb
> + - const: divb
> + - items: # FSIA master in-clk & FSIB master ex-clk
> + - const: fck
> + - const: spu
> + - const: icka
> + - const: diva
> + - const: ickb
> + - const: xckb
> + - items: # FSIA master ex-clk & FSIB master in-clk
> + - const: fck
> + - const: spu
> + - const: icka
> + - const: xcka
> + - const: ickb
> + - const: divb
> + - items: # FSIA & FSIB full clock support
> + - const: fck
> + - const: spu
> + - const: icka
> + - const: xcka
> + - const: diva
> + - const: ickb
> + - const: xckb
> + - const: divb
Between this and just giving up on enforcing an order, I pick the
latter.
Rob
prev parent reply other threads:[~2026-05-14 15:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260510084303.122426-2-phucduc.bui@gmail.com>
[not found] ` <20260511204528.14632C2BCB0@smtp.kernel.org>
2026-05-12 6:42 ` [PATCH v3 01/10] ASoC: dt-bindings: renesas,fsi: add support multiple clocks Bui Duc Phuc
2026-05-14 15:17 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514151718.GA505743-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=phucduc.bui@gmail.com \
--cc=sashiko@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox