Sashiko discussions
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Roman Gushchin <roman.gushchin@linux.dev>
Cc: "Chris Mason" <mason@kernel.org>,
	sashiko@lists.linux.dev, ihor.solodrai@linux.dev, ast@kernel.org
Subject: Re: [RFC] reworking the review-prompts subsystem guide
Date: Mon, 5 Oct 2026 14:53:08 -0700	[thread overview]
Message-ID: <20261005145308.47949c6d@kernel.org> (raw)
In-Reply-To: <7ia4y0cbsvdn.fsf@castle.c.googlers.com>

On Mon, 05 Oct 2026 21:14:12 +0000 Roman Gushchin wrote:
> I plan to do this (and had a prototype in the past), but it's tricky if
> we take security seriously. And we absolutely should!
> Obviously just giving an agent an access to lore archive is opening a
> can of worms in terms of possible prompt injections. So I think we
> should do it really carefully.

Hm, is there really much extra attack surface here beyond what people
can already put in a commit message of a fake patch?

> And outside of security considerations,
> humans are simple wrong too. So my plan with sashiko is to force it to
> try to verify the feedback against the codebase and if it's not possible
> trust only maintainers or people with a long history of meaningful
> contributions.

Definitely, I was also wondering about doing some rough estimate
of "trustworthiness" of the person based on how long they have been
contributing + MAINTAINERS status. In practice, tho, noobs rarely
provide feedback. Closing the loop with patchwork is a better idea
(if patch go rejected == maintainer must have judged some feedback
as important)

> And sashiko can (and does in my prototype) generate prompts based on the
> feedback and automatically verify that it helps by re-reviewing original
> patches. This should mostly eliminate a need for human-generated
> prompts.
> This is all doable, but probably will take few more week to build and
> roll out.

  reply	other threads:[~2026-10-05 21:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 19:04 [RFC] reworking the review-prompts subsystem guide Chris Mason
2026-10-02 21:18 ` Chuck Lever
2026-10-04  9:17   ` Chris Mason
2026-10-05 19:58 ` Jakub Kicinski
2026-10-05 21:14   ` Roman Gushchin
2026-10-05 21:53     ` Jakub Kicinski [this message]
2026-10-05 23:37     ` Ihor Solodrai
2026-10-06 21:22 ` Ihor Solodrai
2026-10-07  9:00   ` Chris Mason
2026-10-23 19:27   ` Ihor Solodrai
2026-10-23 20:22     ` Roman Gushchin
2026-10-23 21:26       ` Ihor Solodrai
2026-10-09 14:17 ` Fuad Tabba
2026-10-09 17:57   ` Chris Mason
2026-10-10 15:53     ` Fuad Tabba
2026-10-12 15:14       ` Fuad Tabba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261005145308.47949c6d@kernel.org \
    --to=kuba@kernel.org \
    --cc=ast@kernel.org \
    --cc=ihor.solodrai@linux.dev \
    --cc=mason@kernel.org \
    --cc=roman.gushchin@linux.dev \
    --cc=sashiko@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox