Sashiko discussions
 help / color / mirror / Atom feed
From: "Theodore Tso" <tytso@mit.edu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mark Brown <broonie@kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Bart Van Assche <bvanassche@acm.org>,
	johannes.goede@oss.qualcomm.com, Jiri Kosina <jikos@kernel.org>,
	ksummit@lists.linux.dev, sashiko@lists.linux.dev
Subject: Re: Patch pre-submission to Sashiko
Date: Wed, 21 Oct 2026 15:56:40 -0400	[thread overview]
Message-ID: <atkX3WwwV8XhMRiM@mit.edu> (raw)
In-Reply-To: <20261021114524.4c2ea2a31a9d527b78e78768@linux-foundation.org>

On Wed, Oct 21, 2026 at 11:45:24AM -0500, Andrew Morton wrote:
> 
> If someone's fixing something I don't see much value in
> retaining/maintaining a test case for something we've already fixed. 
> This is considered good engineering practice but why bother - we fixed
> it!  Move on.

It's considered good engineering practice because regularly running
the test allows regresssions to be detected, and by increasing test
coverage, it makes life easier to feel confident that a future code
change, or rebase, is ultimately correct.

Of course, you need to do the cost/benefit tradeoff.  If the test
takes a very long time to run, or if maintaining it requires a huge
amount of code outside of the test, then it could be that the benefits
aren't worth the on-going costs of keeping the test around.

This is one of the reasons why I'm a big fan of unit testing.  The
unit tests tend to run much more quickly than integration-style tests.

     	   	       	    	 - Ted

  parent reply	other threads:[~2026-10-21 19:58 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-17 17:28 Patch pre-submission to Sashiko Jiri Kosina
2026-10-17 18:02 ` Theodore Tso
2026-10-19 11:02   ` johannes.goede
2026-10-19 20:27     ` Theodore Tso
2026-10-20 14:20       ` Bart Van Assche
2026-10-20 19:21         ` Theodore Tso
2026-10-20 20:15           ` Miguel Ojeda
2026-10-20 20:43           ` Shuah Khan
2026-10-21 11:07             ` Mark Brown
2026-10-21 16:20               ` Theodore Tso
2026-10-21 16:33                 ` Mark Brown
2026-10-21 18:45                   ` Andrew Morton
2026-10-21 19:15                     ` Rafael J. Wysocki (Intel)
2026-10-21 19:56                     ` Theodore Tso [this message]
2026-10-21 20:10                     ` Jiri Kosina
2026-10-21 20:24                       ` Steven Rostedt
2026-10-21 20:46                     ` Paul E. McKenney
2026-10-22  6:15                     ` Dan Carpenter
2026-10-17 18:20 ` Alexei Starovoitov
2026-10-17 18:38   ` Arnaldo Melo
2026-10-19  7:02     ` Dan Carpenter
2026-10-18 11:46   ` Mark Brown
2026-10-17 18:20 ` Linus Torvalds
2026-10-17 20:10   ` Roman Gushchin
2026-10-18 13:41     ` Steven Rostedt
2026-10-18 18:41     ` Kees Cook
2026-10-18 18:58       ` Linus Torvalds
2026-10-19  5:55   ` Oliver Slapinski
2026-10-17 19:42 ` Andrew Lunn
2026-10-18 11:54   ` Mark Brown
2026-10-18 16:48     ` Laurent Pinchart
2026-10-19  6:25 ` Krzysztof Kozlowski
2026-10-19  7:26   ` David Woodhouse
2026-10-19 11:40     ` Michal Simek
2026-10-19 12:02       ` Julia Lawall
2026-10-19 12:46         ` Michal Simek
2026-10-19 12:57           ` Julia Lawall
2026-10-19 17:30             ` Rodrigo Vivi
2026-10-19 17:53   ` Shuah Khan
2026-10-19 18:17     ` Arnaldo Melo
2026-10-19 20:35     ` Theodore Tso
2026-10-20  2:28       ` Chen-Yu Tsai
2026-10-20  8:36       ` Jiri Kosina
2026-10-20  8:48         ` Vlastimil Babka (SUSE)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atkX3WwwV8XhMRiM@mit.edu \
    --to=tytso@mit.edu \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=bvanassche@acm.org \
    --cc=jikos@kernel.org \
    --cc=johannes.goede@oss.qualcomm.com \
    --cc=ksummit@lists.linux.dev \
    --cc=sashiko@lists.linux.dev \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox