From: Tejun Heo <tj@kernel.org>
To: luoliang@kylinos.cn
Cc: David Vernet <void@manifault.com>,
Andrea Righi <arighi@nvidia.com>,
Changwoo Min <changwoo@igalia.com>,
Emil Tsalapatis <emil@etsalapatis.com>,
sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Docs/admin-guide/cgroup-v2: document BPF scheduler callbacks for cpu.max and cpu.idle
Date: Wed, 19 Aug 2026 10:08:32 -1000 [thread overview]
Message-ID: <05fa2ecdf1468ca7454244941343626f@kernel.org> (raw)
In-Reply-To: <20260819031244.178638-2-luoliang@kylinos.cn>
Hello,
On Wed, Aug 19, 2026 at 11:12:43AM +0800, luoliang@kylinos.cn wrote:
> - This file affects only processes under the fair-class scheduler.
> + This file affects only processes under the fair-class scheduler and a BPF
> + scheduler with the ``cgroup_set_bandwidth`` callback depending on what
> + the callback actually does.
The "CPU Interface Files" preamble defines the categories that the
interface file entries refer back to and it only knows about
cgroup_set_weight:
* Processes under the fair-class scheduler
* Processes under a BPF scheduler with the ``cgroup_set_weight`` callback
* Everything else: ``SCHED_{FIFO,RR,DEADLINE}`` and processes under a BPF
scheduler without the ``cgroup_set_weight`` callback
With cpu.max, cpu.max.burst and cpu.idle now referring to
cgroup_set_bandwidth and cgroup_set_idle, the preamble no longer covers
the entries that follow it. Can you please update the preamble to match,
e.g. by making the bullets refer to the corresponding cgroup_set_*
callback, and resend?
Thanks.
--
tejun
next prev parent reply other threads:[~2026-08-19 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 3:12 [PATCH 0/2] sched_ext: documentation fixes luoliang
2026-08-19 3:12 ` [PATCH 1/2] Docs/admin-guide/cgroup-v2: document BPF scheduler callbacks for cpu.max and cpu.idle luoliang
2026-08-19 20:08 ` Tejun Heo [this message]
2026-08-20 2:01 ` luoliang
2026-08-20 2:37 ` [PATCH v2] " luoliang
2026-08-19 3:12 ` [PATCH 2/2] sched_ext: Fix nonexistent field in sched-ext.rst example luoliang
2026-08-19 20:08 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05fa2ecdf1468ca7454244941343626f@kernel.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=emil@etsalapatis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luoliang@kylinos.cn \
--cc=sched-ext@lists.linux.dev \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox