From: Tejun Heo <tj@kernel.org>
To: Andrea Righi <arighi@nvidia.com>
Cc: David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
Emil Tsalapatis <emil@etsalapatis.com>,
sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 sched_ext/for-7.4] sched_ext: Queue the kick_sync wait from set_next_task_scx()
Date: Mon, 19 Oct 2026 14:27:03 -1000 [thread overview]
Message-ID: <08cac02c604dd73ef96fc92eb29d692b@kernel.org> (raw)
In-Reply-To: <20261018162415.55913-1-arighi@nvidia.com>
Applied to sched_ext/for-7.4-fixes.
A few follow-ups:
- With proxy exec, __schedule() can call set_next_task() twice on a
repicked donor (SNT_REPICK, then SNT_PICK), which queues
kick_sync_bal_cb twice. When it's alone on the list, it ends up linked
to itself and the wait runs twice.
- The foreign CPU check in kick_sync_wait_bal_cb() looks unreachable now.
- Not from this patch, but maybe_queue_balance_callback() clears
SCX_RQ_BAL_CB_PENDING when queueing, so a proxy exec zap leaves the
deferred work unscheduled until the next wakeup or deferred request on
the CPU.
Thanks.
--
tejun
prev parent reply other threads:[~2026-10-20 0:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 16:24 [PATCH v2 sched_ext/for-7.4] sched_ext: Queue the kick_sync wait from set_next_task_scx() Andrea Righi
2026-10-20 0:27 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08cac02c604dd73ef96fc92eb29d692b@kernel.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=emil@etsalapatis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox