Sched_ext development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Cheng-Yang Chou" <yphbchou0911@gmail.com>
Cc: sched-ext@lists.linux.dev
Subject: Re: [PATCH v2 2/2] sched_ext: Fix exit_cpu accuracy for lockup paths
Date: Mon, 04 May 2026 19:07:14 +0000	[thread overview]
Message-ID: <20260504190715.E694FC2BCF4@smtp.kernel.org> (raw)
In-Reply-To: <20260504161543.674488-3-yphbchou0911@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] synchronize_rcu_expedited_wait() incorrectly passes the detector CPU instead of the stalled CPU or -1 to panic_on_rcu_stall().
--

commit be51680372265a1376da290cd206c8c990bc5343
Author: Cheng-Yang Chou <yphbchou0911@gmail.com>

sched_ext: Fix exit_cpu accuracy for lockup paths

This commit updates lockup detection paths to pass the actually stalled CPU,
rather than the CPU executing the detection code, to handle_lockup(). It
modifies scx_hardlockup_irq_workfn(), scx_rcu_cpu_stall(), and
panic_on_rcu_stall() to accept the stalled CPU as an argument.

[ ... ]

> diff --git a/kernel/rcu/tree_exp.h b/kernel/rcu/tree_exp.h
> index 82cada459e5d0..fa83e273a6487 100644
> --- a/kernel/rcu/tree_exp.h
> +++ b/kernel/rcu/tree_exp.h
> @@ -675,7 +675,7 @@ static void synchronize_rcu_expedited_wait(void)
>  
>  		nbcon_cpu_emergency_exit();
>  
> -		panic_on_rcu_stall();
> +		panic_on_rcu_stall(raw_smp_processor_id());

The commit message states that recording the detector CPU rather than the
stalled CPU is wrong.

However, in synchronize_rcu_expedited_wait(), it appears raw_smp_processor_id()
represents the CPU waiting for the expedited grace period (the detector CPU),
not necessarily the CPU that is stalled.

Does passing raw_smp_processor_id() here contradict the patch's stated goal
by incorrectly blaming the detecting CPU? If identifying a specific stalled
CPU is difficult in this path, would it be more appropriate to pass -1 to
indicate no specific CPU is targeted?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260504161543.674488-1-yphbchou0911@gmail.com?part=2

  reply	other threads:[~2026-05-04 19:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 16:08 [PATCH v2 sched_ext/for-7.2 0/2] sched_ext: Follow-up fixes for exit_cpu accuracy Cheng-Yang Chou
2026-05-04 16:08 ` [PATCH v2 1/2] sched_ext: Normalize exit dump header to "on CPU N" Cheng-Yang Chou
2026-05-04 16:08 ` [PATCH v2 2/2] sched_ext: Fix exit_cpu accuracy for lockup paths Cheng-Yang Chou
2026-05-04 19:07   ` sashiko-bot [this message]
2026-05-05  0:59   ` Tejun Heo
2026-05-05  3:44   ` Paul E. McKenney
2026-05-05  8:20     ` Cheng-Yang Chou
2026-05-05  8:34       ` Tejun Heo
2026-05-06 10:18         ` Cheng-Yang Chou
2026-05-07 21:39           ` Tejun Heo
2026-05-05 15:10       ` Paul E. McKenney
2026-05-06 10:54         ` Cheng-Yang Chou
2026-05-04 21:05 ` [PATCH v2 sched_ext/for-7.2 0/2] sched_ext: Follow-up fixes for exit_cpu accuracy Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260504190715.E694FC2BCF4@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=sashiko@lists.linux.dev \
    --cc=sched-ext@lists.linux.dev \
    --cc=yphbchou0911@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox