From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A700E29B8D0 for ; Fri, 12 Jun 2026 15:38:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781278724; cv=none; b=UelzJF3byX9h+0/6lr6PR7ow9KKQzXEHKxAu/G71Y7cSrCgskppEqHpqeXzqvbbAVEAN25lW38COBq8HFJ65H8IbNNWlnBirBXGs5XjXqfx75XDxDJwfWyWtg+vb456sD3HHn6v3I/9Pyc+L2Bl1PmKB95HcbaS/UHLrBMfOmuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781278724; c=relaxed/simple; bh=ISyqqpDDaZUaLQljjaO6eSo02t9f5l6Qg8Rgm2G1TAU=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=UWSmmO00KhuRvr8zOZk7X2jRw3tRnp8sGjtqJN9+4hfN84Cjug6o+WxhMCo0ABwZvqt4fglzQJ8ya7iWYkwzZID5uf1hstVA/ifXS+6xylf9s5FWsMcFew4yRzzvxojJ3TYXgLK7wKryBOPwfbKDwnHFLd1yFdMDYkeRMi9yC7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=B0jBJwJg; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="B0jBJwJg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 302E81F000E9; Fri, 12 Jun 2026 15:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781278723; bh=wmW+AGc4U/bzYKqKGr9VTcqSKNOTB5amzuLcftMnqEs=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=B0jBJwJgFowfvnXNxfG0dREUnFqSbytT0dNNpGFj11Lei9TTBAfyh8PUA+2bKa3tQ hDrP/64k9At2KE2G6m5kE3Wg7uKGTUsYRbkPtKR5mT6rJuzGoBmr3SXigo3rYRj9eT X5GS798ngnrE+tmJQBhTZlpOkBOKH/+3Tf03B1swi8bFmW2tbAlEBVapqmW4pp6AsQ WA2oorJupTkyzjCEuDWgiIpvsW6j8gklQrVSb9DcZSX5ZJ1NgiKZqyw3TXHYBrKkLw g83u/EN7lnLSdxGmigVBruHN+a/Xo8BxDRpJVlONvgRsHB0dF0mtq1PkVtHH45MV2s j2YpGhZoNixoA== From: sashiko-bot@kernel.org Subject: Re: [PATCH] sched_ext:SCX is preemptible by the Fair scheduler Reply-To: sashiko-reviews@lists.linux.dev To: "Cui Jian" Cc: sched-ext@lists.linux.dev In-Reply-To: <20260612152304.94821-1-cjian720@163.com> References: <20260612152304.94821-1-cjian720@163.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 12 Jun 2026 15:38:42 +0000 Message-Id: <20260612153843.302E81F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: sched-ext@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The autogenerated header enum_defs.autogen.h was not updated to = include HAVE_SCX_CPU_PREEMPT_FAIR. -- commit 6eebc3231d63fa92ff2758fc84fe12b421fbde6c Author: Cui Jian sched_ext:SCX is preemptible by the Fair scheduler This commit adds a new SCX_CPU_PREEMPT_FAIR preempt reason for the sched_ext subsystem. It updates the internal enum and preempt reason mapping to make = it easier to observe when a task is preempted by the Fair scheduler. [ ... ] > diff --git a/kernel/sched/ext_internal.h b/kernel/sched/ext_internal.h > --- a/kernel/sched/ext_internal.h > +++ b/kernel/sched/ext_internal.h > @@ -241,6 +241,8 @@ enum scx_cpu_preempt_reason { > SCX_CPU_PREEMPT_DL, > /* next task is being scheduled by &sched_class_stop */ > SCX_CPU_PREEMPT_STOP, > + /* next task is being scheduled by &sched_class_fair*/ > + SCX_CPU_PREEMPT_FAIR, [Severity: Medium] Should tools/sched_ext/include/scx/enum_defs.autogen.h also be updated in this patch to include HAVE_SCX_CPU_PREEMPT_FAIR? Without adding this to the autogenerated header, external BPF schedulers cannot use #ifdef HAVE_SCX_CPU_PREEMPT_FAIR to safely compile and support both old and new kernels. > /* unknown reason for SCX being preempted */ > SCX_CPU_PREEMPT_UNKNOWN, > }; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260612152304.9482= 1-1-cjian720@163.com?part=3D1