From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62F103ED3AF for ; Fri, 12 Jun 2026 16:28:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781281701; cv=none; b=sylZGZMK/P7bCTJ8pn7oZTAqrACDYvt3yNzHYFJHk0Yws/y5HKylbze54Ov8e3f+ByESNpy0PBbVaKQl5yNYVCoQAZyOfZ1/Z2vEm2Da11uqn84Me8xyPYg5B/BQTHXqDEtbglzU6HHT/9j1VdQvQIHILEvlg/FhcHBMuOFuHTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781281701; c=relaxed/simple; bh=v7p7bImKs9nJDhjXRRTWHx8BdhMVzDw4UXajnokd/U8=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=SyrJvl+Nqom9a42WzPnoBNzlPnhOJZWyFRSBvrtnacXiIj3GAIOK74t7G7LhiuXlNr1Pgz04aycEaWy9VyPoE0I1CBcKeGHcCVAggX4GISeInWM/a1vgRxL7Q3lj/uNqCHNBA77mK5XA8/bqtiKRyzOIlHMwKc0DlOC5CGHZcLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gwwU+Fbm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gwwU+Fbm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9C761F00A3D; Fri, 12 Jun 2026 16:28:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781281698; bh=kjz0NJL/GHsZ0AZoyRoNHZ+JFjF2l9kSnPdJkjpSLCY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=gwwU+Fbm4WC0hfFwhV5I4T29DWoKQ3bDT8FBVumDI6cqbXHxALcKs3t79lgXRgS+7 H/xQKlKFuyckgu5tLuxq9T7hbOFkgc8VGIOBzN3H8x911HsOs9IFQUG6G6xJ6twV34 e+kDCAeZpdDpVOvt6IhQe52x3/BnW5gHIqIxxcPZU8yxm7QYZlZdGboHZbpvziROTQ nBvmJjYeV/YfkoDd3+HFbUpvNYW65L0qXgk2rk8N7UOzV5877mKNnlhYv2IYJPW7ps LILlJ5KQMGLDKj4CechkHhgCyz4bHQdYPFo+rzff6zkiiLP6UFPV3rK8eeI4Gspvtl Mmh5j5wHK1dJg== From: sashiko-bot@kernel.org Subject: Re: [PATCH] sched_ext:SCX is preemptible by the Fair scheduler Reply-To: sashiko-reviews@lists.linux.dev To: "Cui Jian" Cc: sched-ext@lists.linux.dev In-Reply-To: <20260612161403.105775-1-cjian720@163.com> References: <20260612161403.105775-1-cjian720@163.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 12 Jun 2026 16:28:18 +0000 Message-Id: <20260612162818.C9C761F00A3D@smtp.kernel.org> Precedence: bulk X-Mailing-List: sched-ext@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The patch adds `SCX_CPU_PREEMPT_FAIR` to `enum scx_cpu_preempt_r= eason` in `kernel/sched/ext_internal.h`, but fails to update the checked-in= autogenerated BPF tool headers in `tools/sched_ext/include/scx/enum_defs.a= utogen.h`. -- commit 0e9cc05c20430d666c8c1a1d7ea0741d9c28b2d3 Author: Cui Jian sched_ext:SCX is preemptible by the Fair scheduler This commit adds a new preemption reason, SCX_CPU_PREEMPT_FAIR, to distingu= ish when a sched_ext task is preempted by the Fair scheduler. It updates the internal enum and mapping function to improve observability and diagnostics. > diff --git a/kernel/sched/ext_internal.h b/kernel/sched/ext_internal.h > index a075732d4430d..3ce07bec58a55 100644 > --- a/kernel/sched/ext_internal.h > +++ b/kernel/sched/ext_internal.h > @@ -241,6 +241,8 @@ enum scx_cpu_preempt_reason { > SCX_CPU_PREEMPT_DL, > /* next task is being scheduled by &sched_class_stop */ > SCX_CPU_PREEMPT_STOP, > + /* next task is being scheduled by &sched_class_fair*/ > + SCX_CPU_PREEMPT_FAIR, [Severity: Medium] Should tools/sched_ext/include/scx/enum_defs.autogen.h be regenerated and included in this patch? When adding a new value to enum scx_cpu_preempt_reason, the autogenerated BPF tool headers typically need updating so downstream BPF schedulers can use feature detection macros like HAVE_SCX_CPU_PREEMPT_FAIR.=20 Without this update, BPF applications cannot conditionally check for this new preemption feature across different kernel versions. > /* unknown reason for SCX being preempted */ > SCX_CPU_PREEMPT_UNKNOWN, > }; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260612161403.1057= 75-1-cjian720@163.com?part=3D1