Re: [PATCH sched_ext/for-7.2] sched_ext: Move sources under kernel/sched/ext/

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Stale file name references to the renamed file `ext_cid.c` were left in comments.
--

commit 14b1d7b00c99cf24d69bf37c03dd5f2f1c7a83d3
Author: Tejun Heo <tj@kernel.org>

sched_ext: Move sources under kernel/sched/ext/

The sched_ext sources had grown to ten ext* files directly under
kernel/sched/. Move them into a new kernel/sched/ext/ subdirectory and drop
the now-redundant ext_ prefix. ext.c/h keep their names.

> diff --git a/kernel/sched/ext_cid.c b/kernel/sched/ext/cid.c
> similarity index 99%
> rename from kernel/sched/ext_cid.c
> rename to kernel/sched/ext/cid.c
> index 66944a7ef79d1..aeaea88f34c55 100644
> --- a/kernel/sched/ext_cid.c
> +++ b/kernel/sched/ext/cid.c
> @@ -71,7 +71,7 @@ static s32 scx_cid_arrays_alloc(void)
>   * scx_cid_init - build the cid mapping
>   * @sch: the scx_sched being initialized; used as the scx_error() target
>   *
> - * See "Topological CPU IDs" in ext_cid.h for the model. Walk online cpus by
> + * See "Topological CPU IDs" in cid.h for the model. Walk online cpus by
>   * intersection at each level (parent_scratch & this_level_mask), which keeps

[Severity: Low]
Were some stale file name references to ext_cid.c missed in the comments?

While this hunk updates the reference from ext_cid.h to cid.h, the block
comment in kernel/sched/ext/cid.h still references ext_cid.c:

kernel/sched/ext/cid.h:
 * possible-but-not-online cpus and carries all-(-1) topo info (see
 * scx_cid_topo); callers detect it via the -1 sentinels.
 *
 * See the comment above the table definitions in ext_cid.c for the
 * memory-ordering and visibility contract.

And the kernel-doc comment for scx_call_op_set_cpumask() also still
references it:

kernel/sched/ext/ext.c:scx_call_op_set_cpumask() {
 * @cpumask: new cpumask
 *
 * For cid-form schedulers, translate @cpumask to a cmask via the per-cpu
 * scratch in ext_cid.c and dispatch through the ops_cid union view. Caller
 * must hold @rq's rq lock so this_cpu_ptr is stable across the call.
 */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260621163026.434856-1-tj@kernel.org?part=1