Re: [PATCH] sched_ext: Fix missing @slice and @vtime descriptions in finish_dispatch() kernel-doc

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding kernel-doc descriptions for non-existent parameters `@slice` and `@vtime` causes an "Excess function parameter" kernel-doc warning.
--

--- Patch [1]: [PATCH] sched_ext: Fix missing @slice and @vtime descriptions in finish_dispatch() kernel-doc ---
commit 41530400fea7676e4713b34dcf07ebfd18e9b839
Author: Liang Luo <luoliang@kylinos.cn>

sched_ext: Fix missing @slice and @vtime descriptions in finish_dispatch() kernel-doc

This commit attempts to fix kernel-doc warnings by adding slice and vtime
parameter descriptions to the finish_dispatch() comment block.

> diff --git a/kernel/sched/ext/ext.c b/kernel/sched/ext/ext.c
> index 18183062f751c..84b2bb05ab90b 100644
> --- a/kernel/sched/ext/ext.c
> +++ b/kernel/sched/ext/ext.c
> @@ -2664,6 +2664,8 @@ static void dispatch_to_local_dsq(struct scx_sched *sch, struct rq *rq,
>   * @p: task to finish dispatching
>   * @qseq_at_dispatch: qseq when @p started getting dispatched
>   * @dsq_id: destination DSQ ID
> + * @slice: slice carried by the insert verdict, 0 keeps the current value
> + * @vtime: vtime carried by the insert verdict, committed on PRIQ inserts

[Severity: Low]
Will this trigger "Excess function parameter" kernel-doc warnings?

Looking at the code, finish_dispatch() does not appear to have slice or vtime
parameters in its signature:

static void finish_dispatch(struct scx_sched *sch, struct rq *rq,
                            struct task_struct *p,
                            unsigned long qseq_at_dispatch,
                            u64 dsq_id, u64 enq_flags)

>   * @enq_flags: %SCX_ENQ_*
>   *
>   * Dispatching to local DSQs may need to wait for queueing to complete or

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260825055053.2295139-1-luoliang@kylinos.cn?part=1