From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E836D2FDC28 for ; Thu, 10 Sep 2026 23:33:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789083212; cv=none; b=CAy+pwUDLFHl4qthtlAM9nUW1aUws9MiPwpJ5Jh+nCH0kgiaGJzexTaWygkbdNTb40Yv4cWpGBPnyxxVzVhVNtiJH/K0n1MvitubnMVu6/6wHfvcqUK4KVIQGor1g1vNq8jGmuJIv1uRN/gufq0ZBIuBfUV3WZEs5kGTnGEp2N4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789083212; c=relaxed/simple; bh=jDLmLkCeczOtHajVFOa0utVXnzToYKkhGjYJJdHBMOc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=N2lCKnIrNTqJV9Q0dgZzffipE4pjezX6W2wqXw4tJ+mmyzYZV3h2nUxPuGnGwOmsW0CKUnPSCZOtP52uhqfEdsey93tLSog+A75XlOiKlm/5XFUVMsKEkRYhi4sYxtYJowSZeOXi2BqytjomuBkEJI81ozU3hMnUy1WlWsL8Eyg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z+UUxgNL; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z+UUxgNL" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38e42560ebcso306076a91.1 for ; Thu, 10 Sep 2026 16:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789083210; x=1789688010; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=0E1uJRWOdeWeFR64RXVnaSEl2Q3657otbvouJpAZYtg=; b=Z+UUxgNLfW6dhpIPgqUKWlyPll6kp9EhfnNQh0WmWU0HR8/7RggDZSuf5Ks/EL6kCk Ti2dUBI2dSVraebTq0XcWNrshKRCpNkaqo8cFpXpFOu9o4CrEA7olmot9IvXSV4q5p3w mu9Tg7J4XZ31XiwHrtAgGjgCjE8uc8AUVMp4YBGqu/6XviQNeEyM8T5EP3P1lA4FWyas Ri6j+TptNAJS75pdW1nC1FqZeCM/3LVPJRwDOKhf2raOCDd22dCMetfB5ACAaq13ekmj rCVruHAA8u3YbuEi8bUtsA9BGIBl9Jfv0fubyPccXUIrIe54N5IQFTP7QbsLwMJFNYx6 7QFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789083210; x=1789688010; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0E1uJRWOdeWeFR64RXVnaSEl2Q3657otbvouJpAZYtg=; b=IX7nVAUlgfxN2XGwKlR422FR0hByuMjGsanMq1j/4MFZomjlg0hwmi/fdsRWvu6sN7 r4KuOUawVMiMp2ncrhZDfJsQHYafAZdx6VnCK+AGB68R2ezP/CdWS8CEbSnPVOIUS/BZ xaqtr2xO76Z9Ti6nZX3gUK4hKlu0+Tbt9T71rRcgAUThi+zVENnr4jQkP+PnTY5tFpYY D61R2ee5RujuXUd9PsakOvNPL0Vb33uCNxBtNQ1OWvV6neCio0Kowwx+unxbR6DcnkAr yy64s3Uoza4EzxgOvmvYgO4lPWSTBZjMV0Cr8dy8Rfyv94cruQs4rSEQMIN6SgytUP2H wUqA== X-Forwarded-Encrypted: i=1; AKwUvBxtVUUny3IBjlF+rgBVIWpYkdFQ8OiJp64I+0PLkFZTm5GFe3I9TjjwIh91Pqd3DatmXj/mE3M5TOQ=@lists.linux.dev X-Gm-Message-State: AFuF++l9xBUOQOUv8+CW6M2oqo4mqP2XBABAhT3Rr3dnZYl74S70LwQc 66HR5gPnHIxM5RUMC9P95KmmdHvZ7xcCzUun64vE/uuSf1ta1ORiBMKg X-Gm-Gg: AYBFou3dTJP6L+AWMg01L1NcKBeE9Y/bdkv4NRTG9EvuYtWUNd5Mmu+mt/SOsDVRUZ8 2tS4XkLGCsexbkAn9LuWCr8ra+EO39oxgqo5nFW13pAEArEqShaQAwXmhrY+eTiZe5QOhJb/fuy 136oOTSUsQ5webUVvga8OkT07Bijqi8biJ48mtWEb0HbK1/JDScPSfk5VZdE18wEXmIsNBfwF0y VRDO74QSp3/Vok7Y/zvpu/W8iX5FLkY+yJDwtRr8PBBJvsmeveikcoyzF4IU1BBDwr90tpZoKeR edHHTXaE264kB1iNNo/lAI4kvRjX96eHkbpPnxxqG6Wo+S6t/8FdBU1GoLgYez43BJCa1BTyOKG lx3EN/FnkcMpUzhTwiF2NWT5M0oRyCXRgJqnNRYlTy+tikCo0P9HWO3o6BHtJK2d6EkBb82tnrZ wmQkD6Naec6Ico8FEx+QeNoJImCDtw05S15EmRnYmzfHgLvIQK2GMPs2GWEVH4Qwot/A== X-Received: by 2002:a17:90b:4a8d:b0:39d:8222:6436 with SMTP id 98e67ed59e1d1-39d9bd8f51cmr1753897a91.7.1789083210158; Thu, 10 Sep 2026 16:33:30 -0700 (PDT) Received: from localhost ([2a03:2880:9ff:43::]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33ba4e95075sm1330595eec.11.2026.09.10.16.33.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 16:33:29 -0700 (PDT) From: Ziyang Men To: Shuah Khan , Tejun Heo , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Jiri Kosina , Benjamin Tissoires , David Vernet , Eduard Zingerman Cc: Viktor Malik , Andrea Righi , Changwoo Min , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , JP Kobryn , Mykola Lysenko , Nathan Chancellor , Ziyang Men , kernel-team@meta.com, linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org, linux-input@vger.kernel.org, sched-ext@lists.linux.dev, linux-mm@kvack.org, bpf@vger.kernel.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 0/4] selftests: add shared Makefile for BPF selftests and a new memcg test Date: Thu, 10 Sep 2026 16:32:59 -0700 Message-ID: <20260910233303.1063501-1-ziyang.meme@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: sched-ext@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series refactors the BPF-related build machinery that is currently duplicated across selftests/{bpf,sched_ext,hid}/. It adds the shared tools/testing/selftests/lib.bpf.mk fragment and wires up three consumers, simplifying both existing BPF selftests and future additions. The series also adds a cgroup memory-controller selftest that complements the existing coverage. Patch 1 adds lib.bpf.mk. Patch 2 adds selftests/cgroup/test_memcg_stat_cross_cpu, which verifies a cgroup flush by comparing values read through BPF memcg kfuncs with the corresponding cgroupfs values. The existing bpf/cgroup_iter_memcg test only checks whether selected values are non-zero. Patches 3 and 4 replace the duplicated BPF build machinery in selftests/{hid,sched_ext} with lib.bpf.mk. === Changes since v4: - Apply Tejun's suggestion: make the vmlinux.h stamp a normal prerequisite so dependent BPF objects rebuild in the same make invocation when the header changes. - Fix AI bot suggestion: assert in the BPF selftest that the memcg event enum argument types remain unsigned. This assert might not be necessary since these enum values are always uint32 on BTF. === Changes since v3: For shared Makefile: - Track in-tree libbpf headers directly so a single make invocation rebuilds BPF objects and skeletons after a header change. - Restore the target definitions needed by LoongArch and MIPS cross builds. - Validate output directories and skeleton suffixes, and reject dotted or hyphenated source stems before they reach build and cleanup rules. - Add stamp tracking for vmlinux.h generation while preserving content-based header updates. - Make skeletons and subskeletons explicit outputs, so a missing subskeleton is regenerated and both sets participate in the all target. - Namespace private variables, expand the caller-visible contract, track a supplied VMLINUX_H, and remove unnecessary include search paths. For cgroup selftest: - Add CONFIG_BPF_EVENTS and probe every required kfunc plus the sleepable cgroup iterator before running. - Bound CPU fanout, cgroup/process count, and total memory use; skip a case when the flush threshold would require more than 256 MiB. - Check CPU discovery, polling, iterator creation, and BPF errors, with clearer diagnostics. - Compare each BPF statistic against two following memory.stat samples, keeping exact equality on a quiet subtree while tolerating values that move between the two samples. For hid and sched_ext: - Remove unused HID locals instead of suppressing warnings, drop obsolete variables and comments, tighten cleanup, and correct the generated-output description. === Changes since v2: For shared Makefile: - Use USERCFLAGS and USERLDFLAGS to extend CFLAGS and LDFLAGS. - Pass OPT_FLAGS/RELEASE and EXTRA_CFLAGS to the libbpf and bpftool sub-makes. - Use one rule per BPF source instead of a global vpath that also affected the caller's normal %.c rules. - Take HOSTCC/HOSTLD from lib.mk instead of including Makefile.include, which also rewrote the caller's AR, LD, and CFLAGS. - Report a missing vmlinux from the recipe rather than at parse time, so "make clean" still works without BTF. For cgroup selftest: - Create one cgroup tree, perform one flush, then read through BPF and cgroupfs. - Use common cgroup helpers such as cg_read_key_long() and values_close(). - Use cpu_set_t rather than manually allocated CPU lists. - Move test_memcontrol.c's anonymous-memory allocator into cgroup_util. - Address the remaining review feedback. === Changes since v1: - Generalize lib.bpf.mk for source layouts and suffixes, extra headers and flags, skeleton suffixes, subskeletons, and configurable output directories. - Add patch 3 (hid) and patch 4 (sched_ext), converting those directories to the shared fragment. Ziyang Men (4): selftests: add shared lib.bpf.mk to build BPF progs and skeletons selftests/cgroup: add memcg_stat_cross_cpu correctness test for flush selftests/hid: build the BPF program via the shared lib.bpf.mk selftests/sched_ext: build BPF schedulers via the shared lib.bpf.mk tools/testing/selftests/cgroup/.gitignore | 8 + tools/testing/selftests/cgroup/Makefile | 46 ++ tools/testing/selftests/cgroup/config | 5 + .../selftests/cgroup/lib/cgroup_util.c | 82 ++ .../cgroup/lib/include/cgroup_util.h | 3 + .../cgroup/memcg_stat_cross_cpu.bpf.c | 101 +++ .../selftests/cgroup/memcg_stat_cross_cpu.h | 18 + .../cgroup/test_memcg_stat_cross_cpu.c | 755 ++++++++++++++++++ .../selftests/cgroup/test_memcontrol.c | 29 +- tools/testing/selftests/hid/.gitignore | 1 + tools/testing/selftests/hid/Makefile | 179 +---- tools/testing/selftests/hid/progs/hid.c | 7 +- tools/testing/selftests/lib.bpf.mk | 321 ++++++++ tools/testing/selftests/sched_ext/Makefile | 149 +--- 14 files changed, 1388 insertions(+), 316 deletions(-) create mode 100644 tools/testing/selftests/cgroup/memcg_stat_cross_cpu.bpf.c create mode 100644 tools/testing/selftests/cgroup/memcg_stat_cross_cpu.h create mode 100644 tools/testing/selftests/cgroup/test_memcg_stat_cross_cpu.c create mode 100644 tools/testing/selftests/lib.bpf.mk -- 2.53.0-Meta