From: Tejun Heo <tj@kernel.org>
To: Changwoo Min <changwoo@igalia.com>
Cc: David Vernet <void@manifault.com>,
Andrea Righi <arighi@nvidia.com>, Gavin Guo <gavinguo@igalia.com>,
kernel-dev@igalia.com, sched-ext@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] compat.bpf.h: add scx_bpf_reenqueue_local_from_anywhere() compat helper
Date: Mon, 17 Aug 2026 07:41:25 -1000 [thread overview]
Message-ID: <44199d9d01b3cc6fe3b07f57501e7e42@kernel.org> (raw)
In-Reply-To: <20260817143126.562923-3-changwoo@igalia.com>
Hello, Changwoo.
On Mon, Aug 17, 2026 at 11:31:26PM +0900, Changwoo Min wrote:
> + if (__COMPAT_scx_bpf_reenqueue_local_from_anywhere()) {
> + scx_bpf_reenqueue_local___v2___compat();
> + return 0;
> + }
> + return -ENOTSUP;
ENOTSUP is glibc-only. The BPF side picks up errno constants through
asm-generic/errno.h (see common.bpf.h), which only defines EOPNOTSUPP,
and as static inline bodies are checked in every TU whether called or
not, this breaks the BPF build for every scheduler. Use -EOPNOTSUPP like
__COMPAT_bpf_cpumask_populate() in the same file and update the
description accordingly. The pending scx-side PR needs the same fix.
The rest of the patch looks good to me.
Thanks.
--
tejun
prev parent reply other threads:[~2026-08-17 17:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 14:31 [PATCH 0/2] sched_ext: sync compat.bpf.h peek/reenqueue fixes from sched-ext/scx Changwoo Min
2026-08-17 14:31 ` [PATCH 1/2] compat.bpf.h: Gate scx_bpf_dsq_peek kfunc behind kernel version 7.1.0 Changwoo Min
2026-08-17 17:41 ` Tejun Heo
2026-08-17 14:31 ` [PATCH 2/2] compat.bpf.h: add scx_bpf_reenqueue_local_from_anywhere() compat helper Changwoo Min
2026-08-17 17:41 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44199d9d01b3cc6fe3b07f57501e7e42@kernel.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=gavinguo@igalia.com \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox