Sched_ext development
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: sashiko-bot@kernel.org, sched-ext@lists.linux.dev,
	Andrea Righi <arighi@nvidia.com>
Subject: Re: [PATCH v2 sched_ext/for-7.4-fixes] sched_ext: Fix stale pick when a wakeup resets the donor during dispatch
Date: Fri, 30 Oct 2026 16:01:25 -1000	[thread overview]
Message-ID: <4b5da2afa4e6c55c4cd809c1b4cef4c1@kernel.org> (raw)
In-Reply-To: <sashiko-outbox-191676@kernel.org>

Hello,

On Sat, Oct 31, 2026 at 12:29:44AM +0000, sashiko-bot@kernel.org wrote:
> - [High] sched_ext: unguarded keep-prev check in scx_dispatch_sched()

Fixed in v3, which also tests for a stale @prev there:

  https://lore.kernel.org/r/20261031015414.219280-1-tj@kernel.org

> - [Medium] sched_ext: premature cpu_acquire() before stale donor check in dispatch_one()

ops.cpu_acquire() is deprecated, so this doesn't matter.

> - [Medium] sched: stale rq->dl_server across RETRY_TASK in __pick_next_task()

That's a core sched bug independent of this patch. Reported separately:

  https://lore.kernel.org/r/6db076ee2562b5fb84d70ed59abe670e@kernel.org

Thanks.

--
tejun

      reply	other threads:[~2026-10-31  2:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 23:57 [PATCH v2 sched_ext/for-7.4-fixes] sched_ext: Fix stale pick when a wakeup resets the donor during dispatch Tejun Heo
2026-10-31  0:29 ` sashiko-bot
2026-10-31  2:01   ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b5da2afa4e6c55c4cd809c1b4cef4c1@kernel.org \
    --to=tj@kernel.org \
    --cc=arighi@nvidia.com \
    --cc=sashiko-bot@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sched-ext@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox