From: Tejun Heo <tj@kernel.org>
To: sched-ext@lists.linux.dev
Cc: sashiko-reviews@lists.linux.dev
Subject: Re: [PATCH v2 sched_ext/for-7.3 4/4] sched_ext: Split sub-scheduler implementation into sub.c
Date: Wed, 01 Jul 2026 09:47:05 -1000 [thread overview]
Message-ID: <602f4cda8f1891a43412a5a304f9c690@kernel.org> (raw)
In-Reply-To: <20260701183424.BAF9A1F00A3A@smtp.kernel.org>
Hello,
> - [Low] Compilation failure due to implicit function declarations in `sub.h`.
Yeah, scx_dispatch_sched() moved into sub.h calls three ext.c statics whose
declarations only land in a later patch, so 4/4 doesn't build on its own.
Another series-slicing mistake on my end. Will fix and post v3.
> - [High] The `scx_bpf_sub_dispatch` kfunc breaks runqueue lock atomicity for the parent BPF program.
ops.dispatch has never held the rq lock across its whole execution, and
scx_bpf_dsq_move_to_local() already drops and reacquires it when consuming a
remote task, so there's no continuous-lock guarantee to break.
> - [High] Missing `scx_error()` calls in `scx_sub_enable_workfn()` lead to silent sub-scheduler initialization failures and zombie states.
This will be addressed in a future patch.
Thanks.
--
tejun
next prev parent reply other threads:[~2026-07-01 19:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 18:10 [PATCHSET v2 sched_ext/for-7.3] sched_ext: Split sub-scheduler implementation into sub.c Tejun Heo
2026-07-01 18:10 ` [PATCH v2 sched_ext/for-7.3 1/4] sched_ext: Prefix file-local ext.c helpers exposed by the sub.c split Tejun Heo
2026-07-01 18:10 ` [PATCH v2 sched_ext/for-7.3 2/4] sched_ext: Expose the ext.c internals used " Tejun Heo
2026-07-01 18:10 ` [PATCH v2 sched_ext/for-7.3 3/4] sched_ext: Inline small ext.c helpers shared across " Tejun Heo
2026-07-01 18:10 ` [PATCH v2 sched_ext/for-7.3 4/4] sched_ext: Split sub-scheduler implementation into sub.c Tejun Heo
2026-07-01 18:34 ` sashiko-bot
2026-07-01 19:47 ` Tejun Heo [this message]
2026-07-01 19:43 ` [PATCHSET v2 sched_ext/for-7.3] " Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=602f4cda8f1891a43412a5a304f9c690@kernel.org \
--to=tj@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sched-ext@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox