Sched_ext development
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Michal Koutny <mkoutny@suse.com>,
	tj@kernel.org, sched-ext@lists.linux.dev
Subject: Re: [PATCH 1/2] sched/psi: Create the psimon kthread outside of cgroup_mutex
Date: Sun, 12 Jul 2026 10:26:53 -1000	[thread overview]
Message-ID: <60b5a9ee3c9d3f248cf70e68014b8cea@kernel.org> (raw)
In-Reply-To: <20260712180032.087AF1F000E9@smtp.kernel.org>

Hello.

> If this error path is reached (e.g. by racing pressure_write() with cgroup
> rmdir making of->priv NULL), the calling thread would sleep for an RCU grace
> period while holding cgroup_mutex, stalling all other cgroup operations.
>
> Could the trigger destruction be deferred until after cgroup_mutex is dropped,
> or handled asynchronously to avoid stalling the cgroup subsystem?

This is pre-existing - rmdir and cgroup.pressure disable already destroy
triggers under cgroup_mutex when draining open fds. Maybe something to
improve in the future.

Thanks.

--
tejun

  reply	other threads:[~2026-07-12 20:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-12 17:46 [PATCHSET v2] sched/psi: Fix psimon fork deadlock and rtpoll_timer UAF Tejun Heo
2026-07-12 17:46 ` [PATCH 1/2] sched/psi: Create the psimon kthread outside of cgroup_mutex Tejun Heo
2026-07-12 18:00   ` sashiko-bot
2026-07-12 20:26     ` Tejun Heo [this message]
2026-07-13 10:51   ` Johannes Weiner
2026-07-13 13:48   ` Matt Fleming
2026-07-13 15:19     ` Suren Baghdasaryan
2026-07-12 17:46 ` [PATCH 2/2] sched/psi: Shut down rtpoll_timer in psi_cgroup_free() Tejun Heo
2026-07-13 10:56   ` Johannes Weiner
2026-07-13 14:07     ` Suren Baghdasaryan
2026-07-13 15:19       ` Suren Baghdasaryan
2026-07-13 13:48   ` Matt Fleming
2026-07-13 13:49 ` [PATCHSET v2] sched/psi: Fix psimon fork deadlock and rtpoll_timer UAF Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60b5a9ee3c9d3f248cf70e68014b8cea@kernel.org \
    --to=tj@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=mkoutny@suse.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sched-ext@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox