From: Tejun Heo <tj@kernel.org>
To: Cheng-Yang Chou <yphbchou0911@gmail.com>
Cc: sched-ext@lists.linux.dev, David Vernet <void@manifault.com>,
Andrea Righi <arighi@nvidia.com>,
Changwoo Min <changwoo@igalia.com>,
Ching-Chun Huang <jserv@ccns.ncku.edu.tw>,
Chia-Ping Tsai <chia7712@gmail.com>,
chengyang.chou@mediatek.com
Subject: Re: [PATCH 2/2] selftests/sched_ext: Move -rdynamic to LDFLAGS and append to it
Date: Tue, 08 Sep 2026 07:09:58 -1000 [thread overview]
Message-ID: <69b6f95a0a592588389a45c36f47c4c2@kernel.org> (raw)
In-Reply-To: <20260908134722.8671-3-yphbchou0911@gmail.com>
Hello,
On Tue, Sep 08, 2026 at 09:47:09PM +0800, Cheng-Yang Chou wrote:
> Unlike the demo schedulers, the selftest runner requires -rdynamic at
> link time to populate .dynsym for testcases. Additionally, LDFLAGS uses
> '=' rather than '+=', silently discarding USERLDFLAGS from lib.mk.
The runner doesn't need -rdynamic. Testcases register through constructors
calling scx_test_register() and nothing in the selftests, tools/sched_ext or
libbpf looks up symbols dynamically or prints backtraces. The flag was copied
from the BPF selftests where the test_progs crash handler needs it for
backtrace symbolization. Please drop -rdynamic here too, as in the first
patch. The '=' to '+=' change is good, keep that.
Thanks.
--
tejun
next prev parent reply other threads:[~2026-09-08 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 13:47 [PATCH sched_ext/for-7.4 0/2] sched_ext: Clean up -rdynamic and LDFLAGS in Makefiles Cheng-Yang Chou
2026-09-08 13:47 ` [PATCH 1/2] tools/sched_ext: Drop the no-op -rdynamic from CFLAGS Cheng-Yang Chou
2026-09-08 13:47 ` [PATCH 2/2] selftests/sched_ext: Move -rdynamic to LDFLAGS and append to it Cheng-Yang Chou
2026-09-08 17:09 ` Tejun Heo [this message]
2026-09-09 14:55 ` Cheng-Yang Chou
2026-09-08 17:09 ` [PATCH 1/2] tools/sched_ext: Drop the no-op -rdynamic from CFLAGS Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69b6f95a0a592588389a45c36f47c4c2@kernel.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=chengyang.chou@mediatek.com \
--cc=chia7712@gmail.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=sched-ext@lists.linux.dev \
--cc=void@manifault.com \
--cc=yphbchou0911@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox