From: "Kumar Kartikeya Dwivedi" <memxor@gmail.com>
To: "Nicholas Dudar" <main.kalliope@gmail.com>, <ast@kernel.org>,
<daniel@iogearbox.net>, <andrii@kernel.org>, <eddyz87@gmail.com>,
<memxor@gmail.com>, <emil@etsalapatis.com>
Cc: <tj@kernel.org>, <void@manifault.com>, <arighi@nvidia.com>,
<changwoo@igalia.com>, <bpf@vger.kernel.org>,
<sched-ext@lists.linux.dev>
Subject: Re: [PATCH bpf-next v3 0/2] bpf: require an owned cpumask for bpf_cpumask_populate()
Date: Fri, 10 Jul 2026 21:17:08 +0200 [thread overview]
Message-ID: <DJV4SE3UC9L5.2MM3IGLHLQICW@gmail.com> (raw)
In-Reply-To: <20260709182800.2037938-1-main.kalliope@gmail.com>
On Thu Jul 9, 2026 at 8:27 PM CEST, Nicholas Dudar wrote:
> bpf_cpumask_populate() writes its destination with bitmap_copy() but
> types it as struct cpumask *, so the verifier accepts a borrowed,
> read-only cpumask (for example from scx_bpf_get_online_cpumask()) as a
> writable destination. Fix it and add a selftest for coverage.
>
+To Emil
Hi sched-ext folks, this fix looks good to me and on cursory look, apart from
potential signature change which may require some adjustment to casts, it should
not break existing intendended usage.
Could others confirm this? Thanks
> [...]
next prev parent reply other threads:[~2026-07-10 19:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 18:27 [PATCH bpf-next v3 0/2] bpf: require an owned cpumask for bpf_cpumask_populate() Nicholas Dudar
2026-07-09 18:27 ` [PATCH bpf-next v3 1/2] bpf: Require a BPF " Nicholas Dudar
2026-07-09 18:39 ` sashiko-bot
2026-07-10 19:18 ` Kumar Kartikeya Dwivedi
2026-07-10 20:17 ` Admin
2026-07-10 20:34 ` Kumar Kartikeya Dwivedi
2026-07-10 23:43 ` Emil Tsalapatis
2026-07-10 23:42 ` Emil Tsalapatis
2026-07-09 18:28 ` [PATCH bpf-next v3 2/2] selftests/bpf: test bpf_cpumask_populate() rejects a borrowed cpumask Nicholas Dudar
2026-07-10 23:51 ` Emil Tsalapatis
2026-07-10 19:17 ` Kumar Kartikeya Dwivedi [this message]
2026-07-11 23:38 ` [PATCH bpf-next v3 0/2] bpf: require an owned cpumask for bpf_cpumask_populate() Tejun Heo
2026-07-11 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJV4SE3UC9L5.2MM3IGLHLQICW@gmail.com \
--to=memxor@gmail.com \
--cc=andrii@kernel.org \
--cc=arighi@nvidia.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=changwoo@igalia.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=main.kalliope@gmail.com \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox