From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBC3B303A3C for ; Fri, 7 Nov 2025 06:51:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762498319; cv=none; b=e90xU/wZuCIkxZVCMolzby7vRkCQ1bhKD6iaOshfQ06bFPwOHwcw+FNrCRxTCk409tPgRV8XwvwSo0i1W92LsrnxM6JdWNEPIwEdYcekkNhRn2DETk0aqwW5Hg5z1L6PHLZpwP7UuW3I8tDtWgxAe5th0vJT/QsUgHVaDyBYYV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762498319; c=relaxed/simple; bh=uPG2qaEExT59WP2ysS8ErG3/JwdyIv1CjufizYF4whg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=gCfr7je9gefXGzLyTzJcR4uBXqeLYCwfTe7qzueNt6NjIKo90yiXpfWJEHpzHU7crvXrICZXqOl0slKKYKdxOz3mitOhxD8mQZAg8rk19GmRKu146MDY2xoL/zy0jkWf2qjK4jPYMficUcNqCUPS28F1N5dpmcY34twiBury/SY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JrU/OI9U; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JrU/OI9U" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762498316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zYmb/mOjOmAnHynzCc5urdD/k2k7E8plshDwUAI/8Ps=; b=JrU/OI9U+FY8Hugbv45BCCzhElGJXfVcePGkvTIjOc7w0XyVRxqPa9m7Gt9/Z8QJG8cyUh PH5HSFe8DtP4Ekz50L1PrD0Ee61DFknIHFPsTZ2MllVMzSg30dOXQTINjQxqiRK/qs/ftu aCH9y+i1dIeN7vpGkQ57MQ37gLC4ZdA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-338-g5gj2RI6NWawscT8yK5GjA-1; Fri, 07 Nov 2025 01:51:54 -0500 X-MC-Unique: g5gj2RI6NWawscT8yK5GjA-1 X-Mimecast-MFC-AGG-ID: g5gj2RI6NWawscT8yK5GjA_1762498313 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-429be5aee5bso156543f8f.3 for ; Thu, 06 Nov 2025 22:51:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762498313; x=1763103113; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zYmb/mOjOmAnHynzCc5urdD/k2k7E8plshDwUAI/8Ps=; b=xOTpmPSCZ3+8lN0ymnWSDWkJ1/Ezlll7A1TjvVjZsR/bGBXeSqYgpTmfLZ7PK5kjAw njy4dhJDu0zIFdWjkRK9o5mE7w0whh72P/evT14FeMR7EIzGaMKCq2fLIIy99I3KwOqw 0INYWfklEQa4sRxQPo1MMemlyc3HGXzJ+/VVMZcGPkZLOsp7MW0HteS3kMex3uDi3Jsd DtunOiAr9XEYT4WAKhxaOF/lrcqtjChnbOY4Oe6gqJCdjI06+KMLXK4HYzmVCiUSAS0Y nb3YkvM9YPV9wsxsHj0EGgZki2CZSyuJ5RUCmDDpM7YvdszQK/vEUBysQ6NeiYdBRJka DTgw== X-Forwarded-Encrypted: i=1; AJvYcCXJuF3cOQ7qZFvgn/Ju+QavXlrJc4rnvaUOZW8CerTEgYc8OnVb0FvDSZtrrj+FfdH2gZXJyCkNehI=@lists.linux.dev X-Gm-Message-State: AOJu0YynF9UIFGzVdwkph1Fyh2930NvTLYe5MuED8eQrrla+7tH6XSiG g21jpOUJLCjxnOMwEIRRkm9fjj0DmykTfkr+rsj//Ghdx2wsmanQ53kY/d8/A5H0rd9ekgXsc8n beA9DVlFOWXpFaIyOybP6kQdpInXEtVGAOxu59CF5UA5tjLSLfrStEtwpzSDCzA== X-Gm-Gg: ASbGnctxfVR7n3gJ4JsLPeSoA2b9QaP/yz7uFl8aXJaWFdOlZ5NszBu5B/Y6+td/LY3 7R90kOCsyZATnrx3OTPNP1m6z+3/LjSAzZzUbj9a/D97WNeGuszLgNkVApI9L2PJPt/nqwpvbwE ijbCADBcH/O9hlcdzptQAjfe4y6Q5SMs5/rZv3DZtbNptVh10kLOL4+bsfp3Jq4Khz/rdhl4/H0 eJ+UflMRurtOm8QwmmysZVAu0xH/JWxnOIqfso1yjslNiNbb1fGIfWRL8XttQ9jdNrCc6Z7dBPy GUKA+ZvCWnd2TE49KDVxm6td/hgxSH89McuYzEdBvf0HchXMlHdqCUDA3kbeY9LLQrqoFrROFds 20o8162E+k1wKY0gokgkZMr8pNxo/8Q== X-Received: by 2002:a05:6000:18a7:b0:428:4b76:c8cd with SMTP id ffacd0b85a97d-42ae5af3d30mr1473393f8f.62.1762498312783; Thu, 06 Nov 2025 22:51:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IEkTAZvSZYGErM/J0GLN/rgaF1MnsQc3qO4BrVNXh5vafIXUbVWfdF5xK+Ug878KB2EOdOBvg== X-Received: by 2002:a05:6000:18a7:b0:428:4b76:c8cd with SMTP id ffacd0b85a97d-42ae5af3d30mr1473371f8f.62.1762498312396; Thu, 06 Nov 2025 22:51:52 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.129.40]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42abe63dfecsm3408533f8f.12.2025.11.06.22.51.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Nov 2025 22:51:51 -0800 (PST) Date: Fri, 7 Nov 2025 07:51:49 +0100 From: Juri Lelli To: Andrea Righi Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Tejun Heo , David Vernet , Changwoo Min , Shuah Khan , Joel Fernandes , Christian Loehle , Emil Tsalapatis , Luigi De Matteis , sched-ext@lists.linux.dev, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/11] sched/debug: Stop and start server based on if it was active Message-ID: References: <20251029191111.167537-1-arighi@nvidia.com> <20251029191111.167537-3-arighi@nvidia.com> Precedence: bulk X-Mailing-List: sched-ext@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vsobmvk8tILpotVDjknqo_tcQ36DnHLWq2GTgXGDJOk_1762498313 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On 06/11/25 17:39, Andrea Righi wrote: > On Thu, Nov 06, 2025 at 08:13:39AM +0100, Juri Lelli wrote: ... > > > @@ -376,8 +378,11 @@ static ssize_t sched_fair_server_write(struct file *filp, const char __user *ubu > > > return -EINVAL; > > > } > > > > > > - update_rq_clock(rq); > > > - dl_server_stop(&rq->fair_server); > > > + is_active = dl_server_active(&rq->fair_server); > > > + if (is_active) { > > > + update_rq_clock(rq); > > > + dl_server_stop(&rq->fair_server); > > > + } > > > > > > retval = dl_server_apply_params(&rq->fair_server, runtime, period, 0); > > > > > > @@ -385,7 +390,7 @@ static ssize_t sched_fair_server_write(struct file *filp, const char __user *ubu > > > printk_deferred("Fair server disabled in CPU %d, system may crash due to starvation.\n", > > > cpu_of(rq)); > > > > > > - if (rq->cfs.h_nr_queued) > > > + if (is_active) > > > dl_server_start(&rq->fair_server); > > > > Something that I noticed while reviewing this series is that we still > > start back a server even if the user put its runtime to zero (disabling > > it) and I don't think we want to do that. It's not of course related to > > this change or this series per-se, but something we probably want to fix > > independently. > > Should we just call dl_server_remove_params() when runtime is zero? Looking again at it I actually wonder if wouldn't it be better to use dl_server_apply_params(dl_se, 0, dl_se->dl_period, false) in both cases. dl_rq_change_utilization() deals with dl_non_contending (inactive_timer armed) case already (even though sub-optimally, but we can fix/change it later), so we can probably remove the special handling you do in dl_server_remove_params(). The WARN_ON_ONCE(on_dl_rq()) could be moved to dl_server_apply_params() as well. What do you think?