Re: [PATCH] tools/sched_ext: Fix get_prandom_u64() prototype

[Cheng-Yang Chou <yphbchou0911@gmail.com>]

On Sun, Mar 08, 2026 at 03:01:59PM +0100, Andrea Righi wrote:
> Hi,
> 
> On Sun, Mar 08, 2026 at 09:06:38PM +0800, Cheng-Yang Chou wrote:
> > In C99 (Sec 6.7.5.3), an empty parameter list in a declaration leaves
> > the parameter types unspecified (K&R style), not explicitly zero.
> > Consequently, the compiler would silently accept arbitrary arguments
> > passed to the function.
> > 
> > Declare the function with (void) to form a proper prototype asserting
> > it takes no arguments.
> > 
> > Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
> 
> I understand the motivation, but changes like this don't fix real issues or
> provide any measurable benefit. Patches consume maintainer and reviewer
> bandwidth, so it's usually best to focus on changes that fix real bugs or
> provide clear improvements.
> 
> If you encounter a real issue or can show a measurable improvement (with
> traces or numbers), patches addressing that would be much more useful.
> 
> Thanks,
> -Andrea

Understood.
Again, thanks for the explaination.

-- 
Thanks,
Cheng-Yang