From: Cheng-Yang Chou <yphbchou0911@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: sched-ext@lists.linux.dev, void@manifault.com, arighi@nvidia.com,
changwoo@igalia.com, jserv@ccns.ncku.edu.tw
Subject: Re: [PATCH] sched_ext: Add missing braces to multi-line blocks
Date: Thu, 5 Mar 2026 02:13:58 +0800 [thread overview]
Message-ID: <aah2Zv6kLdGFusuy@eric-wcnlab> (raw)
In-Reply-To: <aahw51fT1ANEhIUh@slm.duckdns.org>
On Wed, Mar 04, 2026 at 07:50:31AM -1000, Tejun Heo wrote:
> Hello,
>
> On Thu, Mar 05, 2026 at 01:12:59AM +0800, Cheng-Yang Chou wrote:
> > On Mon, Mar 02, 2026 at 03:13:32PM +0800, Cheng-Yang Chou wrote:
> > > Add braces around outer loops and conditionals that contain multi-line
> > > inner statements in both ext.c and ext_idle.c.
> > >
> > > According to the kernel maintainer tip bracket rules, brackets should
> > > only be omitted if the statement following an 'if' or 'for' is truly
> > > a single line. This improves reading flow and prevents future errors.
> > >
> > > Link: https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#bracket-rules
> > >
> >
> > Gentle ping on this minor style fix.
> > No rush at all, just making sure it didn't slip by.
>
> I don't think these trivial patches are useful. Ask yourself, is the code
> meaningfully better afterwards? Maybe as a part of some other big changes,
> these might make sense, but, by themselves, it's just noise, a busy work.
> Please don't send these patches.
>
> Thanks.
>
> --
> tejun
Understood.
Thanks for the feedback!
--
Thanks,
Cheng-Yang
prev parent reply other threads:[~2026-03-04 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 7:13 [PATCH] sched_ext: Add missing braces to multi-line blocks Cheng-Yang Chou
2026-03-04 17:12 ` Cheng-Yang Chou
2026-03-04 17:50 ` Tejun Heo
2026-03-04 18:13 ` Cheng-Yang Chou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aah2Zv6kLdGFusuy@eric-wcnlab \
--to=yphbchou0911@gmail.com \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox