[PATCH] sched_ext: Add missing braces to multi-line blocks

[PATCH] sched_ext: Add missing braces to multi-line blocks

[Cheng-Yang Chou]

Add braces around outer loops and conditionals that contain multi-line
inner statements in both ext.c and ext_idle.c.

According to the kernel maintainer tip bracket rules, brackets should
only be omitted if the statement following an 'if' or 'for' is truly
a single line. This improves reading flow and prevents future errors.

Link: https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#bracket-rules

Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
---
 kernel/sched/ext.c      | 6 ++++--
 kernel/sched/ext_idle.c | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index 9280381f8923..8fcee252d30e 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -5038,9 +5038,10 @@ static int scx_enable(struct sched_ext_ops *ops, struct bpf_link *link)
 		sch->exit_info->flags |= SCX_EFLAG_INITIALIZED;
 	}
 
-	for (i = SCX_OPI_CPU_HOTPLUG_BEGIN; i < SCX_OPI_CPU_HOTPLUG_END; i++)
+	for (i = SCX_OPI_CPU_HOTPLUG_BEGIN; i < SCX_OPI_CPU_HOTPLUG_END; i++) {
 		if (((void (**)(void))ops)[i])
 			set_bit(i, sch->has_op);
+	}
 
 	ret = check_hotplug_seq(sch, ops);
 	if (ret) {
@@ -5084,9 +5085,10 @@ static int scx_enable(struct sched_ext_ops *ops, struct bpf_link *link)
 	scx_bypass(true);
 	scx_bypassed_for_enable = true;
 
-	for (i = SCX_OPI_NORMAL_BEGIN; i < SCX_OPI_NORMAL_END; i++)
+	for (i = SCX_OPI_NORMAL_BEGIN; i < SCX_OPI_NORMAL_END; i++) {
 		if (((void (**)(void))ops)[i])
 			set_bit(i, sch->has_op);
+	}
 
 	if (sch->ops.cpu_acquire || sch->ops.cpu_release)
 		sch->ops.flags |= SCX_OPS_HAS_CPU_PREEMPT;
diff --git a/kernel/sched/ext_idle.c b/kernel/sched/ext_idle.c
index e2da6c3968a6..22bf96753f1c 100644
--- a/kernel/sched/ext_idle.c
+++ b/kernel/sched/ext_idle.c
@@ -323,9 +323,10 @@ static bool llc_numa_mismatch(void)
 	 * overlapping, which is incorrect (as NUMA 1 has two distinct LLC
 	 * domains).
 	 */
-	for_each_online_cpu(cpu)
+	for_each_online_cpu(cpu) {
 		if (llc_weight(cpu) != numa_weight(cpu))
 			return true;
+	}
 
 	return false;
 }
@@ -752,9 +753,10 @@ void __scx_update_idle(struct rq *rq, bool idle, bool do_notify)
 	 * In this way we can avoid updating the idle masks twice,
 	 * unnecessarily.
 	 */
-	if (static_branch_likely(&scx_builtin_idle_enabled))
+	if (static_branch_likely(&scx_builtin_idle_enabled)) {
 		if (do_notify || is_idle_task(rq->curr))
 			update_builtin_idle(cpu, idle);
+	}
 
 	/*
 	 * Trigger ops.update_idle() only when transitioning from a task to
-- 
2.48.1

Re: [PATCH] sched_ext: Add missing braces to multi-line blocks

[Cheng-Yang Chou]

On Mon, Mar 02, 2026 at 03:13:32PM +0800, Cheng-Yang Chou wrote:
> Add braces around outer loops and conditionals that contain multi-line
> inner statements in both ext.c and ext_idle.c.
> 
> According to the kernel maintainer tip bracket rules, brackets should
> only be omitted if the statement following an 'if' or 'for' is truly
> a single line. This improves reading flow and prevents future errors.
> 
> Link: https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#bracket-rules
> 

Gentle ping on this minor style fix.
No rush at all, just making sure it didn't slip by.

-- 
Thanks,
Cheng-Yang

Re: [PATCH] sched_ext: Add missing braces to multi-line blocks

[Tejun Heo]

Hello,

On Thu, Mar 05, 2026 at 01:12:59AM +0800, Cheng-Yang Chou wrote:
> On Mon, Mar 02, 2026 at 03:13:32PM +0800, Cheng-Yang Chou wrote:
> > Add braces around outer loops and conditionals that contain multi-line
> > inner statements in both ext.c and ext_idle.c.
> > 
> > According to the kernel maintainer tip bracket rules, brackets should
> > only be omitted if the statement following an 'if' or 'for' is truly
> > a single line. This improves reading flow and prevents future errors.
> > 
> > Link: https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#bracket-rules
> > 
> 
> Gentle ping on this minor style fix.
> No rush at all, just making sure it didn't slip by.

I don't think these trivial patches are useful. Ask yourself, is the code
meaningfully better afterwards? Maybe as a part of some other big changes,
these might make sense, but, by themselves, it's just noise, a busy work.
Please don't send these patches.

Thanks.

-- 
tejun

Re: [PATCH] sched_ext: Add missing braces to multi-line blocks

[Cheng-Yang Chou]

On Wed, Mar 04, 2026 at 07:50:31AM -1000, Tejun Heo wrote:
> Hello,
> 
> On Thu, Mar 05, 2026 at 01:12:59AM +0800, Cheng-Yang Chou wrote:
> > On Mon, Mar 02, 2026 at 03:13:32PM +0800, Cheng-Yang Chou wrote:
> > > Add braces around outer loops and conditionals that contain multi-line
> > > inner statements in both ext.c and ext_idle.c.
> > > 
> > > According to the kernel maintainer tip bracket rules, brackets should
> > > only be omitted if the statement following an 'if' or 'for' is truly
> > > a single line. This improves reading flow and prevents future errors.
> > > 
> > > Link: https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#bracket-rules
> > > 
> > 
> > Gentle ping on this minor style fix.
> > No rush at all, just making sure it didn't slip by.
> 
> I don't think these trivial patches are useful. Ask yourself, is the code
> meaningfully better afterwards? Maybe as a part of some other big changes,
> these might make sense, but, by themselves, it's just noise, a busy work.
> Please don't send these patches.
> 
> Thanks.
> 
> -- 
> tejun

Understood.
Thanks for the feedback!

-- 
Thanks,
Cheng-Yang