From: Cheng-Yang Chou <yphbchou0911@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: sched-ext@lists.linux.dev, void@manifault.com, arighi@nvidia.com,
changwoo@igalia.com, jserv@ccns.ncku.edu.tw
Subject: Re: [PATCH v3 1/2] sched_ext: Update demo schedulers and selftests to use scx_bpf_task_set_dsq_vtime()
Date: Sat, 14 Mar 2026 10:50:37 +0800 [thread overview]
Message-ID: <abTM_Rmi5NzZsf2b@eric-acer> (raw)
In-Reply-To: <abRBwZCwaYNqRSpj@slm.duckdns.org>
On Fri, Mar 13, 2026 at 06:56:33AM -1000, Tejun Heo wrote:
> > */
> > + u64 delta = scale_by_task_weight_inverse(p, SCX_SLICE_DFL - p->scx.slice);
> > +
> > if (!fifo_sched)
> > - p->scx.dsq_vtime +=
> > - (SCX_SLICE_DFL - p->scx.slice) * 100 / p->scx.weight;
> > + scx_bpf_task_set_dsq_vtime(p, p->scx.dsq_vtime + delta);
>
> Wouldn't it make more sense for delta to be inside the if block?
Agree!
--
Thanks,
Cheng-Yang
next prev parent reply other threads:[~2026-03-14 2:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 1:49 [PATCH v3 0/2] sched_ext: Update demo schedulers and selftests for deprecated APIs Cheng-Yang Chou
2026-03-13 1:49 ` [PATCH v3 1/2] sched_ext: Update demo schedulers and selftests to use scx_bpf_task_set_dsq_vtime() Cheng-Yang Chou
2026-03-13 16:56 ` Tejun Heo
2026-03-14 2:50 ` Cheng-Yang Chou [this message]
2026-03-13 1:49 ` [PATCH v3 2/2] sched_ext: Update demo schedulers and selftests to drop ops.cpu_acquire/release() Cheng-Yang Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abTM_Rmi5NzZsf2b@eric-acer \
--to=yphbchou0911@gmail.com \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox